mirror of
https://github.com/PostHog/posthog.git
synced 2024-11-25 02:49:32 +01:00
c0327835c7
* fix(hooks): validate domain name * Add test * mypy * Fixes after CR * Remove redundant `bool()` Co-authored-by: Michael Matloka <dev@twixes.com>
49 lines
1.6 KiB
Python
49 lines
1.6 KiB
Python
from typing import cast
|
|
from urllib.parse import urlparse
|
|
|
|
from django.conf import settings
|
|
from rest_framework import exceptions, serializers, viewsets
|
|
from rest_framework.permissions import IsAuthenticated
|
|
|
|
from ee.models.hook import Hook
|
|
from posthog.api.routing import StructuredViewSetMixin
|
|
from posthog.models.user import User
|
|
from posthog.permissions import OrganizationMemberPermissions, TeamMemberAccessPermission
|
|
|
|
|
|
class HookSerializer(serializers.ModelSerializer):
|
|
class Meta:
|
|
model = Hook
|
|
fields = ("id", "created", "updated", "event", "target", "resource_id", "team")
|
|
read_only_fields = ("team",)
|
|
|
|
def validate_event(self, event):
|
|
if event not in settings.HOOK_EVENTS:
|
|
raise exceptions.ValidationError(detail=f"Unexpected event {event}")
|
|
return event
|
|
|
|
def validate_target(self, target):
|
|
if not valid_domain(target):
|
|
raise exceptions.ValidationError(detail=f"'hooks.zapier.com' is the only allowed target domain")
|
|
return target
|
|
|
|
|
|
class HookViewSet(StructuredViewSetMixin, viewsets.ModelViewSet):
|
|
"""
|
|
Retrieve, create, update or destroy REST hooks.
|
|
"""
|
|
|
|
queryset = Hook.objects.all()
|
|
ordering = "-created_at"
|
|
permission_classes = [IsAuthenticated, OrganizationMemberPermissions, TeamMemberAccessPermission]
|
|
serializer_class = HookSerializer
|
|
|
|
def perform_create(self, serializer):
|
|
user = cast(User, self.request.user)
|
|
serializer.save(user=user, team_id=self.team_id)
|
|
|
|
|
|
def valid_domain(url) -> bool:
|
|
target_domain = urlparse(url).netloc
|
|
return target_domain == "hooks.zapier.com"
|