0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

1821 Commits

Author SHA1 Message Date
Harry Waye
eb4082241f
feat(correlation): add property correlation to funnels UI (#6328) 2021-10-08 16:31:02 +03:00
Marius Andra
00633412cc
Insight logic refactor version 1 - keyed insightLogic (#6310)
* kea test "toNotHaveDispatchedActions"

* fix dashboard logic test

* add props and key to insight logic (has no effect)

* inform about is_sample's uniqueness

* use common InsightLogicProps

* persist state via BindLogic and shared insightProps

* persist hashParams

* remove cached Urls

* upgrade new to saved logic

* upgrade typegen

* patch metadata logic

* always show title if saved insights active

* fix negative bug

* fix interval filter

* go to view mode after saving

* full reload when going from dashboard to insight

* use clean filter

* createInsight is no longer used

* fix tests

* fix setAllFilters

* clean retention table duplicate code, fix test

* scene has its own key

* unify insightLogicProps key logic

* consolidate logic fetching

* fix test

* fix reloads

* clears the scene funnel

* move setInsight to reducer

* stronger clicks on menu items

* remove wait

* clarify testcases
2021-10-08 12:13:23 +00:00
Li Yi Yu
cd5e164d91
Paths highlighting for path start and end (#6297)
* node highlighting for path start and end

* rename for clarity

* check for funnel paths between steps

* clean up renderPaths function

* move tooltip placement

* forgot to commit util file
2021-10-07 20:22:54 -04:00
Eric Duong
cdfab3d821
paths: Default params funnel and prompt (#6317)
* add pageview and cusotm events as default types

* add prompt
2021-10-07 18:11:18 -04:00
Neil Kakkar
e062d5113f
add CH guard to Correlation API Calls (#6315) 2021-10-07 19:00:48 +01:00
Alex Gyujin Kim
970e2892b0
Remove saved funnels (#6313)
* follow up on todo

* ff
2021-10-07 09:55:54 -07:00
Marius Andra
f2c9c522bf
Remove scrollbar (#6304)
* remove scrollbar

* revert list height to 32px
2021-10-07 08:21:10 +00:00
Marcus Hyett (PostHog)
3520b553a4
Colon in Dashboard Name Search (#6291)
* Added colon in Go To dashboard search

* Moved colon to correct place
2021-10-07 09:44:14 +02:00
Michael Matloka
96760e0096
Reduce direct usage of user.team (#6206)
* Reduce direct usage of `user.team`

* Add missing `.id`

* Remove unused `type: ignore`s

* Fix typing issue

* Remove selector circular dependency between `userLogic` and `teamLogic`

* Try to simplify things to fix circular dependency

* Remove extraneous typing
2021-10-07 09:33:37 +02:00
Paul D'Ambra
73de6cd9fd
Adds a hot key keypress detection method that isn't flummoxed by the shadow DOM (#6249)
* adds a detection method that isn't flummoxed by the shadow dom

* guard against not having a result for path from older browsers

* guard against the event target returned by composePath not being an html element

* composePath is the standard, check it first
2021-10-07 09:12:49 +02:00
Paolo D'Amico
9d4287c1c4
Clarify copy on data point click (#6255) 2021-10-07 08:08:27 +03:00
Alex Gyujin Kim
04045ff466
Add default count_operator thats already selected on changing match type (#6295) 2021-10-06 13:55:19 -07:00
Neil Kakkar
d4a1151c49
Path Wildcards in Taxonomic Filter (#6205)
* Path Wildcards in Taxonomic Filter

* better handling

* ADD LOGIC TEST
2021-10-06 16:06:52 -04:00
Li Yi Yu
cb3b394633
Paths related UI fixes (#6257)
* paths related UI fixes

* add tooltip for long urls

* more fixes

* show cards on hover for smaller paths

* styling and font fixes

* increase font weight

* clean up code

* highlight start and end paths on hover

* undo path start end highlight

* add logic for highlighting all sources

* add centering and move constant

* restore number to normal

Co-authored-by: eric <eeoneric@gmail.com>
2021-10-06 15:37:04 -04:00
Neil Kakkar
750116101a
fix (#6290) 2021-10-06 11:57:53 -04:00
Paul D'Ambra
ad17f9c7be
add a clearer loading state on the events table and start in loading state (#6256)
closes #6192
2021-10-06 15:34:01 +01:00
Neil Kakkar
7bfeb9d1b9
Add basic model for Correlation analysis on Funnels behind FF (#6258)
* Add basic model for Correlation analysis on Funnels behind FF

* make frontend ready for testing

* address comments

* prettier
2021-10-06 13:14:32 +01:00
Eric Duong
b5ed0b7221
paths: funnel-path date alignment and funnel path persons (#6236)
* make sure funnel and path dates are always aligned and add api handling for funnel filter persons

* use post instead of GET for paths

* parse label

* change type

* use post in test

* fix types

* test both get and post
2021-10-05 14:10:27 -04:00
Marcus Hyett (PostHog)
ad4a1aca0a
Linking to GH issue in Cloud Announcement (#6251)
* Parse issue link from cloud announcement
* Add link to button in announcement banner
2021-10-05 15:34:07 +01:00
Paolo D'Amico
2eafad2ba7
Recordings watched & analyzed instrumentation (#6220) 2021-10-05 15:26:58 +03:00
Alex Gyujin Kim
c2a1f30a56
Make saved insights meta fields editable in-line (#6159)
* refactor insight metadata into separate reusable components

* create insightMetdataLogic

* added editable states to fields

* description add suffix to input

* fix functional bugs with input values

* remove consoles

* testing for insightMetadataLogic

* revert Insight

* revert Insight

* make editable in view mode

* test for update path
2021-10-05 12:56:34 +02:00
Paul D'Ambra
2af4622c09
Injects a logger during posthog init which sends an exception to Sentry when there is an XHR error (#6182)
* adds Sentry to the window object to facilitate logging for PostHog/posthog-js#290

* inject xhr error behaviour rather than injecting Sentry - depends on PostHog/posthog-js#296

* Add expected type to onXHRError function

* more safely add Sentry to posthog config

* update setting on xhr error config to correct exported config type

* enrich sentry error after testing
2021-10-04 14:52:41 -07:00
Paolo D'Amico
3419204d16
Fix dashboards loading error (#6229)
* Fix dashboards loading error

* fix typing

* adds tests to prove new change fixes issue

Co-authored-by: Paul D'Ambra <paul.dambra@gmail.com>
2021-10-04 14:47:14 -07:00
Paul D'Ambra
aa0ab19c5b
choose either count or aggregated value when sorting the insights table so that it doesn't matter if clickhouse or postgres returns the value (#6232) 2021-10-04 13:55:52 -07:00
Alex Gyujin Kim
7c68e1d154
fix input collapse and non default value (#6238) 2021-10-04 20:16:30 +00:00
Li Yi Yu
1043fb3d4c
Paths to funnels (#6215)
* paths to funnels

* account for pageview events and urls

* prettier

* sankey left is too cluttered/confusing
2021-10-04 15:15:39 -04:00
Eric Duong
4c13ef9a53
add extra handling if prop changes (#6207) 2021-10-04 13:38:08 -04:00
Eric Duong
e3806f55b8
change styling (#6209) 2021-10-04 09:34:14 -04:00
Li Yi Yu
66c3a23eae
fix http strip (#6204) 2021-10-01 11:11:03 -04:00
Neil Kakkar
c59a8c3a3c
Basic PersonModal for dropoff and completed paths (#6179)
* basic modal for dropoff and completed paths

* use right link for completed calculation

* fix calculations

* update Modal text

* cleanup

* rerun prettier
2021-10-01 15:39:45 +01:00
Michael Matloka
4ae063d0e6
Add project-nested version of all project-dependent endpoints (#6203)
* Add project-nested version of all project-dependent endpoints

* Fix hook `perform_create`

* Adjust `plugin-configs` to adhere to style of other endpoints
2021-10-01 13:38:33 +02:00
Li Yi Yu
3c033686db
Update paths dropdown options (#6200)
* update paths dropdown options and avoid merge issues

* minor adjustments

Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
2021-10-01 10:40:42 +00:00
Paolo D'Amico
19106cef2c
Signup UI Oct 2021 (#6136) 2021-10-01 07:26:19 +01:00
Sam Winslow
30a314b646
Fix tooltip on Formulas (#6199) 2021-10-01 04:52:23 +00:00
Alex Gyujin Kim
076bd43a88
More tests + Rename Modal state refactor (#6158)
* add a bunch of tests for logics and utils

* change comment

* addressed refactor comments

* hide renameFilter in logic, add util test
2021-09-30 17:17:41 -07:00
Eric Duong
5c453e206e
paths: Funnel to path dropoff connection (#6198)
* ui

* dropoff ui
2021-09-30 14:29:00 -04:00
Eric Duong
83eca7f227
paths & funnels: Funnel to path connection (#6160)
* restore progress

* working connection no UI visual

* working for events

* edit endpoint to start point

* working with close button

* funnel to path work (no dropoff yet)

* run prettier

* make suggested adjustmenst
2021-09-30 11:20:38 -04:00
Eric Duong
2bafa204f8
display value (#6161) 2021-09-30 10:14:47 -04:00
Michael Matloka
3a67367ac7
Project-based permissioning TopNavigation (#6027)
* Refactor `AvailableFeature` from strings to an enum everywhere

* Fix circular dependency and type

* Add "Per-project access" feature flag, premium feature, and organization switch

* Rename `OrganizationMembershipLevel` to `OrganizationAccessLevel`

* Create `ExplicitTeamMembership` model

* Show whether projects are restricted in the project switcher

* Update organizations API code

* Fix migrations

* Move organization tests that require EE to `ee`

* Revert `OrganizationMembershipLevel` rename

* Fix organization tests

* Update migration

* Fix schema and add Members to Project Settings

* Build out test memberships API with security tests

* Update `TeamMembers` and `teamMembersLogic`

* Move "Per-project access" description to tooltip

* Add moar tests

* Fix Project Members list logic

* Add additional membership checks

* Update migrations

* Fix typing

* Adjust explicit team memberships API similarly

* Fix typo

* Unify `ExplicitTeamMemberSerializer`

* Remove old changes to `membersLogic` usage

* Use `effective_membership_level` on `TeamBasicSerializer`

* Clean up organization update tests

* Explicitly disallow enabling per-project access for free

* Fix circular import

* Remove `id` from `UserSerializer`

* Fix typing

* Try to fix import

* Fix fatal typing

* Add more tests

* Update permissioning.ts

* Add clarifying comment to migration

* Fix import

* Revert `TopNavigation` changes

* Restore `TopNavigation` changes

This reverts commit 05fd9e4ed6.

* Try to add a story for `TopNavigation`

* minor clarifications

* Revert `TopNavigation` changes

* Restore `TopNavigation` changes

* Make new access control entirely project-based

* Update migrations

* Add `project_based_permissioning` to `TeamBasicSerializer`

* Update test_team.py

* Fix `isRestricted` in `ProjectRow`

* Disable project creation for non-admins

* Make project icon in top nav itself dynamic as well

* Fix story

* Delete 0169_project_based_permissioning.py

* Apply suggestions from code review

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>

* Update frontend/src/layout/navigation/TopNavigation.tsx

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>

* Address feedback

* Project-based permissioning full data access restrictions (#6068)

* Fix Access Control restriction tooltip

* Add `TeamMemberAccessPermission` and use it in viewsets

* Add `ErrorProjectUnavailable` scene

* Ignore mypy

* Update MainNavigation.tsx

* Update explicit_team_member.py

* Fix frontend detection of unavailable project

* Fix some tests and edge cases

* Fix basic permissions

* Add more tests

* Simplify `ExplicitTeamMemberViewSet` permissions

* Improve restrictions and add moar tests

* Update frontend

* Fix a couple of things

* Fix import

* Fix some edge cases

* Fix typing errors

* Use hedgehog instead of moth

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>

* Address feedback

* Add proper permissioning to dashboard views

* Update ee/api/test/test_dashboard.py

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>

* Run prettier

* Remove debug code

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-09-29 22:43:40 +00:00
Neil Kakkar
9cbece70fd
Some Paths fixes (#6175) 2021-09-29 12:44:30 -04:00
Neil Kakkar
26f7848b15
Add advanced options behind FF for Paths (#6173) 2021-09-29 16:57:19 +01:00
Guido Iaquinti
f4e47abb09
Bump prettier and eslint-config-prettier versions (#6167)
* Bump 'prettier' and 'eslint-config-prettier' version

* Run 'yarn prettier' with the new bumped version
2021-09-29 11:49:29 +01:00
Yakko Majuri
0171732226
Add feature flag based cloud announcements (#6155) 2021-09-29 10:04:38 +00:00
Alex Gyujin Kim
77d3d66754
Various funnel breakdown fixes (#6133)
* some copy

* minor styling improvements

* remove console

* fix shady typing
2021-09-28 13:12:30 -07:00
Rick Marron
a0775d7fae
Replace sessions with session recordings (#6050)
* Move Sessions tab -> Session Recording (behind feature flag)

Note: the /scenes/sessionRecordings folder is a copy of /scenes/sessions. Planning to remove sessions from the new SessionRecordings folder over the next coupld of commits

* Add very basic session recording page

* Add session recordings to persons page and session recs can play

* add endpoints for clickhouse

* fix ordering in existing tests

* add basic test to pg and clickhouse

* small bug fix

* type fix

* add test for data leaking between teams

* fix navigation bugs

* Fix name of logic

* Add basic logic tests

* fix tests

* fix laoding state bug

* revert changes to existing session queries

* move to proper queries for session recordings

* type fixes

* rename feature flag

* type fix

* Fix capitalization

* remove showSessions and clean up ifs

* Style changes and refactor SessionPlayerDrawer

* bug fix

* move to using query params

* remove type from persons logic

* Move sessionRecordingTableLogic key to distinctId

* rename setSessionRecordingId to openSessionPlayer

* improve tests

* Cleanup from review

* move team and limit to parameters
2021-09-28 11:18:38 -07:00
Li Yi Yu
6284b645b0
New paths tab querybuilder UI (#5825)
* new path tab querybuilder

* prettier

* clean up

* wip

* format querybuidler

* prepare path type filter component

* dropdown

* formatted popup

* change button for endpoints

* styling the type buttons

* logic for all left side querybuilder components

* exclusion UI and logic

* improve exclusion handling, ensure API calls are made

* API fixes for event types

* fix popup on close issue with exclusions

* hide overflow on buttons

* all ui working

* more formatting adjustments

* type fixes

* leave response ambiguous

* feature flagging and adjust styles

* Add Step limit option

* add tooltip to wildcards

* rewrite tooltip for exclusions

* make Events toggle responsive

* fix types

* responsive at xl instead of lg for no overlaps

* Proof of concept of connecting Funnel to Paths

* protecc wip

* Connect Funnels to Paths

* remove funnel button for now

* remove unused

Co-authored-by: eric <eeoneric@gmail.com>
Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
2021-09-28 12:53:03 -04:00
Paul D'Ambra
a089562d53
fixes display of events in the storybook (#6154)
PR #6079 broke the display of events in the storybook for the events scene
2021-09-28 17:36:37 +01:00
Alex Gyujin Kim
3f786b8c77
move bin_count into filters source of truth (#6126) 2021-09-28 08:00:02 -07:00
Li Yi Yu
858750deab
New paths UI sankey card (#6066)
* add box labels to paths

* path item cards wip

* add dropdown options

* add percentages

* fix dropdown appearance

* update percentages and remove text hover

* fix color and border

* path hover highlighting

* remove dropdown hover

* feature flag the paths ui graph

* change how ff works and add zindex on hover

Co-authored-by: eric <eeoneric@gmail.com>
2021-09-28 10:50:09 -04:00
Paul D'Ambra
eb6a0732cb
patch the in memory history passed into storybook
so that it doesn't matter if it is window.history or react-router history (closes #6138)
2021-09-28 14:15:54 +00:00