0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

2171 Commits

Author SHA1 Message Date
Karl-Aksel Puulmann
e3cda5f831
Handle groups in /my_flags endpoint and toolbar (#7361)
This fixes https://github.com/PostHog/posthog/issues/7360

The two-way data communication here is a bit iffy but /shrug
2021-11-26 12:12:41 +02:00
Marius Andra
6ac71e0a07
Fix layout saving bug (#7366) 2021-11-26 10:08:13 +00:00
Paolo D'Amico
0032ce6c28
Fix correlation matrix component build (#7375) 2021-11-25 17:31:07 -08:00
Paolo D'Amico
933243ee28
Funnel correlation matrix (#7220)
Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
2021-11-25 16:53:39 -08:00
Paolo D'Amico
f27bc8c12b
Product cue to funnels (#7301) 2021-11-25 11:32:46 -08:00
Paolo D'Amico
2638174909
Fix recording close layout (#7367) 2021-11-25 11:02:32 -08:00
Michael Matloka
2191af4de4
Unify Insights table with refreshed style (#7297)
* Unify Insights table style with refreshed style

* Fix sorting tooltip edge case

* Run prettier

* Refactor sorting for clarity

* Fix missing type import

* Run prettier

* Put Last modified after Created

* Fix typing and remove useless styles

* Address feedback

* Fix position indicator

* Fix sorting indicators

* Fix typing

* Fix `createdByColumn`

* Improve small things post-merge

* Fix typing

* Fix annotations table

* Unify Persons table with refreshed style (#7320)

* Use new table in Persons

* Finish move

* Highlight unfold less icon

* Don't use bug-prone tooltip

* Update groups as well

* Fix unused import

* Clean up top part

* Update Persons.cy-spec.js

* Further improve top part

* Update component test

* Remove unused imports

* Update persons.js

* Remove extra margin-bottom

* Add background to row expansion for differentiation

* Update components.tsx

* Use feedback

* Improve things post-merge

* Fix tests
2021-11-25 19:25:58 +01:00
Michael Matloka
b8ad1f7a4a
Better size feature flags table (#7323)
* Better size feature flags table

* Remove unused import

* Delete PropertyFiltersDisplay.tsx

* Update FeatureFlags.tsx

* Update FeatureFlags.tsx

* Update featureFlags.js

* Improve blue pills' use of space

* Align read-only and read-write property filters styling

* Throw in a few additional pixels

* Update featureFlags.js
2021-11-25 19:05:52 +01:00
Marius Andra
fbba78718c
Insight URL cleanup (#7201)
* insight route refactor, part 1

* add fromItem to get redirects

* fix some tests

* adjust many more paths

* fix test

* move new insight creation into insight logic

* fix a noisy test

* simplify one test

* open the url with the right filters

* null fix

* fix some more noisy tests

* move saved insights to `/insights`, fix logic tests

* fix cypress urls

* fix some tests

* fix even more insight urls

* wait a bit longer

* add old saved_insights redirect

* this might not be there yet

* rename newInsight -> insightNew

* rename Scene.Insights -> Scene.Insight

* also redirect old searches without fromItem

* fix link

* fix TS merge bugs

* fix import

* fix imports

* fix tests

* fix test

* Run prettier

* fix changes after merge

* switch to a simpler scene

* fix another test

* fix "save as" reset

* rerun tests

* Insight Short URLs (#7259)

* convert a bunch of things to user short_id instead of id

* fix more TS errors

* fix test

* fix jest tests

* various fixes

* add wise words

* type InsightShortId-s to make life easier

* reduce a bit of test noise

* use the InsightShortId in the URL

* fix type

* fix test

* fix insight url preloading

* pass dive dashboards as having insight short ids

* fix short url redirect

* mock scenelogic api

* better types and tests

* type fixes

* fix bug of linking to ourselves

* add back "id"

* get rid of some "getInsightId" calls

* two more

* few more

* refactor last usage of getInsightId

* move files around and improve errors

* make it simpler

* small fixes

* redirect to new url from old hashParam=42

* fix regression

* alert the user if we could not find an insight with the old ID format

* switch to a simpler scene

* fix another test

* Fix annotation creation

* Make short ID friendlier

* remove comments

* simplify insight links from dashboards and saved insights

* remove insight router

* fix TS

* Revert "remove insight router"

This reverts commit e52f474949.

Co-authored-by: Michael Matloka <dev@twixes.com>

Co-authored-by: Michael Matloka <dev@twixes.com>
2021-11-25 15:39:49 +01:00
Karl-Aksel Puulmann
2d919d6120
Groups/Feature flags: Allow choosing to aggregate by groups in UI (#7322)
* Update breadcrumb text

According to https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=5346%3A28614

* Extract code snippets to their own files

* Start refactoring/rewording feature flags pages

* Play with spacing

* Tags, add new and margins

* Delete match group button + margin on save button

* Update UTM_TAGS import

* Add duplicate option

* Update spacing

* update some actions naming

* Show group type(s) selection when groups enabled

* Remove the slider

* Add a new color

* Add grey badges to feature flags page

* Grey badges on FF page

* Toggle taxonomic groups based on dropdown selection

* Reset filters when group type changes

* Update wording

* Handle key change

* More consistent update when Match By changes
2021-11-25 16:29:04 +02:00
Karl-Aksel Puulmann
4797857ec1
Better placeholders for taxonomic filters (#7352)
Previously for groups they got listed as `Search `, now it will be
`Search company properties`
2021-11-25 12:50:31 +02:00
Michael Matloka
dd14bb3729
Move annotations to new table style (#7344)
* Move annotations to new table style

* Improve columns

* Fix minor issues

* Add a relevant empty state

* Improve a bit more
2021-11-25 11:16:06 +01:00
Michael Matloka
c8072bdaa1
Refactor App for better integration of new navigation (#7329)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-11-24 18:20:50 -08:00
Paolo D'Amico
a89cb52586
Funnels simple mode (#7252)
Co-authored-by: Alex Kim <alexgkim205@gmail.com>
2021-11-24 15:11:14 -08:00
Karl-Aksel Puulmann
09fee3531d
Update antd and dayjs to latest (#7319)
* Update antd to latest

Some new functionality was required for FF work

* Remove unneeded ts-ignores

* Solve datepicker dayjs mismatch

> frontend/src/lib/components/DateFilter/DateFilterRange.tsx(8,48): error TS2345: Argument of type 'import("/home/macobo/backups/2/projects/posthog/node_modules/rc-picker/lib/generate/index").GenerateConfig<import("/home/macobo/backups/2/projects/posthog/node_modules/rc-picker/node_modules/dayjs/index").Dayjs>' is not assignable to parameter of type 'import("/home/macobo/backups/2/projects/posthog/node_modules/rc-picker/lib/generate/index").GenerateConfig<import("/home/macobo/backups/2/projects/posthog/node_modules/dayjs/index").Dayjs>'.

* Update dayjs - forces single version of dayjs to exist
2021-11-24 20:02:38 +01:00
Michael Matloka
92f56de6aa
Unify dash placeholders (#7343) 2021-11-24 19:26:30 +01:00
Tim Glaser
68d133cb94
Load insights after save as (#7341) 2021-11-24 19:08:29 +01:00
Tim Glaser
e10ea61d63
Use normal filters person (#7325)
* Use normal filters for person

* Clean up is_identified

* fix jest stuff

* fix tests and nits

* types etc

* e2e test
2021-11-24 18:21:56 +01:00
Eric Duong
7406db57f6
[patch] Fix api jest test (#7303)
* return empty

* adds a mock response to the API tests

Co-authored-by: Paul D'Ambra <paul.dambra@gmail.com>
2021-11-24 16:25:46 +00:00
Michael Matloka
a70d7e0a48
Align "New insight" button size with all other "New x" buttons (#7335) 2021-11-24 15:56:07 +01:00
Michael Matloka
dd4950aca6
Prevent underflow under side button (#7334) 2021-11-24 14:23:28 +00:00
Michael Matloka
e619b6e1ca
Don't lock user out on the org/project creation page (#7305)
* Always allow closing the org/project creation modal

* Make org/project creation modals always closable

* Actually disable closing, but just make the mask optional

* run prettier

* Fix modal closing

* Run prettier

Co-authored-by: Sam Winslow <sammywinslow@gmail.com>
2021-11-24 07:49:20 -05:00
Marius Andra
38b1a08f7b
Try to fix flake in sceneLogic.test.ts (#7318)
* switch to a simpler scene

* fix another test
2021-11-24 11:55:37 +01:00
Paolo D'Amico
75a4f7ce7a
Recordings UX improvements (#7312)
Co-authored-by: Rick Marron <rcmarron@gmail.com>
2021-11-23 22:47:43 -08:00
Rick Marron
4a4f81e6cb
another try (#7313) 2021-11-24 07:45:54 +01:00
Yuvaraj J
504263342e
Adds password reveal functionality to password inputs (#7296)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-11-23 22:05:38 -08:00
Neil Kakkar
76fc8cb795
Fix handling of insight results for load more breakdown values (#7294)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-11-23 15:52:12 -08:00
Neil Kakkar
4485dadddf
Address issues with time to convert values and selection (#7291) 2021-11-23 15:41:17 -08:00
Neil Kakkar
16d6f2697c
Clarify placeholder for EventNames selection box (#7286) 2021-11-23 15:32:07 -08:00
Alex Gyujin Kim
77fe7f4fdb
Release renaming filters FF (#7311) 2021-11-23 15:30:08 -08:00
Paolo D'Amico
d96b6ab8ab fix style of button 2021-11-23 15:18:58 -08:00
Eric Duong
384d91bc9a
remove button unless on trends or stickiness (#7306) 2021-11-23 15:21:39 -05:00
Marius Andra
e5db2145a7
Activate turbo mode (#7254)
* activate turbo mode

* fix test

* remove comment

* reduce noise in tests

* fix missing var
2021-11-23 17:22:05 +01:00
Neil Kakkar
9931dfba2b
rm FF from tests, ensure correlations runs only on steps (#7295) 2021-11-23 15:23:31 +00:00
Paul D'Ambra
a710279955
Person URLs in Funnels (#7287)
* don't add leading slash to absolute url with no protocol

* don't add a base uri in only one funnel instantiation - will probably break tests

* remove console logs

* every API verb normalises URLs
2021-11-23 12:25:20 +00:00
Tim Glaser
950fc3bee8
Add save as button (#7174)
* Add save as button

* Dont use lemon button

* Commit file

* Fix eslint

* Fix issues

* fix

* fix typing

* fix tests

* Remove save and continue editing

* fix test

* Revert "Remove save and continue editing"

This reverts commit 5296f75b49.

* Revert "fix test"

This reverts commit 69b8cd9ae8.

* Copy changes

* Push instead of replace

* remove save new
2021-11-23 10:56:48 +01:00
Alex Gyujin Kim
55c25c27fb
Fix meta information stuck in loading state (#7272) 2021-11-23 07:36:33 +00:00
Alex Gyujin Kim
cdc7ecf8eb
Don't cache row heights in recordings event list (#7271) 2021-11-23 07:30:38 +00:00
Paolo D'Amico
77ff345234
Release new Paths (#7241) 2021-11-22 14:21:51 -08:00
Rick Marron
633d93e570
make recording date filter limited to 21 days (#7249) 2021-11-22 13:06:44 -08:00
Marius Andra
94a2fe11da
Split personsLogic for 1) persons scene, 2) cohorts drawer (#7160)
* split personsLogic for cohorts drawer

* fix "..." in the wrong place

* make key explicit

* patch breadcrumbsLogic

* fix person test

* lemon selectors

Co-authored-by: Michael Matloka <dev@twixes.com>
2021-11-22 18:56:38 +01:00
Paolo D'Amico
6f1e79b3f6
Remove correlation-analysis FF (#7240) 2021-11-22 09:43:02 -08:00
Michael Matloka
12329333dc
Dashboards polishes (#7266)
* Fix Cypress test

* Improve pin alignment
2021-11-22 16:03:46 +00:00
Michael Matloka
6efa3eb0f4
Smart Paths resize (#7235)
* Add `LemonTable` base to Feature flags page

* Fix basic styling

* Rework more of the table

* Fix column `align`

* Update eventsListLogic.ts

* Align FF table columns with design

* Add pagination

* Add table loader

* Add `LemonTable` to Storybook

* Add sorting

* Increase feature flags page size to 50

* Add scroll indication

* Fix minor issues

* Fix typing

* Update E2E test

* Sort one column at a time

* Add default sorting

* Improve current page handling

* Use search params for current page state

* Don't mute disabled feature flags

* Add overlay for loading state

* Add profile picture to Created by and improve comments

* Fix `createdByColumn`

* Resize paths canvas intelligently

* Fix overflow
2021-11-22 16:28:46 +01:00
Michael Matloka
9db1ecf6fb
Move Dashboards to LemonTable (#7236)
* Add `LemonTable` base to Feature flags page

* Fix basic styling

* Rework more of the table

* Fix column `align`

* Update eventsListLogic.ts

* Align FF table columns with design

* Add pagination

* Add table loader

* Add `LemonTable` to Storybook

* Add sorting

* Increase feature flags page size to 50

* Add scroll indication

* Fix minor issues

* Fix typing

* Update E2E test

* Sort one column at a time

* Add default sorting

* Improve current page handling

* Use search params for current page state

* Don't mute disabled feature flags

* Add overlay for loading state

* Add profile picture to Created by and improve comments

* Fix `createdByColumn`

* Refactor the More button for reusability

* Fix content sizing (pagination/loader filling full width when scrolled)

* Remove need for `@ts-expect-error`

* Move `Dashboards` to `LemonTable`

* Fix `defaultSorting` on dashboards

* Remove right align from `created_at` column

* Improve all the dashboards
2021-11-22 10:30:15 +00:00
Marius Andra
c546c39bf1
Remove BackTo (#7238)
* remove BackTo

* link only if object present

* e2e cache buster

* rebust the cache
2021-11-22 10:48:00 +01:00
Paolo D'Amico
e4d6f482e6
Remove collapse insight (#7253)
* remove control collapse

* remove unused controls collapse
2021-11-22 08:38:16 +01:00
Alex Gyujin Kim
0ba1630c0e
Clicky events in recording events list (#7217) 2021-11-22 04:10:09 +00:00
Paolo D'Amico
9a3c807c07
Release new session player for everyone (#7243) 2021-11-19 17:23:12 -08:00
Michael Matloka
b190b704ab
Remove old icons (#7230) 2021-11-19 11:34:26 -08:00