0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

10 Commits

Author SHA1 Message Date
Neil Kakkar
da305f8000
Error out on exclusion event being same as funnel step (#5668)
* error out on exclusion event being same as funnel step

* remove import
2021-08-23 09:20:34 +02:00
Michael Matloka
18bd79ee41
Insights refresh improved (#5530)
* Improve insight refreshing UX

* Clean up

* Make sure `ComputationTimeAndRefresh` is on the right in Trends too

* Fix typing and some inconsistencies

* Remove unused const

* Update test_clickhouse_insights.py

* Update decorators.py

* Refactor `ComputationTimeWithRefresh` into own file
2021-08-13 03:31:54 +02:00
Alex Gyujin Kim
d9973c7e5d
Add all steps option to time conversion funnel (#5142)
* add all steps option

* all steps working; add total and mean time to convert

* change display type checks to use enum

* kea types

* dangling console log

* Add average conversion time to time to convert results

* respond to feedabck

* responsive histogram sizes

* merged @Twixes backend changes; adjust data shape on frontend; add responsiveness to histogram

* add tooltip label

* adjust copy and tooltip

* minor tweaks

* respond to general feedback

* kea auto

* better empty state:

* error handling null time bins

* fix tests

Co-authored-by: Michael Matloka <dev@twixes.com>
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-19 12:00:59 -07:00
Neil Kakkar
8a1bd1c80e
Add Support for Excluding Events from Funnels (#5104)
* finish for ordered

* clean up, more tests, docs

* ensure correct filter values get saved to cache
2021-07-15 13:42:40 +01:00
Neil Kakkar
c554bb5e55
Enable person breakdowns querying for all ordering funnels (#5043)
* first pass mix and match everything

* cleanup

* small refactoring of get_query

* remove top level filter props

* save the file

* enable person breakdowns querying for regular + strict funnels

* move mixin testing to more appropriate location

* add unordered, testing quality of life improvements

* clean up

* add strict+unordered connectivity test for time to convert

* trim after extracting

* clean up, fix tests, trim everywhere
2021-07-12 18:53:26 +02:00
Michael Matloka
a599056234
Handle Action.DoesNotExist more (#5028)
* Handle `Action.DoesNotExist` more

* Reuse try-except logic for `Action.DoesNotExist`

* Fix circular import

* Add `test_funnel_invalid_action_handled`
2021-07-08 21:47:14 +00:00
Neil Kakkar
6394988e11
Mix and Match ordering and visualization of funnels (#5031) 2021-07-08 16:38:42 +00:00
Michael Matloka
d12b09f89e
Improve time to convert binning behavior, add autobinning, expose in API (#4995)
* Improve time to convert binning behavior, add autobinning

* Test and fix custom bin count

* Expose `ClickhouseFunnelTimeToConvert` in the API

* Revert a column name change

* Fix `bin_count` clamping

* Add an API test for viz type `time_to_convert`

* Update SQL comments

* Remove some unused imports

* Fix `FunnelTypeMixin.funnel_viz_type`

* Remove `DEBUG=1`
2021-07-08 17:51:13 +02:00
Neil Kakkar
22e02537c4
Setup Funnel Option Type, and proper Funnel[Persons] API routes (#4946)
* setup funnel option type, and proper API for persons and usual funnel routes

* update tests, fix bugs

* make insights compulsory

* nvm

* remove insights key

* fix person caching

* revert problems, fix typings

* address comments

* dont use defaults in mixins

* typing

* cleanup and fix TODOs

* update test

* adapt api to 4957

Co-authored-by: eric <eeoneric@gmail.com>
2021-07-01 14:43:44 -04:00
Marius Andra
80a699ef4e
Clickhouse Sessions + Frontend Sessions updates (#1754)
* convert sessions table logic to TS

* convert rest of sessions to TS

* sessions table logic refactor, store date in the url

* add back/forward buttons

* load sessions based on the URL, not after mount --> avoids duplicate query if opening an url with a filter

* prevent multiple queries

* throw error if failed instead of returning an empty list

* date from filters

* rename offset to nextOffset

* initial limit/offset block

* indent sql

* support limit + offset

* load LIMIT+1 sessions in postgres, pop last and show load more sign. (was: show sign if exactly LIMIT fetched)

* based offset is always 0

* default limit to 50

* events in clickhouse sessions

* add elements to query results

* add person properties to sessions query response

* show seconds with two digits

* fix pagination, timestamp calculation and ordering on pages 2 and beyond

* mypy

* fix test

* add default time to fix test, fix some any(*) filter issues

* remove reverse

* fix mypy error, indent SQL

* add pagination test for postgres

* Run insight API tests in Clickhouse

Co-authored-by: Eric <eeoneric@gmail.com>
2020-10-01 05:27:35 -04:00