* saved insights url sync WIP
* sync filters with the url
* improve trend and date filters
* convert utils test to typescript
* create simple object shallow diff function
* only persist the difference from the default filters in the url
* add tests and simplify operations
* improve tests
* better load checking
* Closes 6541 add step to empty funnel
* added comments back
* hide delete button when single step exists
* use values directly in first step
* Update frontend/src/scenes/insights/ActionFilter/ActionFilterRow/ActionFilterRow.tsx
Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
I haven't made any attept here to resolve anything here, just to
explicitly acknowledge that these are issues that eslint has highlighted
and we should ignore, for the sake of easily picking up new issues. If
these are truely problematic, then I am assuming they should have been
picked up as bugs with the system.
This doesn't stop someone from coming in and reviewing the code in this
pr retrospectively.
* adds a search box to the toolbar featureflag list
* test flakes because react is re-rendering between the get and the click. add an assertion to try and slow cypress down to avoid this
* move filtering toolbar feature flags to a Set and out of CSS
* support initKeaTestLogic() with no args
* fix query-selector-all-deep jest bug
* add simple test case for feature flags logic
* combine selectors
* with more understanding of Fuse
* add simple test for flag filtering
Co-authored-by: Marius Andra <marius.andra@gmail.com>
* refactor(taxonomic-filter): add api mock functions
* chore: remove makeApi from storybook preview.js
* feat(correlation): add multiselect for property names
Previously we had a simple text input box that was splitting the input
to get a list of property names. This doesn't give the greatest user
experience.
Now we have a simple select box that includes:
1. search filtering for options
2. multiselecting options
3. a select $all, although this is pretty poorly implemented at the
moment, for instance you can select $all, at the same time as
selecting a subset of properties.
* add a little commentary around PropertyNamesSelect
* add deps to useEffect
* ignore return type eslint issues
* just use console.log instead of actions
* remove unused import
* chore: add error condition
* chore(correlation): update styling of property select
This puts it more in line with
https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=4200%3A30715
* Add no search results message
* input focus border
* fix type
* use onBlur
* make checkbox checked colour change
* make query bold in no results message
* add clear
* Implement search highlighting
* fix typing
* add regex split comment
* if no property names selected, default to $all
* typo
* Add test for selection component
* Add test highlighting onChange lag and clicking outside
* click out side should depend on hide
* make sure onChange triggered on clear or select all
* wip implementation of grey pills for breakdown properties
* cohort pills need coercing differently to line up with the close icon
* which allows removal of some markup
* much better layout and matching behaviour
* resolve type errors in trends tab
* resolve type errors on funnels tab
* remove console.logs
* Closes #1688 Allow dashboards to be duplicated in the backend
* Allow dashboards to be duplicated in the frontend
* Remove unused method
* Filter existing dashboard along with team id
* Add title attributes to actions in dashboard listing page
* add doNotLoad to insights on dashboards that come without results
* load dashboard items without results in sequence
* fix test
* don't use the visibility map if it's empty (no keys)
* Update frontend/src/scenes/dashboard/dashboardLogic.tsx
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
* work with both dashboards and saved insight card views
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
* Optimize `dashboardsModel` a tiny bit
* Fix typing
* Make sorting more reliable
* Use more correct `dashboardModel` selectors, with better names
* Fix value name
* Fix and simplify `nextDashboard`
* Rename selectors
* reload insights on dashboards, clean up utils
* refresh items
* fix test
* test reloading with a fixed list
* show "0 out of N" where N is 1 or all
* add comment re: custom reload logic
* only pass object id
* add loadresults
* add tests that validate loadResults exists on insight logics for dashboard item refresh
* add name to payload
* remove refresh fix
