0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 04:12:23 +01:00
Commit Graph

4152 Commits

Author SHA1 Message Date
Neil Kakkar
a59610e432
Use FunnelStep properly in Correlation Queries (#6289)
* two wrongs don't make a right

* give beginning timestamps as well
2021-10-06 15:34:19 +00:00
Paul D'Ambra
ad17f9c7be
add a clearer loading state on the events table and start in loading state (#6256)
closes #6192
2021-10-06 15:34:01 +01:00
Yakko Majuri
27f9481716
Add properties_last_operation to person table (#6253)
* add properties_last_operation to person model

* update comment
2021-10-06 12:28:09 +00:00
Neil Kakkar
7bfeb9d1b9
Add basic model for Correlation analysis on Funnels behind FF (#6258)
* Add basic model for Correlation analysis on Funnels behind FF

* make frontend ready for testing

* address comments

* prettier
2021-10-06 13:14:32 +01:00
PostHog bot
5da276d849
Update posthog-js to 1.14.1 (#6274) 2021-10-06 11:43:43 +01:00
Harry Waye
9887856c33
Implementation of diagnose event names (#6235)
* chore(diagnose): add a stub endpoint for event diagnosis

This adds an insight endpoint that takes a `target_entity` and returns
a list of events ordered by significance of a person reaching
`target_entity`

Followup PRs will add actual calculations but this should act as a
conversation piece around the structure of request and response, as well
as a stub from which UI development can start.

* play around to get mypy typings right

* Sort out test reponse structurea

* refactor: address CR comments

* feat(diagnose): add diagnose stubs for implementation

* feat(funnel): add event correlation calculation implementation

This adds to the `/api/projects/<team_id>/funnel/correlation` endpoint
an implementation that calculates the odds_ratios for each event that a
user that has been part of a funnel, successful or otherwise.

* chore(correlation): get query working

* refactor(correlation): move functions to Query methods
2021-10-06 11:08:16 +01:00
Harry Waye
1e9d8985a6
dx: don't swallow ee import errors (#6248)
This is a little annoying as it hides the underlying error, and should
never be a valid state anyhow.
2021-10-06 07:37:43 +01:00
Li Yi Yu
27edb933e4
Revert "Always allow filtering on distinct id (#6264)" (#6271)
This reverts commit 03134f1d10.
2021-10-05 19:58:06 -04:00
Marius Andra
b015df3eeb
Fix feature flags not loading in toolbar (#6252)
* fallback if property is explicitly "null" inside json

* do a bit more verification

* keep form

* fallback None -> [] in a couple places

Co-authored-by: Sam Winslow <sammywinslow@gmail.com>
2021-10-05 21:19:43 +00:00
Tim Glaser
03134f1d10
Always allow filtering on distinct id (#6264)
* Always allow filtering on distinct id

* fix

* fix

* remove accidentally commited test

* include table name

* add table specific because distinct_id doesn't exist on person table

Co-authored-by: eric <eeoneric@gmail.com>
2021-10-05 15:42:08 -04:00
Eric Duong
4e63d630ab
paths: Paths funnel post api better tests (#6266)
* make sure test handles as expected

* separate tests

* added api test for paths with funnel
2021-10-05 15:02:38 -04:00
Eric Duong
b5ed0b7221
paths: funnel-path date alignment and funnel path persons (#6236)
* make sure funnel and path dates are always aligned and add api handling for funnel filter persons

* use post instead of GET for paths

* parse label

* change type

* use post in test

* fix types

* test both get and post
2021-10-05 14:10:27 -04:00
Marcus Hyett (PostHog)
ad4a1aca0a
Linking to GH issue in Cloud Announcement (#6251)
* Parse issue link from cloud announcement
* Add link to button in announcement banner
2021-10-05 15:34:07 +01:00
Paolo D'Amico
2eafad2ba7
Recordings watched & analyzed instrumentation (#6220) 2021-10-05 15:26:58 +03:00
Tim Glaser
e31d166d74
Don't count internal metrics for billing purposes (#6228) 2021-10-05 15:05:51 +03:00
Alex Gyujin Kim
c2a1f30a56
Make saved insights meta fields editable in-line (#6159)
* refactor insight metadata into separate reusable components

* create insightMetdataLogic

* added editable states to fields

* description add suffix to input

* fix functional bugs with input values

* remove consoles

* testing for insightMetadataLogic

* revert Insight

* revert Insight

* make editable in view mode

* test for update path
2021-10-05 12:56:34 +02:00
Karl-Aksel Puulmann
fda8313be6
Use fixed benchmarking version (#6247)
This way adding new benchmarks/setup code does not invalidate the
existing code.
2021-10-05 13:24:10 +03:00
Guido Iaquinti
45fbb68d25
docker-compose: remove references to 'posthog/plugin-server' (#6152) 2021-10-05 09:20:43 +00:00
Karl-Aksel Puulmann
0512972426
Add benchmarks for cohort filtering in trends (#6244)
* Add benchmarks for cohort filtering in trends

* Add a way to manually trigger benchmarking
2021-10-05 12:16:55 +03:00
PostHog bot
e1a8a29d68
Update posthog-js to 1.14.0 (#6246) 2021-10-05 10:13:13 +01:00
Karl-Aksel Puulmann
f0c9d68166
Make PRINT_SQL output readable (#6245)
Our queries now contain a lot of comment noise that's not relevant when
developing. This change makes PRINT_SQL env variable usable again by
stripping these comments.
2021-10-05 11:27:17 +03:00
Paul D'Ambra
2af4622c09
Injects a logger during posthog init which sends an exception to Sentry when there is an XHR error (#6182)
* adds Sentry to the window object to facilitate logging for PostHog/posthog-js#290

* inject xhr error behaviour rather than injecting Sentry - depends on PostHog/posthog-js#296

* Add expected type to onXHRError function

* more safely add Sentry to posthog config

* update setting on xhr error config to correct exported config type

* enrich sentry error after testing
2021-10-04 14:52:41 -07:00
Paolo D'Amico
3419204d16
Fix dashboards loading error (#6229)
* Fix dashboards loading error

* fix typing

* adds tests to prove new change fixes issue

Co-authored-by: Paul D'Ambra <paul.dambra@gmail.com>
2021-10-04 14:47:14 -07:00
Paul D'Ambra
aa0ab19c5b
choose either count or aggregated value when sorting the insights table so that it doesn't matter if clickhouse or postgres returns the value (#6232) 2021-10-04 13:55:52 -07:00
Alex Gyujin Kim
7c68e1d154
fix input collapse and non default value (#6238) 2021-10-04 20:16:30 +00:00
Li Yi Yu
1043fb3d4c
Paths to funnels (#6215)
* paths to funnels

* account for pageview events and urls

* prettier

* sankey left is too cluttered/confusing
2021-10-04 15:15:39 -04:00
Eric Duong
4c13ef9a53
add extra handling if prop changes (#6207) 2021-10-04 13:38:08 -04:00
Eric Duong
1a9eafe0ed
paths: remove funnel limit when querying path funnels (#6210)
* remove funnel limit when querying path funnels

* add limit test and fix args

* fix args

* typos
2021-10-04 09:56:20 -04:00
Eric Duong
e3806f55b8
change styling (#6209) 2021-10-04 09:34:14 -04:00
PostHog bot
ff58d6277a
Update posthog-js to 1.13.17 (#6226) 2021-10-04 12:20:45 +01:00
Harry Waye
c450be93f5
ci(tests): show untested code in PR with codecov (#6082) 2021-10-04 10:37:15 +01:00
PostHog bot
5223ea0aa0
Update posthog-js to 1.13.16 (#6222)
Co-authored-by: posthog-bot <posthog-bot@users.noreply.github.com>
2021-10-04 10:12:40 +01:00
Harry Waye
eb08897cf4
dev(clickhouse): strip out comments before executing sql (#6181)
* dev(clickhouse): strip out comments before executing sql

This is so we can easily copy/paste from e.g. Metabase by querying the
system.query_log. In metabase is doesn't display new lines (although you
can download to file for this), but it's not very practical.

* test(clickhouse): use `capture_select_queries` in comment strip test

* test(clickhouse): only sub. params if non-insert query

This parallels `clickhouse_driver` behaviour.

* chore(clickhouse): move sql preparation to dedicated function

* refactor: rearrange func and type definitions
2021-10-04 08:13:31 +01:00
posthog-contributions-bot[bot]
25163d0bdb
🤖: Add dakshshah96 as a contributor 🎉 (#6212) 2021-10-02 18:49:09 +01:00
Tim Glaser
3402ba4ee7
Fix status reports (#6194)
* Fix status reports

* remove active in period

* types

* mypy
2021-10-01 18:56:29 +02:00
Li Yi Yu
66c3a23eae
fix http strip (#6204) 2021-10-01 11:11:03 -04:00
Neil Kakkar
c59a8c3a3c
Basic PersonModal for dropoff and completed paths (#6179)
* basic modal for dropoff and completed paths

* use right link for completed calculation

* fix calculations

* update Modal text

* cleanup

* rerun prettier
2021-10-01 15:39:45 +01:00
Karl-Aksel Puulmann
437b2982cd
Benchmarking suite for ClickHouse queries (#6187)
* Add asv code

* Get a benchmark running

* better output folder

* Move benchmark file

* Cleanup of config

* Run a query and benchmark

* Skip benchmarks for isort

* Set up materialized columns before test

* Better skipping logic

* Add first proper benchmark, add some documentation

* Person property filtering

* Add new workflow

* Show stderr in test run

* Continue debugging actions

* Try to save benchmark results to separate repo

* Output to main directory

* Scheduling

* Remove if temporarily

* Int for ms

* Comment on the PR

* Collapsible section

* Update README

* Clarification

* Remove h3

* Remove pyproject.toml, .gitignore changes that are unneeded
2021-10-01 15:20:58 +03:00
Michael Matloka
4ae063d0e6
Add project-nested version of all project-dependent endpoints (#6203)
* Add project-nested version of all project-dependent endpoints

* Fix hook `perform_create`

* Adjust `plugin-configs` to adhere to style of other endpoints
2021-10-01 13:38:33 +02:00
Li Yi Yu
3c033686db
Update paths dropdown options (#6200)
* update paths dropdown options and avoid merge issues

* minor adjustments

Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
2021-10-01 10:40:42 +00:00
James Greenhill
d5fb987d53
Create Kafka consumer and write tests for consumer and producer (#6170)
* Test Kafka

* black format python

* fix imports

* add kafka and zk deps for testing

* Include ZK and Kafka for all tests

* fix signature for kafka helper

* Connect to localhost for kafka

* update kafka host for all test runs

* Wrong env var for kafka

* consolidate env vars for github actions

* set the advertised hostname from the broker to localhost

* add env var to docker-compose for kafka broker advert host

* resort to what we do locally with /etc/hosts

* Remove configs for kafka that won't be used
2021-10-01 09:43:50 +01:00
Paolo D'Amico
19106cef2c
Signup UI Oct 2021 (#6136) 2021-10-01 07:26:19 +01:00
Sam Winslow
30a314b646
Fix tooltip on Formulas (#6199) 2021-10-01 04:52:23 +00:00
Alex Gyujin Kim
076bd43a88
More tests + Rename Modal state refactor (#6158)
* add a bunch of tests for logics and utils

* change comment

* addressed refactor comments

* hide renameFilter in logic, add util test
2021-09-30 17:17:41 -07:00
Guido Iaquinti
7e76387291
Speed improvements for the arm64 ClickHouse build (#6191) 2021-09-30 19:52:59 +00:00
Eric Duong
5c453e206e
paths: Funnel to path dropoff connection (#6198)
* ui

* dropoff ui
2021-09-30 14:29:00 -04:00
Eric Duong
8a6508bb02
fix typo (#6197) 2021-09-30 17:27:11 +00:00
Eric Duong
83eca7f227
paths & funnels: Funnel to path connection (#6160)
* restore progress

* working connection no UI visual

* working for events

* edit endpoint to start point

* working with close button

* funnel to path work (no dropoff yet)

* run prettier

* make suggested adjustmenst
2021-09-30 11:20:38 -04:00
Eric Duong
2bafa204f8
display value (#6161) 2021-09-30 10:14:47 -04:00
Michael Matloka
a704d8cc61
Fix test_analytics_metadata flakiness (#6188) 2021-09-30 11:53:12 +00:00