0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

192 Commits

Author SHA1 Message Date
Marius Andra
fbba78718c
Insight URL cleanup (#7201)
* insight route refactor, part 1

* add fromItem to get redirects

* fix some tests

* adjust many more paths

* fix test

* move new insight creation into insight logic

* fix a noisy test

* simplify one test

* open the url with the right filters

* null fix

* fix some more noisy tests

* move saved insights to `/insights`, fix logic tests

* fix cypress urls

* fix some tests

* fix even more insight urls

* wait a bit longer

* add old saved_insights redirect

* this might not be there yet

* rename newInsight -> insightNew

* rename Scene.Insights -> Scene.Insight

* also redirect old searches without fromItem

* fix link

* fix TS merge bugs

* fix import

* fix imports

* fix tests

* fix test

* Run prettier

* fix changes after merge

* switch to a simpler scene

* fix another test

* fix "save as" reset

* rerun tests

* Insight Short URLs (#7259)

* convert a bunch of things to user short_id instead of id

* fix more TS errors

* fix test

* fix jest tests

* various fixes

* add wise words

* type InsightShortId-s to make life easier

* reduce a bit of test noise

* use the InsightShortId in the URL

* fix type

* fix test

* fix insight url preloading

* pass dive dashboards as having insight short ids

* fix short url redirect

* mock scenelogic api

* better types and tests

* type fixes

* fix bug of linking to ourselves

* add back "id"

* get rid of some "getInsightId" calls

* two more

* few more

* refactor last usage of getInsightId

* move files around and improve errors

* make it simpler

* small fixes

* redirect to new url from old hashParam=42

* fix regression

* alert the user if we could not find an insight with the old ID format

* switch to a simpler scene

* fix another test

* Fix annotation creation

* Make short ID friendlier

* remove comments

* simplify insight links from dashboards and saved insights

* remove insight router

* fix TS

* Revert "remove insight router"

This reverts commit e52f474949.

Co-authored-by: Michael Matloka <dev@twixes.com>

Co-authored-by: Michael Matloka <dev@twixes.com>
2021-11-25 15:39:49 +01:00
Karl-Aksel Puulmann
2d919d6120
Groups/Feature flags: Allow choosing to aggregate by groups in UI (#7322)
* Update breadcrumb text

According to https://www.figma.com/file/gQBj9YnNgD8YW4nBwCVLZf/PostHog-App?node-id=5346%3A28614

* Extract code snippets to their own files

* Start refactoring/rewording feature flags pages

* Play with spacing

* Tags, add new and margins

* Delete match group button + margin on save button

* Update UTM_TAGS import

* Add duplicate option

* Update spacing

* update some actions naming

* Show group type(s) selection when groups enabled

* Remove the slider

* Add a new color

* Add grey badges to feature flags page

* Grey badges on FF page

* Toggle taxonomic groups based on dropdown selection

* Reset filters when group type changes

* Update wording

* Handle key change

* More consistent update when Match By changes
2021-11-25 16:29:04 +02:00
Tim Glaser
e10ea61d63
Use normal filters person (#7325)
* Use normal filters for person

* Clean up is_identified

* fix jest stuff

* fix tests and nits

* types etc

* e2e test
2021-11-24 18:21:56 +01:00
Marius Andra
e5db2145a7
Activate turbo mode (#7254)
* activate turbo mode

* fix test

* remove comment

* reduce noise in tests

* fix missing var
2021-11-23 17:22:05 +01:00
Tim Glaser
950fc3bee8
Add save as button (#7174)
* Add save as button

* Dont use lemon button

* Commit file

* Fix eslint

* Fix issues

* fix

* fix typing

* fix tests

* Remove save and continue editing

* fix test

* Revert "Remove save and continue editing"

This reverts commit 5296f75b49.

* Revert "fix test"

This reverts commit 69b8cd9ae8.

* Copy changes

* Push instead of replace

* remove save new
2021-11-23 10:56:48 +01:00
Michael Matloka
12329333dc
Dashboards polishes (#7266)
* Fix Cypress test

* Improve pin alignment
2021-11-22 16:03:46 +00:00
Michael Matloka
2f1a6af0ef
Fresh table pilot (#7103)
* Add `LemonTable` base to Feature flags page

* Fix basic styling

* Rework more of the table

* Fix column `align`

* Update eventsListLogic.ts

* Align FF table columns with design

* Add pagination

* Add table loader

* Add `LemonTable` to Storybook

* Add sorting

* Increase feature flags page size to 50

* Add scroll indication

* Fix minor issues

* Fix typing

* Update E2E test

* Sort one column at a time

* Add default sorting

* Improve current page handling

* Use search params for current page state

* Don't mute disabled feature flags

* Add overlay for loading state

* Add profile picture to Created by and improve comments

* Fix `createdByColumn`

* Refactor the More button for reusability

* Fix content sizing (pagination/loader filling full width when scrolled)

* Remove need for `@ts-expect-error`
2021-11-19 17:50:43 +01:00
Marius Andra
9b14556ae4 this seems to take time 2021-11-18 23:36:01 +01:00
Marius Andra
a8ca2ac634
add change (#7181) 2021-11-17 11:24:16 +01:00
Marius Andra
0338759da8
Fix feature flag edit page load (#7076)
* fix feature flag edit on page load

* Update E2E Feature flags test

Co-authored-by: Michael Matloka <dev@twixes.com>
2021-11-16 09:12:21 +01:00
Michael Matloka
b32a77fb56
Release lemonade for self-hosted users (#7059)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-11-11 12:20:01 -08:00
Paul D'Ambra
33f2399981
Do not alter paths data when loading through d3js (#7026)
* d3-sankey alters the object passed into it. we must copy the object we pass to it

* save a path in a test

* don't rely on being able to query the toast when testing if paths saved
2021-11-10 16:58:39 +00:00
Michael Matloka
ac2c51e451
Rework "On dashboard" button (#6959)
* Rework "On dashboard" button

* Adjust things

* Simplify things

* Update modal text and E2E tests
2021-11-10 13:32:01 +01:00
Marius Andra
bc9ebaf712
Release Saved Insights (#6995) 2021-11-09 15:29:05 -08:00
Paul D'Ambra
0cdfb2531a
Only load events table from the URL on allow list of URLs (#6949)
* only load events table from the URL on allow list of URLs

* add return type to function

* pass scene URL into events table

* use urlpattern to check if scene is loaded in events table

* don't need to check if still on the same page as when loaded because urltoaction is now specific

* which means we don't need url pattern matching at all

* add scene url to events scene export's logic props

* use a different action name for each run or retries can never complete as the action cannot be saved

* do not poll results if moved away from sceneUrl

* remove tabs from person/action event tables

* so cypress can run locally

* break the dependency of running one test first so the other can pass

* move check into logic and add an e2e test

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-11-09 15:35:41 +00:00
Marius Andra
a8ecf33be8
Preload chunks when loading scenes (#6942)
* preload chunks when loading esbuild scenes

* fix TS error

* fix license title

* fix scene identifiers in menu

* lowercase data-attr

* make the events menu have the old data-attr

* change var name to clarify its usage
2021-11-09 10:37:01 +00:00
Marius Andra
33d37cd79a
fix cypress funnel tests, volkswagen style (#6906) 2021-11-05 10:55:18 +01:00
Michael Matloka
a18beb8e63
Fix test depending on OrganizationBasicSerializer (#6795)
* Update test_user.py

* Account for "administrator" being shortened to "admin"
2021-11-02 23:58:35 +01:00
Michael Matloka
137c699150
Add site popover on profile picture to fresh top bar (#6701)
* Keep top bar always visible

* Add `LemonPopover`

* Add empty account control sections

* Rename `AccountControl` to `SitePopover`

* Add basic Sign out button

* Add `LemonButton` and use it for sign out

* Scale down popover scaling

* Remove `LemonPopover` in favor of `Popup`

* Improve icons story

* Polish account info

* Add organizations to site popover

* Add `CreateOrganizationModal` to  `TopBar`

* Polish things

* Add PostHog status items

* Update FunnelTab.tsx

* Rename `InitialBlob` to `Lettermark`

* Update utils.test.ts

* Address feedback

* Handle long emails

* Update Cypress test for sentence case title
2021-10-29 16:36:08 +02:00
Paolo D'Amico
f3222d2643
UX revamp for split/merge persons (#6544) 2021-10-26 14:27:00 -07:00
Paul D'Ambra
a957f0abb0
adds a search box to the toolbar featureflag list (#6527)
* adds a search box to the toolbar featureflag list

* test flakes because react is re-rendering between the get and the click. add an assertion to try and slow cypress down to avoid this

* move filtering toolbar feature flags to a Set and out of CSS

* support initKeaTestLogic() with no args

* fix query-selector-all-deep jest bug

* add simple test case for feature flags logic

* combine selectors

* with more understanding of Fuse

* add simple test for flag filtering

Co-authored-by: Marius Andra <marius.andra@gmail.com>
2021-10-20 22:02:02 +00:00
Harry Waye
af876da5f0
ci(e2e): use fixed width email address to avoid flaky (#6545) 2021-10-19 07:15:11 -07:00
Paolo D'Amico
39ff3abab2
Persisted flags for 1.29.0 (#6401) 2021-10-18 02:32:20 +03:00
Paolo D'Amico
4b7ea0f5cc
Fix password reset (#6466)
* fix render issue on email

* fix redirection after password change

* fix test
2021-10-15 15:58:54 +02:00
Marius Andra
85aa9f3b74
Fix Cypress component tests (#6461)
* fix component tests

* disable sessions test

* add console errors into cypress output
2021-10-15 12:47:06 +02:00
Paolo D'Amico
20b0f9704a
Forgot password UI (#6177) 2021-10-15 10:40:31 +03:00
Michael Matloka
f5b2f36f29
Fix duplicated action name error message (#6454)
* Fix import of `urls` in `ActionEdit`

* Fix duplicated action name error message
2021-10-15 08:18:15 +02:00
Paolo D'Amico
9041e919b2
Remove Home page experiment (#6410)
* remove FF

* remove home page
2021-10-14 08:25:50 -07:00
Marius Andra
00633412cc
Insight logic refactor version 1 - keyed insightLogic (#6310)
* kea test "toNotHaveDispatchedActions"

* fix dashboard logic test

* add props and key to insight logic (has no effect)

* inform about is_sample's uniqueness

* use common InsightLogicProps

* persist state via BindLogic and shared insightProps

* persist hashParams

* remove cached Urls

* upgrade new to saved logic

* upgrade typegen

* patch metadata logic

* always show title if saved insights active

* fix negative bug

* fix interval filter

* go to view mode after saving

* full reload when going from dashboard to insight

* use clean filter

* createInsight is no longer used

* fix tests

* fix setAllFilters

* clean retention table duplicate code, fix test

* scene has its own key

* unify insightLogicProps key logic

* consolidate logic fetching

* fix test

* fix reloads

* clears the scene funnel

* move setInsight to reducer

* stronger clicks on menu items

* remove wait

* clarify testcases
2021-10-08 12:13:23 +00:00
Paolo D'Amico
19106cef2c
Signup UI Oct 2021 (#6136) 2021-10-01 07:26:19 +01:00
Paolo D'Amico
6b8d0de031
Login UI revamp (#6076) 2021-09-27 20:04:51 +03:00
Michael Matloka
7fa218bcf8
Add cohort description backend (#6089)
* Add cohort description backend

* Increase `Cohort.description` limit

* Require `DASHBOARD_COLLABORATION` for cohort description box to be shown
2021-09-27 11:57:13 +00:00
Tim Glaser
0779881027
Split persons (#5898)
* Split people with multiple distinct ids

* when merging get correct distinct_ids immediately

* fix type errors

* fix e2e tests

* Add feature flag
2021-09-16 00:41:17 +02:00
Manish Rastogi
693bb7ee4f
Added functionality to copy person details (#5884) 2021-09-14 18:02:00 +02:00
Paolo D'Amico
a0ddd7cccb
Remove deprecated /api/user (#5897) 2021-09-13 10:28:12 +02:00
Paolo D'Amico
ab9113947b
Release engagement cohorts (#5851)
Co-authored-by: Tim Glaser <tim@glsr.nl>
2021-09-09 17:13:35 +02:00
Manish Rastogi
7b30a4aa84
Closes #4987 sets page title to dashboard name whenever a dashboard is visited (#5822)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-09-07 11:44:20 +02:00
Michael Matloka
7f605c8bd9
"Personalize" "people" and "users" (#5739)
* Refactor `PersonModal` and clean related components up a little

* Improve footer button conditions

* Remove unused vars

* "Personalize" "people" and "users"
2021-08-26 12:33:36 +00:00
Alex Gyujin Kim
b4c30cbe78
Fix edit actions losing focus on each keystroke (#5628)
* separate out components in action step for proper rerender

* fix required props

* add focus check to e2e
2021-08-18 18:13:43 +00:00
Alex Gyujin Kim
344aab3ee7
Patch for dashboardLogic crashing home page (#5522) 2021-08-16 08:59:50 -05:00
Yakko Majuri
e5a9c3b04e
merge people test (#5567)
* do all merge_people ops in plugin server

* add integration test

* flip call order

* allow calls in any order

* update test approach
2021-08-16 10:53:52 +03:00
Li Yi Yu
64afebd643
Insight tags and description (#5480)
* pull description into its own reuseable component

* working object tags for insights

* refactor editing toast and add insight description editing

* insight name editing and split up huge insights component

* fix toast bug

* typing

* test fixes and clean up

* test something

* add cypress tests

* bug fixes

* test with user logic dashboard collab instead

* history is now a link button

* hide under saved insights feature flag

* skip tests for now

* prettier

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-08-12 17:55:11 -04:00
Paolo D'Amico
617ded5b80
Don't pin dashboards by default (#5419)
* Don't pin dashboards by default

* E2E test
2021-08-02 20:27:39 +00:00
Paolo D'Amico
ce2c9a2f90
Random insights improvements (#5406) 2021-08-02 09:44:44 -07:00
Marius Andra
f40ac4b75c
All Users cohort in breakdown filter (#5293)
* Initial stashed work

* fix all users cohort

* fix test

* fix typesscript values

* remove .only

* simplify some nulls
2021-07-23 08:54:59 +00:00
Marius Andra
771b9a74cf
Enable filter and funnel feature flags (#5282) 2021-07-22 13:40:49 -05:00
Eric Duong
9bb66c53bd
Engagement cohorts UI (#4574)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-20 20:49:35 -05:00
Tim Glaser
9282c9a5f5
Reload actions once one is created (#5219) 2021-07-20 14:11:57 +02:00
Alex Gyujin Kim
a5215f76db
make non time conversion graph types visible in self hosted (#5140) 2021-07-15 00:14:43 +00:00
Sam Winslow
e7c669692d
Fixes / improvements to funnel step UI (#5018)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-07-08 10:43:42 -05:00