0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-27 16:26:50 +01:00
Commit Graph

5 Commits

Author SHA1 Message Date
Harry Waye
d7998cef30
Revert "chore(dev): use network mode host for docker-compose services (#10917)" (#10926)
This reverts commit 225a41db72.
2022-07-22 10:25:59 +01:00
Harry Waye
225a41db72
chore(dev): use network mode host for docker-compose services (#10917)
* chore(dev): use network mode host for docker-compose services

This removes the need to add kafka to /etc/hosts.

As far as I can tell this should be fine for peoples local dev except
they will be required to reset and re-migrate ClickHouse tables as they
will be trying to pull from `kafka` instead of `localhost`.

* remove ports from redis

* Update a few more references
2022-07-21 15:29:31 +01:00
Harry Waye
fbdefdab1d
feat(trends): add moving average smoothing_intervals param (#6435)
* feat(trends): add moving average `smoothing_intervals` param

This will average over the preceding `smoothing_intervals` intervals.
The driver for this is to remove either weekly or monthly trends.

Limitations at the moment are that it only works for total volume
queries, as it relies on the results from clickhouse being from a single
timeline series.

* WIP UI for selecting smoothing

* WIP: Fix typing and appearce logic

* Made smoothing extensible beyond day

* Test now considers a non-trivial case

* chore(smoothing): use url params for state storage of smoothing value

This should allow for url navigation to work, although I haven't quite
figured out how we then use this to make the insights/trends POST
request

* Added further tests for smoothing intervals

* fix test_to_dict

* fix trend tests

* Added test to validate preceeding limit

* Fixed test for 2 interval

* clear django redis cache before each test

* add explicit ordering to dashboard items in refresh test

Otherwise the test is not deterministic.

* Revert "clear django redis cache before each test"

This is a good thing to do, but I don't want to open up a discussion on
this PR. It was not fix for the immediate intermittent
test_refresh_cache test

This reverts commit aa52f332f3.

* format

* clickhouse trends: SET allow_experimental_window_functions = 1

* fix setting of allow_experimental_window_functions

* add cache clears for requests

* Delete SmoothingFilterLogic.ts

Removed smoothing filter logic file

* Use `SMOOTHING_INTERVALS` instead of string literal

This should ensure that if we update the url param key somewhere, we don't have to remember to change it here as well.

Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>

* move test_trends to ee

* actually delete test_trends.py

* Transitioned smoothing logic to use Logic

* WIP: Moving away from url based logic

* WIP: Refactored logic on listeners

* fix storybook

* refactor

* set redis url

* remove keastory

* Move interval filter to setFilters insight logic

* update trend snapshots

* run prettier

* Add stickiness test deps that were in test_trends

* Fix storybook

* fix stickiness tests

* update snapshot

* fix cohort test

* only display smoothing on linear

* fix tests

* Add some tests

* added box to make dropdown consistent

* Floor

* fix tests

* fix tests

* fix test

* Add feature flag

Co-authored-by: Marcus Hyett <marcus@posthog.com>
Co-authored-by: Marcus Hyett (PostHog) <85295485+marcushyett-ph@users.noreply.github.com>
Co-authored-by: Neil Kakkar <neilkakkar@gmail.com>
Co-authored-by: Tim Glaser <tim@glsr.nl>
2022-03-23 15:54:38 +00:00
Harry Waye
7108f1911a
dev(codespaces): make sure REDIS_URL set in codespaces (#7553)
This needs to be set for django to get to the redis celery broker
properly.
2021-12-07 12:17:59 +00:00
Harry Waye
71fa440394
Reimplement codespaces support (#7234)
* dev(codespaces): add "lean in" docker configuration for codespaces

This changes creates a dedicated `docker-compose.yml` and `Dockerfile`
for codespaces and doesn't attempt to have compatability with the
existing docker config files. This is intentional and is designed to be
a close to what codespaces would consider the ideal, so as to understand
what great would look like.

At the moment it doesn't do, but could:

 1. install python and node packages in the image
 2. push this image up to dockerhub
 3. specify this image to be used for caching. There is a "cacheFrom"
    option in the [.devcontainer
    reference](https://code.visualstudio.com/docs/remote/devcontainerjson-reference)
    although I haven't checked how this works with using
    `docker-compose.yml`. Perhaps we just need to add the `image:`
    property to the `app` service :fingerscrossed:
 4. specify default extensions and settings to be used.

* Use python 3.9, not the latest python 3 codespaces supports

* Add some basic python default settings and extensions

* add github codespaces image build workflow

* chore: update docker-compose cache from :cache tag

* chore: use docker cache-to inline

* add codespaces platform comment

* temp run on branch

* chore: fix flatforms format

* chore: update qemu comment

* chore: codespaces build use master image

* chore: target x86_64

* chore: just use image for codespaces, don't try to build

* add in python, node requirements

* install node

* install node

* uncomment node deps install

* use app network stack for all services

* move .env to .dev.env and us in docker-compose

* set WORKDIR to workspace

* pin apt packages

* pin versions, remove apt-key

* add yarn cache clean

* Fix hadolint warnings

* make codespace build on master, or a PR with codespaces-build label

* add missing &&

* dont bother with clickhouse install, its huge

* dont be cute with the networks, just expose explicitly

* fix network

* create container zsh

* correct .env path

* point app to the clickhouse container

* Also install saml deps

* ignore .env again

* libxml already installed

* correct conditional workflow comment
2021-11-23 08:34:51 +00:00