0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-24 18:07:17 +01:00
Commit Graph

37 Commits

Author SHA1 Message Date
Michael Matloka
59d4398646
ci(vrt): Stop the snapshot madness (#17163)
* Remove redundant Playwright specs

* Increase tolerance in Playwright

* Wait for profile pictures to resolve

* Ensure scene is loaded before proceeding

* Always wait for loaders to disappear

* Disable Gravatars in snapshots

* Don't wait for loaders in more stories with loaders

* Improve resiliency of batch export story

* Fix one more loading story

* Unskip Playwright tests

* Improve inconsistencies

* Upgrade Playwright from 1.29.2 to 1.37.1

* Wait for images to load

* Unify code editors

* Properly wait for images to load

* Go back to Playwright 1.29.2

* Wait for loader selector in LemonTable stories

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-08-29 09:28:03 +02:00
Robbie
4e885e618d
style: Make eslint stricter, fix issues that came up (#17092)
* Make eslint stricter, fix issues that came up

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update query snapshots

* Update UI snapshots for `chromium` (1)

* Update query snapshots

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (1)

* Try to fix Playwright flakiness and speed up visual snapshots

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Matloka <michal@matloka.com>
2023-08-21 13:28:29 +01:00
Michael Matloka
64c3b0c8d7
fix(insights): Clean up double filter buttons and and/or select (#16907)
* fix(insights): Clean up double filter buttons

* Replace all Ant `AndOrFilterSelect` with Lemon

* Tighten `AndOrFilterSelect`

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `webkit` (2)

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-08-04 15:49:45 +02:00
Paul D'Ambra
39eb7b2cb2
chore: console log in linter (#16794)
* chore: console log in linter

* silly toolbar

* Fix

* fix
2023-07-27 09:51:29 +00:00
Paul D'Ambra
0569f2f621
fix: disallow debugger statements when linting (#15487) 2023-05-11 09:01:27 +00:00
Michael Matloka
04944e2f4b
feat(lemon-ui): Add LemonCollapse, removing Ant Collapse (#14673)
* Add `LemonCollapse`

* Make single-open-panel version the default

* Improve `activeKeys` and `panels` ergonomics

* Replace `Collapse` with `LemonCollapse` all over

* Tune sizing

* Update scenes-app-experiments--complete-funnel-experiment.png

* Update UI snapshots for `chromium` (1)

* Add solid background to `LemonCollapse`

* Update UI snapshots for `chromium` (1)

* Update UI snapshots for `chromium` (2)

* Update UI snapshots for `chromium` (2)

* Add `LemonCollapse` to `@posthog/lemon-ui`

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2023-03-10 14:55:26 +00:00
Michael Matloka
2f36cfff7c
refactor(frontend): Replace Tabs with LemonTabs (1/2) (#14191) 2023-02-13 17:13:07 +01:00
Michael Matloka
035020a71e
refactor: Replace Badge with LemonBadge (#13763) 2023-01-18 15:50:51 +01:00
Michael Matloka
8290cfd104
refactor(navigation): Remove Ant Layout and clean up .main-app-content (#13657)
* Remove Ant `Layout` completely

* Update `react/forbid-elements` rule

* Always apply base `.main-app-content`
2023-01-12 12:37:17 +01:00
Michael Matloka
5c783c744c
chore: Add debug info to JSX output (#12295)
* chore: Add debug info to JSX output

* Pin React to `^16.14.0` instead of `^16.13.0`

* Remove redundant `React`s

* Add `@babel/preset-react` for Storybook

* Update babel.config.js
2022-10-17 19:30:31 +02:00
Ben White
80b3212898
feat: Lemon Skeletons (#11629) 2022-09-08 13:54:00 +00:00
Ben White
5e2ffeb50a
feat: Simplified Links (#11700) 2022-09-08 14:23:28 +02:00
Ben White
b7cdbb505b
feat: LemonInput & TextArea (#11261) 2022-08-16 11:07:50 +02:00
Paul D'Ambra
35173a06fb
chore: adding a test with only is an error (#11145)
* chore: lint it.only as an error

* try and include it.only

* remove it.only example

* remove an it.only caught by the rule
2022-08-04 14:14:11 +01:00
Ben White
61e85b0cbe
feat: Add linting rule for style tag and Antd (#11079) 2022-08-02 10:49:06 +02:00
Michael Matloka
143e8e31c3
style: Reduce ESLint false positives (#9964)
* style: Make JS linting more accurate

* Don't lint autogenerated code
2022-05-25 14:38:44 +00:00
Marius Andra
5d1bae4b8f
chore(upgrade): Kea 3.0, keeping React at 16.11 (#9682)
* upgrade to 2.6

* upgrade kea-forms, validator -> errors

* upgrade to 3.0

* fix some kea 3.0 changes

* default forms to submit

* fix some issues

* newer typegen and router

* new subscriptions plugin

* upgrade packages, replace subscriptionsPlugin

* convert all logic that used forms to kea 3

* bump babel, remove babel-plugin-kea

* fix circluar TS import bug

* fix few tests

* fix more tests

* convert to use new subscriptions

* fix more tests

* convert to v3 to use new subscriptions

* remove packages

* remove unused provider tag

* fix props order

* connect prompts

* misc type additions

* upgrade kea

* clean up few more tests from noise
2022-05-09 11:34:28 +02:00
Marius Andra
10f2522c04
chore(storybook): update to 6.4 and add esbuild (#8893)
* upgrade to storybook 6.4

* storybook esbuild optimizations

* fix warnings reported by storybook
2022-03-08 14:17:59 +01:00
Paul D'Ambra
c38d2c343c
Add linter rule to guide people to the right dayjs import (#8156)
* add linter rule to guide people to the right dayjs import

* resolves dayjs linting errors
2022-01-20 13:13:29 +01:00
Yakko Majuri
e4fd5c5774
Plugin server tests CI (#6897)
* remove workflows from plugin server subdir

* wip plugin server ci tests

* prettier

* add ignore paths

* update paths
2021-11-04 15:03:28 -07:00
Marius Andra
128af73705
Revert "dev(react): add react hook eslint rules, as warnings" (#6831)
* Revert "dev(react): add react hook eslint rules, as warnings (#6571)"

This reverts commit f06e0b4c51.

* revert all eslint comments
2021-11-03 21:44:41 +00:00
Harry Waye
f06e0b4c51
dev(react): add react hook eslint rules, as warnings (#6571)
Here I have installed react-hooks eslint rules. See
https://reactjs.org/docs/hooks-rules.html#eslint-plugin for reference.

The specific trigger for this was [this
fix](abdbe54663)
I put in for a bug, which would have been caught by the
`react-hooks/exhaustive-deps` rule.

I've added these both as warnings as there are currently 69 😏
problems:

```
$ yarn eslint
...
✖ 69 problems (6 errors, 63 warnings)
```

At least this will highlight in editors that support it. We can make
these errors in a follow up PR, but this is valuable in itself without
getting into some yak shaving.
2021-10-20 14:40:06 +01:00
Guido Iaquinti
f4e47abb09
Bump prettier and eslint-config-prettier versions (#6167)
* Bump 'prettier' and 'eslint-config-prettier' version

* Run 'yarn prettier' with the new bumped version
2021-09-29 11:49:29 +01:00
Alex Gyujin Kim
f717d9d126
Better Sessions (Deeplinking, filter matching, expand/collapse options, matching highlights) (#4840)
* eslint

* implement deeplinking on frontend

* highlight matching events

* remove console.logs

* missed a print

* standardize entity to session filter conversion

* add matching events icon

* styling expand column width

* autoscroll, sessions table filtering, action options

* add e2e tests and a few bug fixes

* remove console.logs

* lint rules and typescript fixes
2021-06-30 19:27:36 -07:00
Marius Andra
9314dd47c1
Redefined shadow variable fixes (#4544) 2021-05-31 13:17:53 +02:00
Michael Matloka
ee7289956a
Enhance Project settings (#3240)
* Update Project Danger Zone to Plugins standard

* Extract PinnedDashboards to own component

* Set default body background to white

* Fix JSBookmarklet note style

* Add project rename

* Expect data-attr in okButtonProps type error

* Rename project name section to "DIsplay Name"

* Use disabled and loading on projet DisplayName

* Add models-side Team.name min length requirement

* Make small fixes on Plugins pages

* Revert "Add models-side Team.name min length requirement"

This reverts commit 97874ed7c2.

* minor copy adjustments

* Make button "Rename Project" and improve interactivity

* Remove teamLogic.connect

* Add project rename success toast

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-02-09 18:11:53 +01:00
Michael Matloka
598aea06b9
Make Jest tests work better with TypeScript (#2558)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-01-12 17:46:59 -06:00
Marius Andra
1031329986
Fix dashboard colors with non-white backgrounds (#2911)
* fix local variable bug

* add "no-shadow" rule as a warning

* fix two blue lines on line graphs
2021-01-12 12:43:54 +01:00
Marius Andra
23f129e083
Require curly brackets around if statements (#2505)
* require curly brackets around if statements

* merge
2020-11-25 17:46:49 +01:00
Marius Andra
fccacd69a3
Add eslint rule for empty JSX elements (#2023)
* add rule for self closing components

* fix self closing tag errors
2020-10-26 11:45:57 +01:00
Michael Matloka
c3d3f83c49
Destroy lodash (#1864)
* Convert utils to TS and add missing lodash-like functions

* Purge lodash, using utils and ES features instead

* Remove lodash as a dependency

* Fix Annotation.created_at default value (was null)

* Convert all of utils to TypeScript

* Update ESLint rule @typescript-eslint/explicit-module-boundary-types

* Put all @types/* into devDependencies

* Lower @typescript-eslint/explicit-function-return-type severity

* Fix Annotation.created_at in a better way

* Don't copy item on push in groupBy

* Use `Set.has()` instead of `in Set`

* Update .eslintrc.js

* Update .eslintrc.js
2020-10-14 10:42:06 +02:00
Yakko Majuri
76d629dcbc
Made 'Launch Toolbar' links open in a new tab (#1524)
* made open toolbar links open in a new tab

* Remove noreferrer to allow filtering out visits from PostHog

* Allow referrer

* Disable react/jsx-no-target-blank

Co-authored-by: Michael Matloka <dev@twixes.com>
2020-08-27 14:34:11 +02:00
Marius Andra
3f47ad2d0c
Kea TypeGen (#1286)
* update typescript eslint config / fix tsconfig.json path bug

* add kea-typegen and UserType

* kea-typegen first run, add types to userLogic
2020-07-28 22:25:24 +02:00
Marius Andra
5623551b04
Launch toolbar (#1186)
Co-authored-by: Twixes <dev@twixes.com>
2020-07-17 19:57:42 +02:00
Marius Andra
a256373526
Add Typescript Support (#1157)
* explicitly ignore some linting errors

* add typescript support and fix postcss dev warnings

* convert a few files to ".ts"

* fix return values
2020-07-08 09:45:23 +02:00
Tim Glaser
9b8736d576
Fix cypress linting errors and speed up tests (#865)
* Speed up e2e builds

* Don't go to demo when logging in/cypress errors

* Execute cypress in docker container

* Pull from correct image

* add -T

* Try something else

* Add dockerfile

* Don't push tags

* Tag

* Try another tag

* image tag

* Try pulling

* Try

* Try caching

* no docker ifle

* Install node

* name

* name
2020-06-08 19:34:39 +01:00
Tim Glaser
20fab5d5a2
Add ES Lint (#719)
* Add ES Lint

* Update lint.yml

* move lint file

* Add eslint to package

* use yarn

* Run ci/test only once

* Fix eslint errors

* Fix rest siblings

* precommit hooks

* Lint typo

* ESLint per file

* Eslint
2020-05-13 13:17:00 +01:00