0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-28 00:46:45 +01:00
Commit Graph

4 Commits

Author SHA1 Message Date
Karl-Aksel Puulmann
d507c876ff
Don't show "save" if user has not yet entered all cohort group data. (#3261)
Sentry error: https://sentry.io/organizations/posthog/issues/2062467419/?project=1899813&query=is%3Aunassigned+is%3Aunresolved

From recording I could see that the user filled in Dynamic group >
Action > 7 days, but never picked the action and pressed save. After
seeing no error he stood by for a while.

Also fixes some type errors and a misc bug (choosing action second
deletes days)
2021-02-10 08:24:04 +02:00
Karl-Aksel Puulmann
93e8e3e73d
Fix SelectBox keyboard navigation (#3211)
This was broken since I added support for it in sessions. Typescript
errors were leading to real bugs.

Sentry error: https://sentry.io/organizations/posthog/issues/2161288131/?project=1899813&query=is%3Aunassigned+is%3Aunresolved&sort=freq&statsPeriod=14d
2021-02-05 21:38:31 +02:00
Marius Andra
3259f8e706
Some typescript fixes (#3049)
* fix sceneLogic and teamLogic

* personLogic one fix

* navigationLogic type

* topContentLogic type

* personalAPIKeysLogic type

* BackTo type

* few other quick wins

* Update blacklist after rebase

Co-authored-by: Karl-Aksel Puulmann <oxymaccy@gmail.com>
2021-01-25 11:05:36 +02:00
Karl-Aksel Puulmann
a978b28a68
Run typescript with strict in CI, allow no new errors (#3050)
* Verify no new typescript code breaks "strict" compilation

With this we have a file containing all current errors. As the code
changes, we should not add more errors here.

* remove some lines to show a failure

* Add total count to script

* Update blacklist after rebase

* Remove some fails on purpose.

* Attempt a reorder

* Add missing file

* Update script to write typegen

* Refresh list

* Attempt to use normal tsc

* update blacklist

* Store all errors

* echo for typegen

* Add check command

* typegen 3 times

* typegen 4 times

* typegen 6 times

* typegen 10 times

* remove debug code

* Update kea typegen to latest

* Remove hacks
2021-01-22 16:36:30 +02:00