0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Commit Graph

21 Commits

Author SHA1 Message Date
Raquel Smith
1630e205b4
chore: add self-hosted question to PR template (#20934)
add self-hosted question to PR template
2024-03-14 12:16:36 -07:00
Michael Matloka
07d83b5e20 chore(pr-template): Reformat PR template 2022-03-14 13:41:42 +01:00
Tiina Turban
23566e35bc
Update pull_request_template.md (#8867) 2022-03-07 09:51:19 +01:00
Marcus Hyett (PostHog)
9ae7c194e3
Added section in PR template on problem to solve (#8836)
* Added section on problem to solve

* Update .github/pull_request_template.md

Co-authored-by: Chris Clark <clarkus@users.noreply.github.com>

Co-authored-by: Chris Clark <clarkus@users.noreply.github.com>
2022-03-04 12:19:08 +00:00
Michael Matloka
29b183c9ab
Add Figma link reminder to PR template (#8764) 2022-03-01 08:54:48 +01:00
Marius Andra
f7c133e8fc
Include a link to coding conventions (#8744)
* include a link to coding conventions, change some other words

* Replace "Follow" with "Stay up-to-date-with"

Co-authored-by: Michael Matloka <dev@twixes.com>
2022-02-28 09:17:25 +00:00
Tim Glaser
31ac831739
Update pull_request_template.md (#6952) 2021-11-16 07:50:51 -06:00
Tim Glaser
5c2102b0c0
Add a 'how did you test this PR' + remove checklist (#6123)
Describing how you tested your code means
1. you actually test your code before pushing
2. makes it easier for anyone else looking at your PR to test your code

In exchange for this very marginal increase in work, I have removed the checklist which no-one was filling in anyway and probably didn't add much value.
2021-09-27 18:54:13 +02:00
Michael Matloka
239e197e30
PR template wording update (#4876)
* Update pull_request_template.md

* Update pull_request_template.md
2021-07-02 21:18:24 +02:00
Alex Gyujin Kim
efaec341c7
add backwards compatibility check (#4770) 2021-06-16 10:07:40 +02:00
Marius Andra
0c61194584
add requirement to check CSS responsiveness (#4597) 2021-06-04 20:02:23 +02:00
Marius Andra
f1517bafa1
Are migrations safe to run on cloud? (#3917) 2021-04-08 18:32:36 +00:00
Michael Matloka
d47d92972f
Updates tyle and add Jest checklist item (#2495) 2020-11-24 23:34:15 +01:00
Michael Matloka
533c7df105
Organization<>Team<>User structure (closes #1540) (#1562)
* Backend changes to implement #1461

* Added the missing migration files

* Fixes Typecheck errors

* Refactor request.user.team_set.get() to use request.user.team

* Updated user patch method to change current_team on team id instead of name

* Merged migration file

* Changes team property to return first item in queryset

* Fixes failing tests

* Changed User api to return the ids of the teams they are currently part of

* Frontend for changing teams

* Update and simplify migrations

* Improve team and user buttons

* Make team changing backend more logical

* Improve current_team mechanics

* Update test_team.py

* Fix Team.objects.create_with_data

* Update migration

* Update tests

* Make setup_review more convenient

* Add Organization and OrganizationMembership

* Replace is_admin with level

* Extend API

* Update team.py

* Improve modeling

* Improve handling of new mechanics

* Add proper migration

* Remove _ensure_organization_and_team

* Update 0084_org_team_user.py

* Improve user, org and team creation

* Make MembershipLevel more flexible for the future

* Add member deletion

* Fix naive datetime warnings

* Update setup_review.py

* Update API route

* Make PersonalAPIKey changes

* Update models and migrations, fix typing

* Fix typing

* Use MAC-less UUID v1 instead of v4 for better performance

* Add abstract UUIDModel

* Update utils.py

* Update utils.py

* Fix multi/unicast bit

* Update APIs, frontend and tests

* Update pull_request_template.md

* Fix comment

* Fix migration error

* Compress migrations

* Updates with minimal renaming

* More updates

* Make further updates

* Update test_team_user.py

* Fix issues

* Add migration

* Satisfy mypy

* Remove Signup redirect on logged in

* Use uuid1_macless in Person

* Fix typing

* Update tests

* Update /api/team/signup to /api/organization/signup

* Fix mypy issues and update tests

The remaining failures are actually missing functionality (TDD applied), so filling these in.

* Update 0086_org_live

* Make small improvements

* Implement permissions

* Remove now unneccesary membership check

* Update setup_dev.py

* Make small frontend improvements

* Add drf-nested-routers as requirement

* Remove unused import

* Implemented nested routes

* Remove cruft

* Add relevant org/proj/user name to headings

* Fix imports

* Update migration

* Replace unreliable drf-nested-routers with drf-extensions

* Improve unset team handling

* Make org and team creation proper

* Update migration

* Fix migration

* Update TopContent

* Update command palette for new sidebar structure

* Remove deprecated demo data deletion

* Assume that each org has a project and fix typing

* Require paid plan for multiple orgs and projects

* Make HogFlix demo a separate team

* Update migration

* Slightly improve style

* Adjust page layout bottom padding

* Make user dropdown nicer

* Fix base app tests

* Satisfy mypy

* Fix test_leave_organization

* Improve wording

* Possibly fix import

* Remove misplaced None check

* Enhance org and teams APIs and add tests

* Fix /api/projects for particular Team

* Improve invites and demo data

* Address feedback

* Put everything related to billing on Organization

* Fix minor issues

* Simplify invitation creation

* Update team model

* Make orgs and projects premium only on self-hosted

* Improve testing

* Update migration

* Remove extra License import

* Fix minor issues

* Fix Django tests

* Fix Cypress

* Fix yarn build

* Fix TeamSignupViewset

* Fix posthog-production incompatibility

* Remove extraneous insight endpoint registration

* Adjust tests for posthog-production

* Simplify invitations and fix email validation

* Address all feedback

* Satisfy mypy

* Update migration

* Fix constraint removal in migration

* Update tests

* Fix test creation edge case

* Run posthog-production CI tests against this branch and teams-live

* Ensure that js_posthog_api_key is always passed

* Fix preflight check pre-login

* Update cypress tests

* Update instanceStatus.js

* Bring ee tets up to par

* Bring actions-ux-201012 back

* Cypress retry in cypress.json

* Revert "Run posthog-production CI tests against this branch and teams-live"

This reverts commit d79cb844d8.

Co-authored-by: anna <ms.annaphilips@gmail.com>
Co-authored-by: Anna Philips <aphilips@matmacorp.com>
2020-10-22 10:58:32 +02:00
Michael Matloka
531abebded
Check for missing migrations (#1312)
* Check for missing migrations

* Remove makemigrations from checklist

* Add DATABASE_URL to migrations check

* Add REDIS_URL to migrations check
2020-07-30 19:23:30 +02:00
Michael Matloka
4308e1afed
Add makemigrations to checklist and make it more specific (#1310) 2020-07-30 16:23:00 +02:00
Michael Matloka
35e70f8544
Make GH templates better (#1263)
* Remove useless list of changes stub

* Add PR template Changes placeholder

* Update issue templates

* Love squashing bugs
2020-07-22 11:35:32 +02:00
Michael Matloka
2f3c3d810b
GitHub templates update (#1198)
* Update issue templates

* Adjust pull request template whitespace

* Make "you" in "Thank you" italic
2020-07-13 17:38:11 +02:00
Eric Duong
720c06f9e6
E2e important paths (#802)
* initial test

* add yaml

* add logs

* without tail

* run again for consistency

* wait longer

* manuall configure cypress

* use latest ubuntu

* try installing all

* yarn install

* yarn install with cypress

* full flow

* run again for consistency

* initial tests for trends

* handle exception

* separate e2e docker-compose

* run on pr

* trends-testing foundation

* run test

* don't pass everything

* handle uncaught exceptions

* fix dashboard tests

* change email domain

* change dataattr to data-attr and boilerplate cleanup

* base url config

* add script for test runner

* change default postgres

* test all pages

* basic actions per page and create funnel

* trend breakdown filter

* test create action

* add DAU and entity-specific filter

* uncomment

* run test

* .

* add clicks to tables

* add auth

* add changelog

* add dashbaord click

* uncomment test for single funnel

* add test for pinned dashboard

* fix copy paste button and add invite team link tests

* use data-attr for all filtesr

* fix overall filter

* remove filter

* disasble virtual scroll

* uncomment

* remove unnecessary

* run again

* increase timeout

* remove flimsy test

* run again

* add cypress checklist item

* force click cohorts button

* add opt out capture for tests

* remove some tests

* run twice

* .

* run twice
2020-05-22 12:34:48 -04:00
Tim Glaser
7827aa0971
Update pull_request_template.md 2020-04-27 19:42:42 +01:00
Tim Glaser
321572a92f Add github template 2020-04-20 14:40:11 +01:00