0
0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-25 02:49:32 +01:00
Commit Graph

16 Commits

Author SHA1 Message Date
Harry Waye
f06e0b4c51
dev(react): add react hook eslint rules, as warnings (#6571)
Here I have installed react-hooks eslint rules. See
https://reactjs.org/docs/hooks-rules.html#eslint-plugin for reference.

The specific trigger for this was [this
fix](abdbe54663)
I put in for a bug, which would have been caught by the
`react-hooks/exhaustive-deps` rule.

I've added these both as warnings as there are currently 69 😏
problems:

```
$ yarn eslint
...
✖ 69 problems (6 errors, 63 warnings)
```

At least this will highlight in editors that support it. We can make
these errors in a follow up PR, but this is valuable in itself without
getting into some yak shaving.
2021-10-20 14:40:06 +01:00
Guido Iaquinti
f4e47abb09
Bump prettier and eslint-config-prettier versions (#6167)
* Bump 'prettier' and 'eslint-config-prettier' version

* Run 'yarn prettier' with the new bumped version
2021-09-29 11:49:29 +01:00
Alex Gyujin Kim
f717d9d126
Better Sessions (Deeplinking, filter matching, expand/collapse options, matching highlights) (#4840)
* eslint

* implement deeplinking on frontend

* highlight matching events

* remove console.logs

* missed a print

* standardize entity to session filter conversion

* add matching events icon

* styling expand column width

* autoscroll, sessions table filtering, action options

* add e2e tests and a few bug fixes

* remove console.logs

* lint rules and typescript fixes
2021-06-30 19:27:36 -07:00
Marius Andra
9314dd47c1
Redefined shadow variable fixes (#4544) 2021-05-31 13:17:53 +02:00
Michael Matloka
ee7289956a
Enhance Project settings (#3240)
* Update Project Danger Zone to Plugins standard

* Extract PinnedDashboards to own component

* Set default body background to white

* Fix JSBookmarklet note style

* Add project rename

* Expect data-attr in okButtonProps type error

* Rename project name section to "DIsplay Name"

* Use disabled and loading on projet DisplayName

* Add models-side Team.name min length requirement

* Make small fixes on Plugins pages

* Revert "Add models-side Team.name min length requirement"

This reverts commit 97874ed7c2.

* minor copy adjustments

* Make button "Rename Project" and improve interactivity

* Remove teamLogic.connect

* Add project rename success toast

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-02-09 18:11:53 +01:00
Michael Matloka
598aea06b9
Make Jest tests work better with TypeScript (#2558)
Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
2021-01-12 17:46:59 -06:00
Marius Andra
1031329986
Fix dashboard colors with non-white backgrounds (#2911)
* fix local variable bug

* add "no-shadow" rule as a warning

* fix two blue lines on line graphs
2021-01-12 12:43:54 +01:00
Marius Andra
23f129e083
Require curly brackets around if statements (#2505)
* require curly brackets around if statements

* merge
2020-11-25 17:46:49 +01:00
Marius Andra
fccacd69a3
Add eslint rule for empty JSX elements (#2023)
* add rule for self closing components

* fix self closing tag errors
2020-10-26 11:45:57 +01:00
Michael Matloka
c3d3f83c49
Destroy lodash (#1864)
* Convert utils to TS and add missing lodash-like functions

* Purge lodash, using utils and ES features instead

* Remove lodash as a dependency

* Fix Annotation.created_at default value (was null)

* Convert all of utils to TypeScript

* Update ESLint rule @typescript-eslint/explicit-module-boundary-types

* Put all @types/* into devDependencies

* Lower @typescript-eslint/explicit-function-return-type severity

* Fix Annotation.created_at in a better way

* Don't copy item on push in groupBy

* Use `Set.has()` instead of `in Set`

* Update .eslintrc.js

* Update .eslintrc.js
2020-10-14 10:42:06 +02:00
Yakko Majuri
76d629dcbc
Made 'Launch Toolbar' links open in a new tab (#1524)
* made open toolbar links open in a new tab

* Remove noreferrer to allow filtering out visits from PostHog

* Allow referrer

* Disable react/jsx-no-target-blank

Co-authored-by: Michael Matloka <dev@twixes.com>
2020-08-27 14:34:11 +02:00
Marius Andra
3f47ad2d0c
Kea TypeGen (#1286)
* update typescript eslint config / fix tsconfig.json path bug

* add kea-typegen and UserType

* kea-typegen first run, add types to userLogic
2020-07-28 22:25:24 +02:00
Marius Andra
5623551b04
Launch toolbar (#1186)
Co-authored-by: Twixes <dev@twixes.com>
2020-07-17 19:57:42 +02:00
Marius Andra
a256373526
Add Typescript Support (#1157)
* explicitly ignore some linting errors

* add typescript support and fix postcss dev warnings

* convert a few files to ".ts"

* fix return values
2020-07-08 09:45:23 +02:00
Tim Glaser
9b8736d576
Fix cypress linting errors and speed up tests (#865)
* Speed up e2e builds

* Don't go to demo when logging in/cypress errors

* Execute cypress in docker container

* Pull from correct image

* add -T

* Try something else

* Add dockerfile

* Don't push tags

* Tag

* Try another tag

* image tag

* Try pulling

* Try

* Try caching

* no docker ifle

* Install node

* name

* name
2020-06-08 19:34:39 +01:00
Tim Glaser
20fab5d5a2
Add ES Lint (#719)
* Add ES Lint

* Update lint.yml

* move lint file

* Add eslint to package

* use yarn

* Run ci/test only once

* Fix eslint errors

* Fix rest siblings

* precommit hooks

* Lint typo

* ESLint per file

* Eslint
2020-05-13 13:17:00 +01:00