* Remove find insight from mounted logic
We rather load fresh to be save
* Do not set insights anymore
* Adjust dataNodeLogic
* Make insightLogic not load things on mount when cached
* Make sure refresh happens on filter change
* Make dataNodeLogic never load for dashboard with cached results
* Fix usage of `updateTileOnDashboards`
Fixes remaining unwanted propagation of dashboard filter changes to other dashboards.
* Fix "Remove from dashboard" buttons being out of date
Co-authored-by: Michael Matloka <michal@matloka.com>
So obvious in retrospect
If you listen to the Cypress fail event without re-throwing then you swallow all test failures
"fun"
When reviewing #17919 I knew the Cypress tests would have to be failing which is what prompted me to check
Introduced in bbb7ed9 (July 10th!)
* feat: a little more e2e cypress data exploration tests
* Update UI snapshots for `chromium` (2)
* Update UI snapshots for `chromium` (2)
* tests were passing by accident
---------
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* feat: allow new insight type choice from sidebar
* update e2e test
* add more e2e test fixes
* Update frontend/src/layout/navigation/SideBar/SideBar.tsx
Co-authored-by: Michael Matloka <dev@twixes.com>
* a plus and a width
* allow passing in max width to popover
* Revert "allow passing in max width to popover"
This reverts commit 415a751f71.
* third-ish times the charm
* Use a more concise tooltip
The tooltip basically functions as a on-hover label here, so using the same text as on the saved insights page, where it says "New insight".
* Update UI snapshots for `webkit` (2)
* Update UI snapshots for `webkit` (2)
---------
Co-authored-by: Michael Matloka <dev@twixes.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Problem
@annikaschmid accidentally deleted an insight from a dashboard and then couldn't put it back.
The insight API response was returning the deleted dashboard in the insight's dashboards field. That meant the UI didn't offer the ability to add it to that dashboard because it thought it was already added
Even though there was a test that protected against this which passes and I couldn't figure out why the application behaves well in the test and not when running 🤷
Changes
The dashboard_tiles relation is correct. And we should eventually remove the use of the dashboards relation.
So, let's expose it. This begins the deprecation of the dashboards field on the Insight API.
And overwrites the content of the dashboards field with the correct values when returning a representation of the model.
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Matloka <dev@twixes.com>
Problem
Via customer feedback: If someone is duplicating a dashboard they might not want to duplicate the insights on it.
Changes
This lets them choose.
Problem
Via customer feedback: If someone is deleting a dashboard they want to delete the insights too. At the moment that means they have to delete them one at a time.
Changes
Introduces a modal when deleting a dashboard that lets you choose whether to delete the insights on the dashboard
Soft-deletes the insights as appropriate
