mirrors/posthog
0
0
Fork 0
mirror of https://github.com/PostHog/posthog.git synced 2024-11-24 00:47:50 +01:00
Code Issues Releases Activity

Fix nans in counts formula

Browse Source
This commit is contained in:
Tim Glaser 2021-02-11 20:58:14 +01:00
parent 6a03f353f8
commit e252aab7ef
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ee/clickhouse/queries/trends/formula.py
View File

@ -81,6 +81,6 @@ class ClickhouseTrendsFormula:
additional_values["data"] = [round(number, 2) if not math.isnan(number) else 0.0 for number in item[1]]
if filter.display == TRENDS_CUMULATIVE:
additional_values["data"] = list(accumulate(additional_values["data"]))
additional_values["count"] = float(sum(additional_values["data"]))
response.append(parse_response(item, filter, additional_values))
return response

8
ee/clickhouse/queries/trends/test/test_formula.py
View File

@ -149,9 +149,11 @@ class TestFormula(AbstractIntervalTest, APIBaseTest):
pass
def test_formula(self):
self.assertEqual(self._run({"formula": "A - B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 600.0, 450.0, 0.0])
self.assertEqual(self._run({"formula": "A * B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 270000.0, 405000.0, 0.0])
self.assertEqual(self._run({"formula": "A / B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 3.0, 2.0, 0.0])
# self.assertEqual(self._run({"formula": "A - B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 600.0, 450.0, 0.0])
# self.assertEqual(self._run({"formula": "A * B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 270000.0, 405000.0, 0.0])
# self.assertEqual(self._run({"formula": "A / B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 3.0, 2.0, 0.0])
self.assertEqual(self._run({"formula": "(A/3600)/B"})[0]["data"], [0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0])
self.assertEqual(self._run({"formula": "(A/3600)/B"})[0]["count"], 0)
def test_breakdown(self):
action_response = self._run({"formula": "A - B", "breakdown": "location"})