mirrors/posthog
0
0
Fork 0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Code Issues Releases Activity

fix(trends): Show appropriate nested math value immediately (#12679)

Browse Source
This commit is contained in:
Michael Matloka 2022-11-08 16:36:01 +01:00 committed by GitHub
parent 634976f304
commit df11cf6c68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
frontend/src/scenes/insights/filters/ActionFilter/ActionFilterRow/ActionFilterRow.tsx
View File

@ -414,18 +414,29 @@ interface MathSelectorProps {
style?: React.CSSProperties
}
function useMathSelectorOptions(
index: number,
mathAvailability: MathAvailability,
onMathSelect: (index: number, value: any) => any
): LemonSelectOptions<string> {
function isPropertyValueMath(math: string | undefined): math is PropertyMathType {
return !!math && math in PROPERTY_MATH_DEFINITIONS
}
function isCountPerActorMath(math: string | undefined): math is CountPerActorMathType {
return !!math && math in COUNT_PER_ACTOR_MATH_DEFINITIONS
}
function useMathSelectorOptions({
math,
index,
mathAvailability,
onMathSelect,
}: MathSelectorProps): LemonSelectOptions<string> {
const { needsUpgradeForGroups, canStartUsingGroups, staticMathDefinitions, staticActorsOnlyMathDefinitions } =
useValues(mathsLogic)
const { featureFlags } = useValues(featureFlagLogic)
const [propertyMathTypeShown, setPropertyMathTypeShown] = useState<PropertyMathType>(PropertyMathType.Average)
const [propertyMathTypeShown, setPropertyMathTypeShown] = useState<PropertyMathType>(
isPropertyValueMath(math) ? math : PropertyMathType.Average
)
const [countPerActorMathTypeShown, setCountPerActorMathTypeShown] = useState<CountPerActorMathType>(
CountPerActorMathType.Average
isCountPerActorMath(math) ? math : CountPerActorMathType.Average
)
const options: LemonSelectOption<string>[] = Object.entries(
@ -508,14 +519,9 @@ function useMathSelectorOptions(
]
}
function MathSelector({
math,
mathGroupTypeIndex,
mathAvailability,
index,
onMathSelect,
}: MathSelectorProps): JSX.Element {
const options = useMathSelectorOptions(index, mathAvailability, onMathSelect)
function MathSelector(props: MathSelectorProps): JSX.Element {
const options = useMathSelectorOptions(props)
const { math, mathGroupTypeIndex, index, onMathSelect } = props
const mathType = apiValueToMathType(math, mathGroupTypeIndex)