mirrors/posthog
0
0
Fork 0
mirror of https://github.com/PostHog/posthog.git synced 2024-12-01 12:21:02 +01:00
Code Issues Releases Activity

fix: Raise non-retryable exception on invalid s3 key (#26421)

Browse Source
This commit is contained in:
Tomás Farías Santana 2024-11-26 12:18:13 +01:00 committed by GitHub
parent f43bb995d4
commit 8cdc80a440
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
posthog/temporal/batch_exports/s3_batch_export.py
View File

@ -112,6 +112,13 @@ def get_s3_key(inputs) -> str:
return key
class InvalidS3Key(Exception):
"""Exception raised when an invalid S3 key is provided."""
def __init__(self, err):
super().__init__(f"An invalid S3 key was provided: {err}")
class UploadAlreadyInProgressError(Exception):
"""Exception raised when an S3MultiPartUpload is already in progress."""
@ -469,7 +476,11 @@ async def initialize_and_resume_multipart_upload(
) -> tuple[S3MultiPartUpload, S3HeartbeatDetails]:
"""Initialize a S3MultiPartUpload and resume it from a hearbeat state if available."""
logger = await bind_temporal_worker_logger(team_id=inputs.team_id, destination="S3")
key = get_s3_key(inputs)
try:
key = get_s3_key(inputs)
except Exception as e:
raise InvalidS3Key(e) from e
s3_upload = S3MultiPartUpload(
bucket_name=inputs.bucket_name,
@ -772,6 +783,8 @@ class S3BatchExportWorkflow(PostHogWorkflow):
"EndpointConnectionError",
# Input contained an empty S3 endpoint URL
"EmptyS3EndpointURLError",
# User provided an invalid S3 key
"InvalidS3Key",
],
finish_inputs=finish_inputs,
)