From 209431c6f654f536f42b3664d38d6465e53824a0 Mon Sep 17 00:00:00 2001
From: Sam Winslow <sammywinslow@gmail.com>
Date: Thu, 6 May 2021 21:13:25 -0400
Subject: [PATCH] Horizontal UI mobile tweaks (#4245)

Co-authored-by: Paolo D'Amico <paolodamico@users.noreply.github.com>
---
 .../lib/components/CompareFilter/CompareFilter.tsx  |  2 +-
 .../insights/InsightTabs/InsightDisplayConfig.tsx   |  6 ++++--
 .../InsightTabs/TrendTab/TrendTabHorizontal.tsx     |  7 +++++--
 frontend/src/scenes/insights/Insights.scss          | 13 +++++++++++++
 4 files changed, 23 insertions(+), 5 deletions(-)

diff --git a/frontend/src/lib/components/CompareFilter/CompareFilter.tsx b/frontend/src/lib/components/CompareFilter/CompareFilter.tsx
index abf88c6d2a2..6fe35039d34 100644
--- a/frontend/src/lib/components/CompareFilter/CompareFilter.tsx
+++ b/frontend/src/lib/components/CompareFilter/CompareFilter.tsx
@@ -15,7 +15,7 @@ export function CompareFilter(): JSX.Element {
             style={{ marginLeft: 8, marginRight: 6 }}
             disabled={disabled}
         >
-            Compare previous
+            Compare<span className="hide-lte-md"> previous</span>
         </Checkbox>
     )
 }
diff --git a/frontend/src/scenes/insights/InsightTabs/InsightDisplayConfig.tsx b/frontend/src/scenes/insights/InsightTabs/InsightDisplayConfig.tsx
index cb2b88656fd..36606be386f 100644
--- a/frontend/src/scenes/insights/InsightTabs/InsightDisplayConfig.tsx
+++ b/frontend/src/scenes/insights/InsightTabs/InsightDisplayConfig.tsx
@@ -140,8 +140,10 @@ function HorizontalDefaultInsightDisplayConfig({
     const dateFilterDisabled = activeView === ViewType.FUNNELS && isFunnelEmpty(allFilters)
 
     return (
-        <div style={{ display: 'flex', alignItems: 'center' }}>
-            <TZIndicator style={{ float: 'left' }} />
+        <div className="display-config-inner">
+            <span className="hide-lte-md">
+                <TZIndicator style={{ float: 'left' }} />
+            </span>
             <div style={{ width: '100%', textAlign: 'right' }}>
                 {showComparePrevious[activeView] && <CompareFilter />}
                 {showChartFilter(activeView, featureFlags) && (
diff --git a/frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTabHorizontal.tsx b/frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTabHorizontal.tsx
index 507bee35d51..717a244fd82 100644
--- a/frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTabHorizontal.tsx
+++ b/frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTabHorizontal.tsx
@@ -16,6 +16,7 @@ import { preflightLogic } from 'scenes/PreflightCheck/logic'
 import './TrendTab.scss'
 import { SaveToDashboard } from 'lib/components/SaveToDashboard/SaveToDashboard'
 import { TrendTabProps } from './TrendTab'
+import useBreakpoint from 'antd/lib/grid/hooks/useBreakpoint'
 
 export function TrendTabHorizontal({ view, annotationsToCreate }: TrendTabProps): JSX.Element {
     const { filters, filtersLoading } = useValues(trendsLogic({ dashboardItemId: null, view }))
@@ -30,11 +31,13 @@ export function TrendTabHorizontal({ view, annotationsToCreate }: TrendTabProps)
         { name: 'returning', tooltip: 'Users who consistently use the product.' },
         { name: 'dormant', tooltip: 'Users who are inactive.' },
     ]
+    const screens = useBreakpoint()
+    const isSmallScreen = screens.xs || (screens.sm && !screens.md)
 
     return (
         <>
             <Row gutter={16}>
-                <Col md={16}>
+                <Col md={16} xs={24}>
                     <h3 className="l3" style={{ display: 'flex', alignItems: 'center' }}>
                         Unsaved query{' '}
                         <SaveToDashboard
@@ -62,7 +65,7 @@ export function TrendTabHorizontal({ view, annotationsToCreate }: TrendTabProps)
                         />
                     )}
                 </Col>
-                <Col md={8}>
+                <Col md={8} xs={24} style={{ marginTop: isSmallScreen ? '2rem' : 0 }}>
                     {filters.insight === ViewType.LIFECYCLE && (
                         <>
                             <h4 className="secondary">Lifecycle Toggles</h4>
diff --git a/frontend/src/scenes/insights/Insights.scss b/frontend/src/scenes/insights/Insights.scss
index b4c16dcdbf0..111fabf2948 100644
--- a/frontend/src/scenes/insights/Insights.scss
+++ b/frontend/src/scenes/insights/Insights.scss
@@ -59,10 +59,23 @@
                 border: 1px solid $border_light;
                 padding-right: $default_spacing / 4;
 
+                @media screen and (max-width: $md) {
+                    padding-left: $default_spacing / 4;
+                }
+
                 .ant-card-head-title {
                     padding: $default_spacing / 2 0;
                 }
             }
+
+            .display-config-inner {
+                display: flex;
+                align-items: center;
+
+                @media screen and (max-width: $md) {
+                    overflow-x: auto;
+                }
+            }
         }
     }
 }