From 0100e50cd8ac6f1c01bf39254e05f8103cc413b5 Mon Sep 17 00:00:00 2001 From: Paolo D'Amico Date: Wed, 14 Apr 2021 01:33:27 -0700 Subject: [PATCH] Remove fixed typescript errors (#3956) * Remove fixed typescript errors * remove more errors * more errors be gone * and some more * double digits errors --- .ts-strict-blacklist | 167 +----------------- .../components/Annotations/Annotations.tsx | 5 +- .../SaveToDashboard/SaveToDashboard.tsx | 2 +- frontend/src/lib/components/Table.tsx | 2 +- 4 files changed, 7 insertions(+), 169 deletions(-) diff --git a/.ts-strict-blacklist b/.ts-strict-blacklist index 133c5ddaa82..dbb7e65690a 100644 --- a/.ts-strict-blacklist +++ b/.ts-strict-blacklist @@ -4,142 +4,22 @@ Type.ts frontend/src/initKea.ts(2,32) frontend/src/initKea.ts(4,31) frontend/src/initKea.ts(5,36) -frontend/src/layout/TopContent/TopSelectors.tsx(69,53) -frontend/src/layout/TopContent/TopSelectors.tsx(115,29) -frontend/src/layout/TopContent/TopSelectors.tsx(133,26) -frontend/src/layout/navigation/MainNavigation.tsx(17,20) -frontend/src/layout/navigation/MainNavigation.tsx(18,20) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(16,29) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(16,32) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(69,17) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(69,21) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(69,27) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(69,34) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(69,48) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(88,23) -frontend/src/lib/components/Annotations/AnnotationMarker.tsx(288,17) -frontend/src/lib/components/Annotations/Annotations.tsx(42,52) -frontend/src/lib/components/Annotations/Annotations.tsx(52,36) -frontend/src/lib/components/Annotations/Annotations.tsx(52,43) -frontend/src/lib/components/Annotations/Annotations.tsx(61,36) -frontend/src/lib/components/BillingToolbar.tsx(12,20) -frontend/src/lib/components/BillingToolbar.tsx(12,59) -frontend/src/lib/components/BillingToolbar.tsx(17,36) -frontend/src/lib/components/BillingToolbar.tsx(21,63) +frontend/src/lib/components/Annotations/Annotations.tsx(43,52) frontend/src/lib/components/CommandPalette/CommandInput.tsx(5,25) frontend/src/lib/components/CommandPalette/CommandResults.tsx(76,33) frontend/src/lib/components/CommandPalette/index.tsx(9,24) frontend/src/lib/components/CommandPalette/index.tsx(26,33) frontend/src/lib/components/CommandPalette/index.tsx(63,87) -frontend/src/lib/components/Link.tsx(27,32) -frontend/src/lib/components/LinkButton.tsx(6,29) -frontend/src/lib/components/PersonalAPIKeys/PersonalAPIKeys.tsx(134,13) frontend/src/lib/components/PropertyFilters/OperatorValueSelect.tsx(59,22) frontend/src/lib/components/PropertyFilters/OperatorValueSelect.tsx(87,38) frontend/src/lib/components/PropertyFilters/PropertySelect.tsx(36,29) frontend/src/lib/components/PropertyFilters/PropertySelect.tsx(36,36) -frontend/src/lib/components/SaveToDashboard/SaveToDashboard.tsx(44,27) frontend/src/lib/components/SelectBox.tsx(60,104) frontend/src/lib/components/SelectBox.tsx(61,13) frontend/src/lib/components/SelectBox.tsx(133,29) -frontend/src/lib/components/Table.tsx(10,42) -frontend/src/lib/components/Table.tsx(22,42) frontend/src/lib/utils.tsx(597,29) frontend/src/loadPostHogJS.tsx(28,44) frontend/src/models/cohortsModel.ts(25,5) -frontend/src/models/dashboardItemsModel.tsx(12,31) -frontend/src/models/dashboardItemsModel.tsx(13,38) -frontend/src/models/dashboardItemsModel.tsx(14,34) -frontend/src/models/dashboardItemsModel.tsx(14,40) -frontend/src/models/dashboardItemsModel.tsx(15,41) -frontend/src/models/dashboardItemsModel.tsx(18,39) -frontend/src/models/dashboardItemsModel.tsx(46,17) -frontend/src/models/dashboardItemsModel.tsx(68,26) -frontend/src/scenes/actions/ActionsTable.tsx(10,25) -frontend/src/scenes/actions/ActionsTable.tsx(11,29) -frontend/src/scenes/actions/ActionsTable.tsx(12,28) -frontend/src/scenes/actions/ActionsTable.tsx(40,41) -frontend/src/scenes/actions/ActionsTable.tsx(55,53) -frontend/src/scenes/actions/ActionsTable.tsx(64,41) -frontend/src/scenes/actions/ActionsTable.tsx(125,29) -frontend/src/scenes/actions/ActionsTable.tsx(136,36) -frontend/src/scenes/actions/ActionsTable.tsx(139,29) -frontend/src/scenes/actions/ActionsTable.tsx(192,35) -frontend/src/scenes/annotations/index.tsx(30,47) -frontend/src/scenes/annotations/index.tsx(49,47) -frontend/src/scenes/annotations/index.tsx(55,48) -frontend/src/scenes/annotations/index.tsx(61,43) -frontend/src/scenes/annotations/index.tsx(67,41) -frontend/src/scenes/annotations/index.tsx(144,44) -frontend/src/scenes/annotations/index.tsx(150,38) -frontend/src/scenes/annotations/index.tsx(154,39) -frontend/src/scenes/annotations/index.tsx(230,50) -frontend/src/scenes/annotations/index.tsx(240,55) -frontend/src/scenes/annotations/index.tsx(278,70) -frontend/src/scenes/annotations/index.tsx(280,59) -frontend/src/scenes/billing/Billing.tsx(6,24) -frontend/src/scenes/billing/Billing.tsx(51,24) -frontend/src/scenes/billing/Billing.tsx(53,61) -frontend/src/scenes/billing/Billing.tsx(54,32) -frontend/src/scenes/billing/Billing.tsx(57,43) -frontend/src/scenes/billing/Billing.tsx(60,32) -frontend/src/scenes/billing/Billing.tsx(60,55) -frontend/src/scenes/billing/Billing.tsx(71,25) -frontend/src/scenes/billing/Billing.tsx(84,24) -frontend/src/scenes/billing/Billing.tsx(84,47) -frontend/src/scenes/billing/Billing.tsx(86,72) -frontend/src/scenes/billing/Billing.tsx(92,24) -frontend/src/scenes/billing/Billing.tsx(92,46) -frontend/src/scenes/billing/Billing.tsx(94,82) -frontend/src/scenes/billing/Billing.tsx(96,40) -frontend/src/scenes/billing/Billing.tsx(99,25) -frontend/src/scenes/billing/billingLogic.ts(31,28) -frontend/src/scenes/billing/billingLogic.ts(31,61) -frontend/src/scenes/billing/billingLogic.ts(31,84) -frontend/src/scenes/billing/billingLogic.ts(34,41) -frontend/src/scenes/billing/billingLogic.ts(34,76) -frontend/src/scenes/billing/billingLogic.ts(62,24) -frontend/src/scenes/billing/billingLogic.ts(62,47) -frontend/src/scenes/dashboard/DashboardItems.tsx(5,43) -frontend/src/scenes/dashboard/DashboardItems.tsx(46,30) -frontend/src/scenes/dashboard/DashboardItems.tsx(46,30) -frontend/src/scenes/dashboard/DashboardItems.tsx(46,38) -frontend/src/scenes/dashboard/DashboardItems.tsx(50,29) -frontend/src/scenes/dashboard/DashboardItems.tsx(50,45) -frontend/src/scenes/dashboard/DashboardItems.tsx(50,48) -frontend/src/scenes/dashboard/DashboardItems.tsx(56,24) -frontend/src/scenes/dashboard/DashboardItems.tsx(56,24) -frontend/src/scenes/dashboard/DashboardItems.tsx(56,32) -frontend/src/scenes/dashboard/DashboardItems.tsx(56,32) -frontend/src/scenes/dashboard/DashboardItems.tsx(56,41) -frontend/src/scenes/dashboard/DashboardItems.tsx(57,38) -frontend/src/scenes/dashboard/DashboardItems.tsx(57,70) -frontend/src/scenes/dashboard/DashboardItems.tsx(64,42) -frontend/src/scenes/dashboard/DashboardItems.tsx(75,37) -frontend/src/scenes/dashboard/DashboardItems.tsx(78,37) -frontend/src/scenes/dashboard/DashboardItems.tsx(79,17) -frontend/src/scenes/dashboard/DashboardItems.tsx(87,22) -frontend/src/scenes/dashboard/DashboardItems.tsx(92,43) -frontend/src/scenes/dashboard/Dashboards.tsx(27,42) -frontend/src/scenes/dashboard/Dashboards.tsx(27,46) -frontend/src/scenes/dashboard/Dashboards.tsx(56,46) -frontend/src/scenes/events/Events.tsx(47,22) -frontend/src/scenes/events/EventsVolumeTable.tsx(53,14) -frontend/src/scenes/events/EventsVolumeTable.tsx(55,22) -frontend/src/scenes/events/EventsVolumeTable.tsx(63,29) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(18,17) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(18,45) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(21,18) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(21,45) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(72,14) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(74,22) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(82,29) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(83,59) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(85,25) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(85,55) -frontend/src/scenes/events/PropertiesVolumeTable.tsx(88,17) -frontend/src/scenes/ingestion/frameworks/CodeSnippet.tsx(103,41) -frontend/src/scenes/ingestion/ingestionLogic.ts(126,21) frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(51,50) frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(52,41) frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(95,34) @@ -155,8 +35,6 @@ frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(152,34) frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(161,21) frontend/src/scenes/insights/ActionFilter/ActionFilterDropdown.tsx(162,21) frontend/src/scenes/insights/ActionSelectInfo.tsx(11,9) -frontend/src/scenes/insights/EmptyStates.tsx(4,31) -frontend/src/scenes/insights/EmptyStates.tsx(5,35) frontend/src/scenes/insights/InsightHistoryPanel/InsightHistoryPanel.tsx(63,29) frontend/src/scenes/insights/InsightHistoryPanel/InsightHistoryPanel.tsx(69,53) frontend/src/scenes/insights/InsightHistoryPanel/InsightHistoryPanel.tsx(92,55) @@ -169,10 +47,6 @@ frontend/src/scenes/insights/InsightTabs/FunnelTab/FunnelTab.tsx(58,32) frontend/src/scenes/insights/InsightTabs/FunnelTab/funnelCommandLogic.ts(13,41) frontend/src/scenes/insights/InsightTabs/PathTab.tsx(41,14) frontend/src/scenes/insights/InsightTabs/PathTab.tsx(49,25) -frontend/src/scenes/insights/InsightTabs/RetentionTab.tsx(28,22) -frontend/src/scenes/insights/InsightTabs/RetentionTab.tsx(44,22) -frontend/src/scenes/insights/InsightTabs/RetentionTab.tsx(97,47) -frontend/src/scenes/insights/InsightTabs/RetentionTab.tsx(121,17) frontend/src/scenes/insights/InsightTabs/SessionTab.tsx(15,63) frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTab.tsx(31,30) frontend/src/scenes/insights/InsightTabs/TrendTab/TrendTab.tsx(60,40) @@ -190,40 +64,10 @@ frontend/src/scenes/instance/Licenses/logic.ts(53,104) frontend/src/scenes/instance/Licenses/logic.ts(53,116) frontend/src/scenes/instance/Licenses/logic.ts(55,32) frontend/src/scenes/instance/Licenses/logic.ts(56,30) -frontend/src/scenes/organization/CreateOrganizationModal.tsx(45,17) -frontend/src/scenes/organization/TeamMembers/Invites.tsx(101,17) -frontend/src/scenes/organization/TeamMembers/Members.tsx(144,27) -frontend/src/scenes/organization/TeamMembers/Members.tsx(217,13) -frontend/src/scenes/organization/TeamMembers/Members.tsx(230,13) -frontend/src/scenes/persons/Cohort.tsx(23,38) -frontend/src/scenes/persons/Cohort.tsx(24,34) -frontend/src/scenes/persons/Cohort.tsx(67,38) -frontend/src/scenes/persons/Cohort.tsx(68,34) -frontend/src/scenes/persons/Cohort.tsx(80,33) -frontend/src/scenes/persons/Cohort.tsx(80,40) -frontend/src/scenes/persons/Cohort.tsx(166,52) -frontend/src/scenes/persons/Cohort.tsx(168,36) frontend/src/scenes/persons/CohortGroup.tsx(88,29) -frontend/src/scenes/persons/Cohorts.tsx(27,33) -frontend/src/scenes/persons/Cohorts.tsx(65,83) -frontend/src/scenes/persons/Cohorts.tsx(69,42) -frontend/src/scenes/persons/Cohorts.tsx(72,55) -frontend/src/scenes/persons/Cohorts.tsx(72,65) -frontend/src/scenes/persons/Cohorts.tsx(85,48) frontend/src/scenes/persons/MergePerson.tsx(56,56) frontend/src/scenes/plugins/PluginImage.tsx(4,30) frontend/src/scenes/plugins/Repository.tsx(22,56) -frontend/src/scenes/project/CreateProjectModal.tsx(46,17) -frontend/src/scenes/project/Settings/DangerZone.tsx(24,17) -frontend/src/scenes/retention/RetentionLineGraph.tsx(41,17) -frontend/src/scenes/retention/RetentionLineGraph.tsx(72,32) -frontend/src/scenes/retention/RetentionLineGraph.tsx(72,67) -frontend/src/scenes/retention/RetentionLineGraph.tsx(73,26) -frontend/src/scenes/retention/retentionTableLogic.ts(91,28) -frontend/src/scenes/retention/retentionTableLogic.ts(94,34) -frontend/src/scenes/retention/retentionTableLogic.ts(118,39) -frontend/src/scenes/retention/retentionTableLogic.ts(140,23) -frontend/src/scenes/retention/retentionTableLogic.ts(177,33) frontend/src/scenes/sessions/SessionDetails.tsx(55,51) frontend/src/scenes/sessions/SessionsView.tsx(199,29) frontend/src/scenes/sessions/filters/DurationFilter.tsx(27,34) @@ -236,7 +80,6 @@ frontend/src/scenes/sessions/filters/SessionsFilterBox.tsx(87,13) frontend/src/scenes/sessions/filters/SessionsFilterBox.tsx(116,13) frontend/src/scenes/sessions/filters/SessionsFilterBox.tsx(173,9) frontend/src/scenes/sessions/sessionsPlayLogic.ts(155,61) -frontend/src/scenes/teamLogic.tsx(10,5) frontend/src/toolbar/ToolbarApp.tsx(35,74) frontend/src/toolbar/actions/SelectorCount.tsx(2,38) frontend/src/toolbar/actions/actionsTabLogic.tsx(104,21) @@ -247,10 +90,4 @@ frontend/src/toolbar/elements/ElementInfo.tsx(60,38) frontend/src/toolbar/elements/elementsLogic.ts(14,40) frontend/src/toolbar/elements/heatmapLogic.ts(12,62) frontend/src/toolbar/utils.ts(5,38) -frontend/src/layout/navigation/TopNavigation.tsx(74,91) -frontend/src/models/funnelsModel.ts(13,9) -frontend/src/scenes/insights/insightLogic.ts(68,27) -frontend/src/scenes/insights/insightLogic.ts(69,39) -frontend/src/scenes/insights/insightLogic.ts(82,47) -frontend/src/scenes/insights/insightLogic.ts(88,23) -frontend/src/scenes/insights/insightLogic.ts(88,26) +frontend/src/models/funnelsModel.ts(13,9) \ No newline at end of file diff --git a/frontend/src/lib/components/Annotations/Annotations.tsx b/frontend/src/lib/components/Annotations/Annotations.tsx index 96355d9af83..7b6b821d582 100644 --- a/frontend/src/lib/components/Annotations/Annotations.tsx +++ b/frontend/src/lib/components/Annotations/Annotations.tsx @@ -4,6 +4,7 @@ import { annotationsLogic } from './annotationsLogic' import { useValues, useActions } from 'kea' import { AnnotationMarker } from './AnnotationMarker' import { AnnotationScope } from 'lib/constants' +import { AnnotationType } from '~/types' export const Annotations = function Annotations({ dates, @@ -49,7 +50,7 @@ export const Annotations = function Annotations({ left={index * interval + leftExtent - 12.5} top={topExtent} annotations={annotations} - onCreate={(input, applyAll) => { + onCreate={(input: string, applyAll: boolean) => { if (applyAll) { createGlobalAnnotation(input, dates[index], dashboardItemId) } else if (dashboardItemId) { @@ -58,7 +59,7 @@ export const Annotations = function Annotations({ createAnnotation(input, dates[index]) } }} - onDelete={(data) => { + onDelete={(data: AnnotationType) => { annotations.length === 1 && onClose?.() if (data.scope !== AnnotationScope.DashboardItem) { deleteGlobalAnnotation(data.id) diff --git a/frontend/src/lib/components/SaveToDashboard/SaveToDashboard.tsx b/frontend/src/lib/components/SaveToDashboard/SaveToDashboard.tsx index 679167377cf..0d616929d23 100644 --- a/frontend/src/lib/components/SaveToDashboard/SaveToDashboard.tsx +++ b/frontend/src/lib/components/SaveToDashboard/SaveToDashboard.tsx @@ -25,7 +25,7 @@ export function SaveToDashboard(props: Props): JSX.Element { const { item } = props const [openModal, setOpenModal] = useState(false) const [{ fromItem, fromItemName, fromDashboard }] = useState(router.values.hashParams) - let _name: string + let _name: string = '' let _filters: Record | null = null let _annotations: Array> | null = null diff --git a/frontend/src/lib/components/Table.tsx b/frontend/src/lib/components/Table.tsx index 6a635d4c026..3c90bae731d 100644 --- a/frontend/src/lib/components/Table.tsx +++ b/frontend/src/lib/components/Table.tsx @@ -19,7 +19,7 @@ export function createdByColumn(items: Record[]): Record