mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
f645cc7318
This commit updates tools/js2c.py to touch the target output file , <(SHARED_INTERMEDIATE_DIR)/node_javascript.cc, even if the content has not changed. This is to "help" the build system so that it can compare the inputs against the output to determine if the gyp action should be run. I believe the issue here is that if js2c.py is updated this can cause the action to be run as the node_javascript.cc target would be older than js2c.py. But when the target is run the timestamp for node_javascript.cc will not be updated (because we have not changed anything that would change the contents of the file) so the js2c.py prerequisite will always be passed and the target always run. Using the update in this commit one would have to touch/modify one of the js files specified in the library_files list, config.gypi, or tools/js2c.py for this action to be run again. PR-URL: https://github.com/nodejs/node/pull/33844 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> |
||
|---|---|---|
| .. | ||
| bootstrap | ||
| clang-format | ||
| code_cache | ||
| configure.d | ||
| doc | ||
| eslint-rules | ||
| gyp | ||
| icu | ||
| inspector_protocol | ||
| macos-installer | ||
| msvs | ||
| node_modules | ||
| node-lint-md-cli-rollup | ||
| pip | ||
| rpm | ||
| snapshot | ||
| v8_gypfiles | ||
| .eslintrc.yaml | ||
| build-addons.js | ||
| certdata.txt | ||
| checkimports.py | ||
| compress_json.py | ||
| cpplint.py | ||
| create_android_makefiles | ||
| create_expfile.sh | ||
| genv8constants.py | ||
| getarch.py | ||
| getendian.py | ||
| getmachine.py | ||
| getmoduleversion.py | ||
| getnapibuildversion.py | ||
| getnodeversion.py | ||
| gyp_node.py | ||
| install.py | ||
| js2c.py | ||
| license2rtf.js | ||
| license-builder.sh | ||
| lint-js.js | ||
| lint-md.js | ||
| lint-pr-commit-message.sh | ||
| lsan_suppressions.txt | ||
| macos-firewall.sh | ||
| make-v8.sh | ||
| mk-ca-bundle.pl | ||
| mkssldef.py | ||
| osx-codesign.sh | ||
| osx-entitlements.plist | ||
| osx-gon-config.json.tmpl | ||
| osx-notarize.sh | ||
| osx-pkg-postinstall.sh | ||
| osx-productsign.sh | ||
| release.sh | ||
| run-valgrind.py | ||
| run-worker.js | ||
| sign.bat | ||
| specialize_node_d.py | ||
| test-npm-package.js | ||
| test-v8.bat | ||
| test.py | ||
| update-authors.js | ||
| update-babel-eslint.sh | ||
| update-eslint.sh | ||
| utils.py | ||
| valgrind.supp | ||