mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
b73e66e949
Keep track of C++ `TryCatch` state to avoid aborting when an exception is thrown inside one, and re-throw in JS to make sure the exception is being picked up a second time by a second uncaught exception handler, if necessary. Add a bit of a hack to `AppendExceptionLine` to avoid overriding the line responsible for re-throwing the exception. PR-URL: https://github.com/nodejs/node/pull/17394 Fixes: https://github.com/nodejs/node/issues/13258 Reviewed-By: James M Snell <jasnell@gmail.com>
41 lines
1.1 KiB
JavaScript
41 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const vm = require('vm');
|
|
const node = process.execPath;
|
|
|
|
if (process.argv[2] === 'child') {
|
|
throw new Error('child error');
|
|
} else if (process.argv[2] === 'vm') {
|
|
// Refs: https://github.com/nodejs/node/issues/13258
|
|
// This *should* still crash.
|
|
new vm.Script('[', {});
|
|
} else {
|
|
run('', 'child', null);
|
|
run('--abort-on-uncaught-exception', 'child',
|
|
['SIGABRT', 'SIGTRAP', 'SIGILL']);
|
|
run('--abort-on-uncaught-exception', 'vm', ['SIGABRT', 'SIGTRAP', 'SIGILL']);
|
|
}
|
|
|
|
function run(flags, argv2, signals) {
|
|
const args = [__filename, argv2];
|
|
if (flags)
|
|
args.unshift(flags);
|
|
|
|
const child = spawn(node, args);
|
|
child.on('exit', common.mustCall(function(code, sig) {
|
|
if (common.isWindows) {
|
|
if (signals)
|
|
assert.strictEqual(code, 0xC0000005);
|
|
else
|
|
assert.strictEqual(code, 1);
|
|
} else if (signals) {
|
|
assert(signals.includes(sig), `Unexpected signal ${sig}`);
|
|
} else {
|
|
assert.strictEqual(sig, null);
|
|
}
|
|
}));
|
|
}
|