0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-29 15:06:33 +01:00
nodejs/lib
Robert Nagy f8c069f5b8 stream: increase MAX_HWM
MAX_HWM was added in 9208c89 where the highwatermark was changed to
always increase in steps of highest power of 2 to prevent increasing
hwm excessivly in tiny amounts.

Why a limit was added on the highwatermark is unclear but breaks
existing usage where a larger read size is used. The invariant for
read(n) is that a buffer of size n is always returned. Considering
a maximum ceiling on the buffer size breaks this invariant.

This PR significantly increases the limit to make it less likely to
break the previous invariant and also documents the limit.

Fixes: https://github.com/nodejs/node/issues/29933

PR-URL: https://github.com/nodejs/node/pull/29938
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2019-11-11 19:50:40 -08:00
..
internal esm: exit the process with an error if loader has an issue 2019-11-09 09:30:36 +01:00
_http_agent.js http: replace vars with lets and consts in lib/_http_agent.js 2019-11-08 14:00:10 -08:00
_http_client.js http: emit close on socket re-use 2019-10-15 16:51:09 -07:00
_http_common.js http: remove legacy parser 2019-09-20 20:18:35 +02:00
_http_incoming.js http: support readable hwm in IncomingMessage 2019-10-30 10:32:46 -04:00
_http_outgoing.js stream: add writableCorked property 2019-11-05 23:26:26 +01:00
_http_server.js src: bring 425 status code name into accordance with RFC 8470 2019-10-10 10:48:13 -07:00
_stream_duplex.js lib: change var to let in lib/_stream_duplex.js 2019-11-09 05:47:58 -08:00
_stream_passthrough.js
_stream_readable.js stream: increase MAX_HWM 2019-11-11 19:50:40 -08:00
_stream_transform.js
_stream_wrap.js
_stream_writable.js stream: add writableCorked property 2019-11-05 23:26:26 +01:00
_tls_common.js tls: replace var with let and const 2019-11-08 13:58:57 -08:00
_tls_wrap.js lib: introduce no-mixed-operators eslint rule to lib 2019-10-05 13:59:32 -07:00
.eslintrc.yaml tools: prohibit Error.prepareStackTrace() usage 2019-10-05 20:19:17 -07:00
assert.js assert: replace var with let in lib/assert.js 2019-11-09 14:11:31 +08:00
async_hooks.js async_hooks: only emit after for AsyncResource if stack not empty 2019-10-26 15:19:23 +02:00
buffer.js buffer: change var to let 2019-11-09 13:19:51 +01:00
child_process.js child_process,cluster: allow using V8 serialization API 2019-11-05 23:07:04 +01:00
cluster.js
console.js
constants.js
crypto.js
dgram.js dgram: remove listeners on bind error 2019-11-07 00:55:00 +01:00
dns.js dns: switch var to const/let 2019-11-09 05:49:26 -08:00
domain.js domain: do not import util for a simple type check 2019-10-12 21:59:34 -07:00
events.js events: improve performance of EventEmitter.emit 2019-09-24 09:12:59 +02:00
fs.js fs: change var to let 2019-11-08 15:31:05 -08:00
http2.js
http.js
https.js https: change var to let in lib/https.js 2019-11-08 15:27:20 -08:00
inspector.js lib: remove the use of util.isFunction 2019-09-17 18:41:20 -07:00
module.js
net.js net: treat ENOTCONN at shutdown as success 2019-10-12 03:09:22 +02:00
os.js
path.js path: replace var with let in lib/path.js 2019-11-09 08:44:29 -08:00
perf_hooks.js perf_hooks: remove non-existent entries from inspect 2019-09-13 13:35:51 -07:00
process.js
punycode.js
querystring.js querystring: improve performance 2019-08-28 03:12:11 -04:00
readline.js lib: introduce no-mixed-operators eslint rule to lib 2019-10-05 13:59:32 -07:00
repl.js module: refactor modules bootstrap 2019-10-16 21:50:05 -04:00
stream.js stream: simplify uint8ArrayToBuffer helper 2019-10-22 13:37:59 -05:00
string_decoder.js
sys.js
timers.js timers: set _destroyed even if there are no destroy-hooks 2019-09-22 16:19:26 -07:00
tls.js
trace_events.js
tty.js tty: expose stream API from readline methods 2019-07-18 17:20:45 -04:00
url.js lib: introduce no-mixed-operators eslint rule to lib 2019-10-05 13:59:32 -07:00
util.js lib: introduce no-mixed-operators eslint rule to lib 2019-10-05 13:59:32 -07:00
v8.js v8: inspect unserializable objects 2019-11-05 20:01:39 +01:00
vm.js vm: add Synthetic modules 2019-10-14 14:25:38 -07:00
worker_threads.js worker: allow specifying resource limits 2019-11-05 19:57:13 +01:00
zlib.js zlib: remove usage of public util module 2019-07-19 11:06:29 -07:00