mirror of
https://github.com/nodejs/node.git
synced 2024-11-27 22:16:50 +01:00
d4e365f606
Node.js seems to change how it is uploaded based on the method, but HTTP doesn't make any distinction. Co-authored-by: Austin Wright <aaa@bzfx.net> Co-authored-by: Lenvin Gonsalves <lenvingonsalves@gmail.com> Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34066 Refs: https://github.com/nodejs/node/issues/27880 Reviewed-By: James M Snell <jasnell@gmail.com>
53 lines
1.7 KiB
JavaScript
53 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
// Refs: https://github.com/nodejs/node/pull/34066
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
// Test that ClientRequest#end with default options
|
|
// and empty payload sends neither Content-Length nor Transfer-Encoding.
|
|
// Sending Content-Length: 0 would be acceptable, but is unnecessary.
|
|
const upload = 'PUT / HTTP/1.1\r\n\r\n';
|
|
const response = '';
|
|
|
|
// Test that the upload is properly received with the same headers,
|
|
// regardless of request method.
|
|
const methods = [ 'GET', 'HEAD', 'DELETE', 'POST', 'PATCH', 'PUT', 'OPTIONS' ];
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
req.on('data', function(chunk) {
|
|
assert.strictEqual(chunk.toString(), upload);
|
|
});
|
|
res.setHeader('Content-Type', 'text/plain');
|
|
res.write(`${req.method}\r\n`);
|
|
for (let i = 0; i < req.rawHeaders.length; i += 2) {
|
|
// Ignore a couple headers that may vary
|
|
if (req.rawHeaders[i].toLowerCase() === 'host') continue;
|
|
if (req.rawHeaders[i].toLowerCase() === 'connection') continue;
|
|
res.write(`${req.rawHeaders[i]}: ${req.rawHeaders[i + 1]}\r\n`);
|
|
}
|
|
res.end();
|
|
}), methods.length);
|
|
|
|
server.listen(0, function tryNextRequest() {
|
|
const method = methods.pop();
|
|
if (method === undefined) return;
|
|
const port = server.address().port;
|
|
const req = http.request({ method, port }, function(res) {
|
|
const chunks = [];
|
|
res.on('data', function(chunk) {
|
|
chunks.push(chunk);
|
|
});
|
|
res.on('end', function() {
|
|
const received = Buffer.concat(chunks).toString();
|
|
const expected = method.toLowerCase() + '\r\n' + response;
|
|
assert.strictEqual(received.toLowerCase(), expected);
|
|
tryNextRequest();
|
|
});
|
|
});
|
|
|
|
req.end();
|
|
}).unref();
|