mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
1640dedb3b
StringBytes::Write() did a plain memcpy() when is_extern is true but that's wrong when the source is a two-byte string and the destination a one-byte or UTF-8 string. The impact is limited to strings > 1,031,913 bytes because those are normally the only strings that are externalized, although the use of the 'externalize strings' extension (--expose_externalize_string) can also trigger it. This commit also cleans up the bytes versus characters confusion in StringBytes::Write() because that was closely intertwined with the UCS-2 encoding regression. One wasn't fixable without the other. Fixes: https://github.com/iojs/io.js/issues/1024 Fixes: https://github.com/joyent/node/issues/8683 PR-URL: https://github.com/iojs/io.js/pull/1042 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
122 lines
3.9 KiB
JavaScript
122 lines
3.9 KiB
JavaScript
var common = require('../common');
|
|
var assert = require('assert');
|
|
// minimum string size to overflow into external string space
|
|
var EXTERN_APEX = 0xFBEE9;
|
|
|
|
// manually controlled string for checking binary output
|
|
var ucs2_control = 'a\u0000';
|
|
var write_str = 'a';
|
|
|
|
|
|
// first do basic checks
|
|
var b = new Buffer(write_str, 'ucs2');
|
|
var c = b.toString('binary');
|
|
assert.equal(b[0], 0x61);
|
|
assert.equal(b[1], 0);
|
|
assert.equal(ucs2_control, c);
|
|
|
|
// now create big strings
|
|
var size = 1 + (1 << 20);
|
|
write_str = Array(size).join(write_str);
|
|
ucs2_control = Array(size).join(ucs2_control);
|
|
|
|
// check resultant buffer and output string
|
|
var b = new Buffer(write_str, 'ucs2');
|
|
// check fist Buffer created from write string
|
|
for (var i = 0; i < b.length; i += 2) {
|
|
assert.equal(b[i], 0x61);
|
|
assert.equal(b[i + 1], 0);
|
|
}
|
|
// create another string to create an external string
|
|
var b_bin = b.toString('binary');
|
|
var b_ucs = b.toString('ucs2');
|
|
// check control against external binary string
|
|
assert.equal(ucs2_control, b_bin);
|
|
// create buffer copy from external
|
|
var c_bin = new Buffer(b_bin, 'binary');
|
|
var c_ucs = new Buffer(b_ucs, 'ucs2');
|
|
// make sure they're the same length
|
|
assert.equal(c_bin.length, c_ucs.length);
|
|
// make sure Buffers from externals are the same
|
|
for (var i = 0; i < c_bin.length; i++) {
|
|
assert.equal(c_bin[i], c_ucs[i], c_bin[i] + ' == ' + c_ucs[i] +
|
|
' : index ' + i);
|
|
}
|
|
// check resultant strings
|
|
assert.equal(c_bin.toString('ucs2'), c_ucs.toString('ucs2'));
|
|
assert.equal(c_bin.toString('binary'), ucs2_control);
|
|
assert.equal(c_ucs.toString('binary'), ucs2_control);
|
|
|
|
|
|
|
|
// now let's test BASE64 and HEX ecoding/decoding
|
|
var RADIOS = 2;
|
|
var PRE_HALF_APEX = Math.ceil(EXTERN_APEX / 2) - RADIOS;
|
|
var PRE_3OF4_APEX = Math.ceil((EXTERN_APEX / 4) * 3) - RADIOS;
|
|
|
|
(function () {
|
|
for (var j = 0; j < RADIOS * 2; j += 1) {
|
|
var datum = b;
|
|
var slice = datum.slice(0, PRE_HALF_APEX + j);
|
|
var slice2 = datum.slice(0, PRE_HALF_APEX + j + 2);
|
|
var pumped_string = slice.toString('hex');
|
|
var pumped_string2 = slice2.toString('hex');
|
|
var decoded = new Buffer(pumped_string, 'hex');
|
|
|
|
var metadata = "\nEXTERN_APEX=1031913 - pumped_string.length="
|
|
metadata += pumped_string.length + '\n';
|
|
|
|
// the string are the same?
|
|
for (var k = 0; k < pumped_string.length; ++k) {
|
|
assert.equal(pumped_string[k], pumped_string2[k],
|
|
metadata + 'chars should be the same at ' + k);
|
|
}
|
|
|
|
// the recoded buffer is the same?
|
|
for (var i = 0; i < decoded.length; ++i) {
|
|
assert.equal(datum[i], decoded[i],
|
|
metadata + 'bytes should be the same at ' + i);
|
|
}
|
|
}
|
|
})();
|
|
|
|
(function () {
|
|
for (var j = 0; j < RADIOS * 2; j += 1) {
|
|
var datum = b;
|
|
var slice = datum.slice(0, PRE_3OF4_APEX + j);
|
|
var slice2 = datum.slice(0, PRE_3OF4_APEX + j + 2);
|
|
var pumped_string = slice.toString('base64');
|
|
var pumped_string2 = slice2.toString('base64');
|
|
var decoded = new Buffer(pumped_string, 'base64');
|
|
|
|
var metadata = "\nEXTERN_APEX=1031913 - data=" + slice.length
|
|
metadata += " pumped_string.length=" + pumped_string.length + '\n';
|
|
|
|
// the string are the same?
|
|
for (var k = 0; k < pumped_string.length - 3; ++k) {
|
|
assert.equal(pumped_string[k], pumped_string2[k],
|
|
metadata + 'chars should be the same for two slices at '
|
|
+ k + ' ' + pumped_string[k] + ' ' + pumped_string2[k]);
|
|
}
|
|
|
|
// the recoded buffer is the same?
|
|
for (var i = 0; i < decoded.length; ++i) {
|
|
assert.equal(datum[i], decoded[i],
|
|
metadata + 'bytes should be the same at ' + i);
|
|
}
|
|
}
|
|
})();
|
|
|
|
// https://github.com/iojs/io.js/issues/1024
|
|
(function() {
|
|
var a = Array(1 << 20).join('x');
|
|
var b = Buffer(a, 'ucs2').toString('ucs2');
|
|
var c = Buffer(b, 'utf8').toString('utf8');
|
|
|
|
assert.equal(a.length, b.length);
|
|
assert.equal(b.length, c.length);
|
|
|
|
assert.equal(a, b);
|
|
assert.equal(b, c);
|
|
})();
|