0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
nodejs/tools
Adam Majer f2a089a754 test: fix unit test logging with python3
A logfile must be opened as a text file and encoding is specified.
Then it can accept a string. Current behaviour we get,

 Message: 'ok 2834 sequential/test-worker-prof'
 Arguments: ()
 --- Logging error ---
 Traceback (most recent call last):
   File "/usr/lib64/python3.7/logging/__init__.py", line 1037, in emit
     stream.write(msg + self.terminator)
 TypeError: a bytes-like object is required, not 'str'
 Call stack:
   File "tools/test.py", line 1734, in <module>
     sys.exit(Main())
   File "tools/test.py", line 1710, in Main
     if RunTestCases(cases_to_run, options.progress, options.j, options.flaky_tests):
   File "tools/test.py", line 933, in RunTestCases
     return progress.Run(tasks)
   File "tools/test.py", line 141, in Run
     self.RunSingle(False, 0)
   File "tools/test.py", line 202, in RunSingle
     self.HasRun(output)
   File "tools/test.py", line 365, in HasRun
     logger.info('  ---')

PR-URL: https://github.com/nodejs/node/pull/31156
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2020-01-08 07:43:55 -08:00
..
bootstrap
clang-format
code_cache doc: add documentation about node_mksnapshot and mkcodecache 2019-12-05 18:57:33 +08:00
configure.d
doc tools: add unified plugin changing links for html docs 2019-11-30 18:17:56 +01:00
eslint-rules lib,tools,test: remove custom number-isnan rule 2020-01-08 00:22:25 -05:00
gyp test: fix Python unittests in ./test and ./tools 2019-11-11 10:44:54 +01:00
icu tools: update icu to 65.1 2019-12-05 20:39:20 -05:00
inspector_protocol
macos-installer
msvs win: change to use Python in install tool 2020-01-08 06:20:35 -08:00
node_modules tools: update ESLint to 6.8.0 2019-12-22 17:04:38 -08:00
node-lint-md-cli-rollup tools: enable Markdown linter's usage information 2019-12-14 21:44:42 -08:00
pip
rpm
snapshot doc: add documentation about node_mksnapshot and mkcodecache 2019-12-05 18:57:33 +08:00
v8_gypfiles tools: fix Raspbian armv7 build 2019-12-25 11:39:19 +01:00
.eslintrc.yaml
build-addons.js
certdata.txt tools: update certdata.txt 2019-11-05 09:51:31 -08:00
check-imports.py tools: check-imports using utf-8 2019-11-05 11:28:39 +01:00
compress_json.py
cpplint.py tools,src: forbid usage of v8::Persistent 2019-12-24 14:35:22 +01:00
create_android_makefiles
create_expfile.sh
genv8constants.py
getarch.py
getendian.py
getmachine.py
getmoduleversion.py
getnapibuildversion.py
getnodeversion.py
gyp_node.py
install.py
js2c.py build: remove (almost) unused macros/constants 2019-12-05 15:46:55 -08:00
license2rtf.js
license-builder.sh wasi: introduce initial WASI support 2019-11-30 18:06:39 +01:00
lint-js.js
lint-md.js tools: enable Markdown linter's usage information 2019-12-14 21:44:42 -08:00
lint-pr-commit-message.sh
lsan_suppressions.txt
macos-firewall.sh
make-v8.sh tools: use CC instead of CXX when pointing to gcc 2019-12-07 00:45:51 -05:00
mk-ca-bundle.pl
mkssldef.py
osx-codesign.sh
osx-pkg-postinstall.sh
osx-productsign.sh
release.sh
run-valgrind.py
run-worker.js
sign.bat
specialize_node_d.py
test-npm-package.js
test-v8.bat
test.py test: fix unit test logging with python3 2020-01-08 07:43:55 -08:00
update-authors.js
update-babel-eslint.sh
update-eslint.sh
utils.py test: skip the unsupported test cases for IBM i 2019-12-25 23:11:02 +01:00
valgrind.supp