mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
eda702104b
The error emitted when a connection is closed before the TLS handshake completes seemed rather unspefic by just saying `socket hang up`. Use a more verbose message, that also indicates that this is a purely client-side error, and remove a misleading comment. PR-URL: https://github.com/nodejs/node/pull/18989 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
186 lines
5.0 KiB
JavaScript
186 lines
5.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
if (!process.features.tls_sni)
|
|
common.skip('node compiled without OpenSSL or with old OpenSSL version.');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
function loadPEM(n) {
|
|
return fixtures.readKey(`${n}.pem`);
|
|
}
|
|
|
|
const serverOptions = {
|
|
key: loadPEM('agent2-key'),
|
|
cert: loadPEM('agent2-cert'),
|
|
requestCert: true,
|
|
rejectUnauthorized: false,
|
|
SNICallback: function(servername, callback) {
|
|
const context = SNIContexts[servername];
|
|
|
|
// Just to test asynchronous callback
|
|
setTimeout(function() {
|
|
if (context) {
|
|
if (context.emptyRegression)
|
|
callback(null, {});
|
|
else
|
|
callback(null, tls.createSecureContext(context));
|
|
} else {
|
|
callback(null, null);
|
|
}
|
|
}, 100);
|
|
}
|
|
};
|
|
|
|
const SNIContexts = {
|
|
'a.example.com': {
|
|
key: loadPEM('agent1-key'),
|
|
cert: loadPEM('agent1-cert'),
|
|
ca: [ loadPEM('ca2-cert') ]
|
|
},
|
|
'b.example.com': {
|
|
key: loadPEM('agent3-key'),
|
|
cert: loadPEM('agent3-cert')
|
|
},
|
|
'c.another.com': {
|
|
emptyRegression: true
|
|
}
|
|
};
|
|
|
|
const clientsOptions = [{
|
|
port: undefined,
|
|
key: loadPEM('agent1-key'),
|
|
cert: loadPEM('agent1-cert'),
|
|
ca: [loadPEM('ca1-cert')],
|
|
servername: 'a.example.com',
|
|
rejectUnauthorized: false
|
|
}, {
|
|
port: undefined,
|
|
key: loadPEM('agent4-key'),
|
|
cert: loadPEM('agent4-cert'),
|
|
ca: [loadPEM('ca1-cert')],
|
|
servername: 'a.example.com',
|
|
rejectUnauthorized: false
|
|
}, {
|
|
port: undefined,
|
|
key: loadPEM('agent2-key'),
|
|
cert: loadPEM('agent2-cert'),
|
|
ca: [loadPEM('ca2-cert')],
|
|
servername: 'b.example.com',
|
|
rejectUnauthorized: false
|
|
}, {
|
|
port: undefined,
|
|
key: loadPEM('agent3-key'),
|
|
cert: loadPEM('agent3-cert'),
|
|
ca: [loadPEM('ca1-cert')],
|
|
servername: 'c.wrong.com',
|
|
rejectUnauthorized: false
|
|
}, {
|
|
port: undefined,
|
|
key: loadPEM('agent3-key'),
|
|
cert: loadPEM('agent3-cert'),
|
|
ca: [loadPEM('ca1-cert')],
|
|
servername: 'c.another.com',
|
|
rejectUnauthorized: false
|
|
}];
|
|
|
|
const serverResults = [];
|
|
const clientResults = [];
|
|
const serverErrors = [];
|
|
const clientErrors = [];
|
|
let serverError;
|
|
let clientError;
|
|
|
|
const server = tls.createServer(serverOptions, function(c) {
|
|
serverResults.push({ sni: c.servername, authorized: c.authorized });
|
|
});
|
|
|
|
server.on('tlsClientError', function(err) {
|
|
serverResults.push(null);
|
|
serverError = err.message;
|
|
});
|
|
|
|
server.listen(0, startTest);
|
|
|
|
function startTest() {
|
|
function connectClient(i, callback) {
|
|
const options = clientsOptions[i];
|
|
clientError = null;
|
|
serverError = null;
|
|
|
|
options.port = server.address().port;
|
|
const client = tls.connect(options, function() {
|
|
clientResults.push(
|
|
client.authorizationError &&
|
|
(client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
|
|
client.destroy();
|
|
|
|
next();
|
|
});
|
|
|
|
client.on('error', function(err) {
|
|
clientResults.push(false);
|
|
clientError = err.message;
|
|
next();
|
|
});
|
|
|
|
function next() {
|
|
clientErrors.push(clientError);
|
|
serverErrors.push(serverError);
|
|
|
|
if (i === clientsOptions.length - 1)
|
|
callback();
|
|
else
|
|
connectClient(i + 1, callback);
|
|
}
|
|
}
|
|
|
|
connectClient(0, function() {
|
|
server.close();
|
|
});
|
|
}
|
|
|
|
process.on('exit', function() {
|
|
assert.deepStrictEqual(serverResults, [
|
|
{ sni: 'a.example.com', authorized: false },
|
|
{ sni: 'a.example.com', authorized: true },
|
|
{ sni: 'b.example.com', authorized: false },
|
|
{ sni: 'c.wrong.com', authorized: false },
|
|
null
|
|
]);
|
|
assert.deepStrictEqual(clientResults, [true, true, true, false, false]);
|
|
assert.deepStrictEqual(clientErrors, [
|
|
null, null, null, null,
|
|
'Client network socket disconnected before secure TLS ' +
|
|
'connection was established'
|
|
]);
|
|
assert.deepStrictEqual(serverErrors, [
|
|
null, null, null, null, 'Invalid SNI context'
|
|
]);
|
|
});
|