mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
9301b8a9c6
Make the deprecated `tls.createSecurePair()` method use other public APIs only (`TLSSocket` in particular). Since `tls.createSecurePair()` has been runtime-deprecated only since Node 8, it probably isn’t quite time to remove it yet, but this patch removes almost all of the code complexity that is retained by it. The API, as it is documented, is retained. However, it is very likely that some users have come to rely on parts of undocumented API of the `SecurePair` class, especially since some of the existing tests checked for those. Therefore, this should definitely be considered a breaking change. PR-URL: https://github.com/nodejs/node/pull/17882 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
29 lines
923 B
JavaScript
29 lines
923 B
JavaScript
// Flags: --expose-gc --no-deprecation
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const { createSecureContext } = require('tls');
|
|
const { createSecurePair } = require('tls');
|
|
|
|
const before = process.memoryUsage().external;
|
|
{
|
|
const context = createSecureContext();
|
|
const options = {};
|
|
for (let i = 0; i < 1e4; i += 1)
|
|
createSecurePair(context, false, false, false, options).destroy();
|
|
}
|
|
setImmediate(() => {
|
|
global.gc();
|
|
const after = process.memoryUsage().external;
|
|
|
|
// It's not an exact science but a SecurePair grows .external by about 45 kB.
|
|
// Unless AdjustAmountOfExternalAllocatedMemory() is called on destruction,
|
|
// 10,000 instances make it grow by well over 400 MB. Allow for some slop
|
|
// because objects like buffers also affect the external limit.
|
|
assert(after - before < 25 << 20);
|
|
});
|