mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
9b7a6914a7
Currently the writable side of the socket is closed as soon as `UV_EOF` is read regardless of the state of the socket. This allows the handle to be closed before `'end'` is emitted and thus `'close'` can be emitted before `'end'` if the socket is paused. This commit prevents the handle from being closed until `'end'` is emitted ensuring the correct order of events. PR-URL: https://github.com/nodejs/node/pull/19241 Fixes: https://github.com/nodejs/node/issues/19166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
82 lines
2.5 KiB
JavaScript
82 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
// Create an ssl server. First connection, validate that not resume.
|
|
// Cache session and close connection. Use session on second connection.
|
|
// ASSERT resumption.
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const options = {
|
|
key: fixtures.readKey('agent2-key.pem'),
|
|
cert: fixtures.readKey('agent2-cert.pem')
|
|
};
|
|
|
|
// create server
|
|
const server = tls.Server(options, common.mustCall(function(socket) {
|
|
socket.end('Goodbye');
|
|
}, 2));
|
|
|
|
// start listening
|
|
server.listen(0, function() {
|
|
|
|
let session1 = null;
|
|
const client1 = tls.connect({
|
|
port: this.address().port,
|
|
rejectUnauthorized: false
|
|
}, function() {
|
|
console.log('connect1');
|
|
assert.ok(!client1.isSessionReused(), 'Session *should not* be reused.');
|
|
session1 = client1.getSession();
|
|
});
|
|
|
|
client1.on('close', function() {
|
|
console.log('close1');
|
|
|
|
const opts = {
|
|
port: server.address().port,
|
|
rejectUnauthorized: false,
|
|
session: session1
|
|
};
|
|
|
|
const client2 = tls.connect(opts, function() {
|
|
console.log('connect2');
|
|
assert.ok(client2.isSessionReused(), 'Session *should* be reused.');
|
|
});
|
|
|
|
client2.on('close', function() {
|
|
console.log('close2');
|
|
server.close();
|
|
});
|
|
|
|
client2.resume();
|
|
});
|
|
|
|
client1.resume();
|
|
});
|