mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
7ce2555896
The current custom instanceof for `Writable` subclasses previously returned false positives for instances of *other* subclasses of `Writable` because it was inherited by these subclasses. Fixes: https://github.com/nodejs/node/issues/14943 PR-URL: https://github.com/nodejs/node/pull/14945 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
64 lines
1.9 KiB
JavaScript
64 lines
1.9 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { Readable, Writable, Duplex, Transform } = require('stream');
|
|
|
|
const readable = new Readable({ read() {} });
|
|
const writable = new Writable({ write() {} });
|
|
const duplex = new Duplex({ read() {}, write() {} });
|
|
const transform = new Transform({ transform() {} });
|
|
|
|
assert.ok(readable instanceof Readable);
|
|
assert.ok(!(writable instanceof Readable));
|
|
assert.ok(duplex instanceof Readable);
|
|
assert.ok(transform instanceof Readable);
|
|
|
|
assert.ok(!(readable instanceof Writable));
|
|
assert.ok(writable instanceof Writable);
|
|
assert.ok(duplex instanceof Writable);
|
|
assert.ok(transform instanceof Writable);
|
|
|
|
assert.ok(!(readable instanceof Duplex));
|
|
assert.ok(!(writable instanceof Duplex));
|
|
assert.ok(duplex instanceof Duplex);
|
|
assert.ok(transform instanceof Duplex);
|
|
|
|
assert.ok(!(readable instanceof Transform));
|
|
assert.ok(!(writable instanceof Transform));
|
|
assert.ok(!(duplex instanceof Transform));
|
|
assert.ok(transform instanceof Transform);
|
|
|
|
assert.ok(!(null instanceof Writable));
|
|
assert.ok(!(undefined instanceof Writable));
|
|
|
|
// Simple inheritance check for `Writable` works fine in a subclass constructor.
|
|
function CustomWritable() {
|
|
assert.ok(
|
|
this instanceof CustomWritable,
|
|
`${this} does not inherit from CustomWritable`
|
|
);
|
|
assert.ok(
|
|
this instanceof Writable,
|
|
`${this} does not inherit from Writable`
|
|
);
|
|
}
|
|
|
|
Object.setPrototypeOf(CustomWritable, Writable);
|
|
Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);
|
|
|
|
new CustomWritable();
|
|
|
|
common.expectsError(
|
|
CustomWritable,
|
|
{
|
|
code: 'ERR_ASSERTION',
|
|
type: assert.AssertionError,
|
|
message: 'undefined does not inherit from CustomWritable'
|
|
}
|
|
);
|
|
|
|
class OtherCustomWritable extends Writable {}
|
|
|
|
assert(!(new OtherCustomWritable() instanceof CustomWritable));
|
|
assert(!(new CustomWritable() instanceof OtherCustomWritable));
|