mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
9b7a6914a7
Currently the writable side of the socket is closed as soon as `UV_EOF` is read regardless of the state of the socket. This allows the handle to be closed before `'end'` is emitted and thus `'close'` can be emitted before `'end'` if the socket is paused. This commit prevents the handle from being closed until `'end'` is emitted ensuring the correct order of events. PR-URL: https://github.com/nodejs/node/pull/19241 Fixes: https://github.com/nodejs/node/issues/19166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
39 lines
855 B
JavaScript
39 lines
855 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
const big = Buffer.alloc(1024 * 1024);
|
|
|
|
const server = net.createServer((socket) => {
|
|
socket.end(big);
|
|
server.close();
|
|
}).listen(0, () => {
|
|
let prev = 0;
|
|
|
|
function checkRaise(value) {
|
|
assert(value > prev);
|
|
prev = value;
|
|
}
|
|
|
|
const socket = net.connect(server.address().port, () => {
|
|
socket.on('data', (chunk) => {
|
|
checkRaise(socket.bytesRead);
|
|
});
|
|
|
|
socket.on('end', common.mustCall(() => {
|
|
assert.strictEqual(socket.bytesRead, prev);
|
|
assert.strictEqual(big.length, prev);
|
|
}));
|
|
|
|
socket.on('close', common.mustCall(() => {
|
|
assert(!socket._handle);
|
|
assert.strictEqual(socket.bytesRead, prev);
|
|
assert.strictEqual(big.length, prev);
|
|
}));
|
|
|
|
socket.end();
|
|
});
|
|
});
|