mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
380929ec0c
This change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
62 lines
2.1 KiB
JavaScript
62 lines
2.1 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const net = require('net');
|
|
const assert = require('assert');
|
|
|
|
// Verify that invalid delays throw
|
|
const s = new net.Socket();
|
|
const nonNumericDelays = [
|
|
'100', true, false, undefined, null, '', {}, () => {}, []
|
|
];
|
|
const badRangeDelays = [-0.001, -1, -Infinity, Infinity, NaN];
|
|
const validDelays = [0, 0.001, 1, 1e6];
|
|
|
|
|
|
for (let i = 0; i < nonNumericDelays.length; i++) {
|
|
assert.throws(function() {
|
|
s.setTimeout(nonNumericDelays[i], () => {});
|
|
}, TypeError);
|
|
}
|
|
|
|
for (let i = 0; i < badRangeDelays.length; i++) {
|
|
assert.throws(function() {
|
|
s.setTimeout(badRangeDelays[i], () => {});
|
|
}, RangeError);
|
|
}
|
|
|
|
for (let i = 0; i < validDelays.length; i++) {
|
|
assert.doesNotThrow(function() {
|
|
s.setTimeout(validDelays[i], () => {});
|
|
});
|
|
}
|
|
|
|
const server = net.Server();
|
|
server.listen(0, common.mustCall(function() {
|
|
const socket = net.createConnection(this.address().port);
|
|
socket.setTimeout(1, common.mustCall(function() {
|
|
socket.destroy();
|
|
server.close();
|
|
}));
|
|
}));
|