mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
4ba33c90c6
The test pummel/test-dtrace-jsstack is broken and probably has been for a very long time. Remove it. It gets skipped on anything that is non-SunOS. In our CI, that means skipped everywhere but SmartOS. When run on SmartOS in our CI (which never happens because it's in pummel, but I moved it into sequential to test it), it fails because it needs elevated privileges. When I log into the SmartOS machine and run the test as root, it fails with: AssertionError [ERR_ASSERTION]: did not find expected frame stalloogle Since I have dtrace installed on my macOS machine, I tried running it locally but removing the SunOS check. It failed because the test leaks a global variable. I removed the global leak check, and the test failed because I have System Integrity Protection enabled. In short, the test does not work in its current form, has almost certainly not worked in a long time, and is very likely to be brittle if we ever do fix it. I'm inclined to remove it. PR-URL: https://github.com/nodejs/node/pull/26869 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> |
||
|---|---|---|
| .. | ||
| test-abort-fatal-error.js | ||
| test-child-process-spawn-loop.js | ||
| test-crypto-dh.js | ||
| test-crypto-timing-safe-equal-benchmarks.js | ||
| test-dh-regr.js | ||
| test-fs-largefile.js | ||
| test-fs-watch-file-slow.js | ||
| test-fs-watch-file.js | ||
| test-fs-watch-non-recursive.js | ||
| test-fs-watch-system-limit.js | ||
| test-hash-seed.js | ||
| test-heapdump-dns.js | ||
| test-heapdump-fs-promise.js | ||
| test-heapdump-http2.js | ||
| test-heapdump-inspector.js | ||
| test-heapdump-tls.js | ||
| test-heapdump-worker.js | ||
| test-heapdump-zlib.js | ||
| test-http-many-keep-alive-connections.js | ||
| test-http-upload-timeout.js | ||
| test-https-large-response.js | ||
| test-https-no-reader.js | ||
| test-keep-alive.js | ||
| test-net-connect-econnrefused.js | ||
| test-net-many-clients.js | ||
| test-net-pause.js | ||
| test-net-pingpong-delay.js | ||
| test-net-pingpong.js | ||
| test-net-throttle.js | ||
| test-net-timeout2.js | ||
| test-net-timeout.js | ||
| test-net-write-callbacks.js | ||
| test-next-tick-infinite-calls.js | ||
| test-process-cpuUsage.js | ||
| test-process-hrtime.js | ||
| test-regress-GH-814_2.js | ||
| test-regress-GH-814.js | ||
| test-regress-GH-892.js | ||
| test-stream-pipe-multi.js | ||
| test-timers.js | ||
| test-tls-server-large-request.js | ||
| test-tls-throttle.js | ||
| test-vm-memleak.js | ||
| test-vm-race.js | ||
| test-watch-file.js | ||
| testcfg.py | ||