mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
758a17f1d5
Synchronize the argument list for `dns.resolve()` with what's in the documentation. Improve the error for a bad `rrtype` to be a `TypeError` rather than an `Error`. PR-URL: https://github.com/nodejs/node/pull/13090 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
195 lines
6.2 KiB
JavaScript
195 lines
6.2 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const dns = require('dns');
|
|
|
|
const existing = dns.getServers();
|
|
assert(existing.length > 0);
|
|
|
|
// Verify that setServers() handles arrays with holes and other oddities
|
|
assert.doesNotThrow(() => {
|
|
const servers = [];
|
|
|
|
servers[0] = '127.0.0.1';
|
|
servers[2] = '0.0.0.0';
|
|
dns.setServers(servers);
|
|
});
|
|
|
|
assert.doesNotThrow(() => {
|
|
const servers = ['127.0.0.1', '192.168.1.1'];
|
|
|
|
servers[3] = '127.1.0.1';
|
|
servers[4] = '127.1.0.1';
|
|
servers[5] = '127.1.1.1';
|
|
|
|
Object.defineProperty(servers, 2, {
|
|
enumerable: true,
|
|
get: () => {
|
|
servers.length = 3;
|
|
return '0.0.0.0';
|
|
}
|
|
});
|
|
|
|
dns.setServers(servers);
|
|
});
|
|
|
|
const goog = [
|
|
'8.8.8.8',
|
|
'8.8.4.4',
|
|
];
|
|
assert.doesNotThrow(() => dns.setServers(goog));
|
|
assert.deepStrictEqual(dns.getServers(), goog);
|
|
assert.throws(() => dns.setServers(['foobar']),
|
|
/^Error: IP address is not properly formatted: foobar$/);
|
|
assert.deepStrictEqual(dns.getServers(), goog);
|
|
|
|
const goog6 = [
|
|
'2001:4860:4860::8888',
|
|
'2001:4860:4860::8844',
|
|
];
|
|
assert.doesNotThrow(() => dns.setServers(goog6));
|
|
assert.deepStrictEqual(dns.getServers(), goog6);
|
|
|
|
goog6.push('4.4.4.4');
|
|
dns.setServers(goog6);
|
|
assert.deepStrictEqual(dns.getServers(), goog6);
|
|
|
|
const ports = [
|
|
'4.4.4.4:53',
|
|
'[2001:4860:4860::8888]:53',
|
|
];
|
|
const portsExpected = [
|
|
'4.4.4.4',
|
|
'2001:4860:4860::8888',
|
|
];
|
|
dns.setServers(ports);
|
|
assert.deepStrictEqual(dns.getServers(), portsExpected);
|
|
|
|
assert.doesNotThrow(() => dns.setServers([]));
|
|
assert.deepStrictEqual(dns.getServers(), []);
|
|
|
|
assert.throws(() => {
|
|
dns.resolve('example.com', [], common.mustNotCall());
|
|
}, /^TypeError: "rrtype" argument must be a string$/);
|
|
|
|
// dns.lookup should accept only falsey and string values
|
|
{
|
|
const errorReg =
|
|
/^TypeError: Invalid arguments: hostname must be a string or falsey$/;
|
|
|
|
assert.throws(() => dns.lookup({}, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup([], common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(true, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(1, common.mustNotCall()), errorReg);
|
|
|
|
assert.throws(() => dns.lookup(common.mustNotCall(), common.mustNotCall()),
|
|
errorReg);
|
|
}
|
|
|
|
// dns.lookup should accept falsey values
|
|
{
|
|
const checkCallback = (err, address, family) => {
|
|
assert.ifError(err);
|
|
assert.strictEqual(address, null);
|
|
assert.strictEqual(family, 4);
|
|
};
|
|
|
|
assert.doesNotThrow(() => dns.lookup('', common.mustCall(checkCallback)));
|
|
|
|
assert.doesNotThrow(() => dns.lookup(null, common.mustCall(checkCallback)));
|
|
|
|
assert.doesNotThrow(() => dns.lookup(undefined,
|
|
common.mustCall(checkCallback)));
|
|
|
|
assert.doesNotThrow(() => dns.lookup(0, common.mustCall(checkCallback)));
|
|
|
|
assert.doesNotThrow(() => dns.lookup(NaN, common.mustCall(checkCallback)));
|
|
}
|
|
|
|
/*
|
|
* Make sure that dns.lookup throws if hints does not represent a valid flag.
|
|
* (dns.V4MAPPED | dns.ADDRCONFIG) + 1 is invalid because:
|
|
* - it's different from dns.V4MAPPED and dns.ADDRCONFIG.
|
|
* - it's different from them bitwise ored.
|
|
* - it's different from 0.
|
|
* - it's an odd number different than 1, and thus is invalid, because
|
|
* flags are either === 1 or even.
|
|
*/
|
|
assert.throws(() => {
|
|
dns.lookup('nodejs.org', { hints: (dns.V4MAPPED | dns.ADDRCONFIG) + 1 },
|
|
common.mustNotCall());
|
|
}, /^TypeError: Invalid argument: hints must use valid flags$/);
|
|
|
|
assert.throws(() => dns.lookup('nodejs.org'),
|
|
/^TypeError: Invalid arguments: callback must be passed$/);
|
|
|
|
assert.throws(() => dns.lookup('nodejs.org', 4),
|
|
/^TypeError: Invalid arguments: callback must be passed$/);
|
|
|
|
assert.doesNotThrow(() => dns.lookup('', {family: 4, hints: 0},
|
|
common.mustCall()));
|
|
|
|
assert.doesNotThrow(() => {
|
|
dns.lookup('', {
|
|
family: 6,
|
|
hints: dns.ADDRCONFIG
|
|
}, common.mustCall());
|
|
});
|
|
|
|
assert.doesNotThrow(() => dns.lookup('', {hints: dns.V4MAPPED},
|
|
common.mustCall()));
|
|
|
|
assert.doesNotThrow(() => {
|
|
dns.lookup('', {
|
|
hints: dns.ADDRCONFIG | dns.V4MAPPED
|
|
}, common.mustCall());
|
|
});
|
|
|
|
assert.throws(() => dns.lookupService('0.0.0.0'),
|
|
/^Error: Invalid arguments$/);
|
|
|
|
assert.throws(() => dns.lookupService('fasdfdsaf', 0, common.mustNotCall()),
|
|
/^TypeError: "host" argument needs to be a valid IP address$/);
|
|
|
|
assert.throws(() => dns.lookupService('0.0.0.0', null, common.mustNotCall()),
|
|
/^TypeError: "port" should be >= 0 and < 65536, got "null"$/);
|
|
|
|
assert.throws(
|
|
() => dns.lookupService('0.0.0.0', undefined, common.mustNotCall()),
|
|
/^TypeError: "port" should be >= 0 and < 65536, got "undefined"$/
|
|
);
|
|
|
|
assert.throws(() => dns.lookupService('0.0.0.0', 65538, common.mustNotCall()),
|
|
/^TypeError: "port" should be >= 0 and < 65536, got "65538"$/);
|
|
|
|
assert.throws(() => dns.lookupService('0.0.0.0', 'test', common.mustNotCall()),
|
|
/^TypeError: "port" should be >= 0 and < 65536, got "test"$/);
|
|
|
|
assert.throws(() => dns.lookupService('0.0.0.0', 80, null),
|
|
/^TypeError: "callback" argument must be a function$/);
|