mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
caee112e52
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
36 lines
1019 B
JavaScript
36 lines
1019 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const spawn = require('child_process').spawn;
|
|
const fs = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
if (common.isWindows) {
|
|
if (process.argv[2] === 'child') {
|
|
process.stdin;
|
|
process.stdout;
|
|
process.stderr;
|
|
return;
|
|
}
|
|
const python = process.env.PYTHON || 'python';
|
|
const script = fixtures.path('spawn_closed_stdio.py');
|
|
const proc = spawn(python, [script, process.execPath, __filename, 'child']);
|
|
proc.on('exit', common.mustCall(function(exitCode) {
|
|
assert.strictEqual(exitCode, 0);
|
|
}));
|
|
return;
|
|
}
|
|
|
|
if (process.argv[2] === 'child') {
|
|
[0, 1, 2].forEach((i) => fs.fstatSync(i));
|
|
return;
|
|
}
|
|
|
|
// Run the script in a shell but close stdout and stderr.
|
|
const cmd = `"${process.execPath}" "${__filename}" child 1>&- 2>&-`;
|
|
const proc = spawn('/bin/sh', ['-c', cmd], { stdio: 'inherit' });
|
|
|
|
proc.on('exit', common.mustCall(function(exitCode) {
|
|
assert.strictEqual(exitCode, 0);
|
|
}));
|