mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
2ec6995555
Remove the `performance.getEntries()` and `performance.clear*()` variants and eliminate the accumulation of the global timeline entries. The design of this particular bit of the API is a memory leak and performance footgun. The `PerformanceObserver` API is a better approach to consuming the data in a more transient way. PR-URL: https://github.com/nodejs/node/pull/19563 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
51 lines
1.3 KiB
JavaScript
51 lines
1.3 KiB
JavaScript
// Flags: --expose-gc
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
PerformanceObserver
|
|
} = require('perf_hooks');
|
|
|
|
const {
|
|
NODE_PERFORMANCE_GC_MAJOR,
|
|
NODE_PERFORMANCE_GC_MINOR,
|
|
NODE_PERFORMANCE_GC_INCREMENTAL,
|
|
NODE_PERFORMANCE_GC_WEAKCB
|
|
} = process.binding('performance').constants;
|
|
|
|
const kinds = [
|
|
NODE_PERFORMANCE_GC_MAJOR,
|
|
NODE_PERFORMANCE_GC_MINOR,
|
|
NODE_PERFORMANCE_GC_INCREMENTAL,
|
|
NODE_PERFORMANCE_GC_WEAKCB
|
|
];
|
|
|
|
// Adding an observer should force at least one gc to appear
|
|
{
|
|
const obs = new PerformanceObserver(common.mustCallAtLeast((list) => {
|
|
const entry = list.getEntries()[0];
|
|
assert(entry);
|
|
assert.strictEqual(entry.name, 'gc');
|
|
assert.strictEqual(entry.entryType, 'gc');
|
|
assert(kinds.includes(entry.kind));
|
|
assert.strictEqual(typeof entry.startTime, 'number');
|
|
assert.strictEqual(typeof entry.duration, 'number');
|
|
obs.disconnect();
|
|
}));
|
|
obs.observe({ entryTypes: ['gc'] });
|
|
global.gc();
|
|
// Keep the event loop alive to witness the GC async callback happen.
|
|
setImmediate(() => setImmediate(() => 0));
|
|
}
|
|
|
|
// GC should not keep the event loop alive
|
|
{
|
|
let didCall = false;
|
|
process.on('beforeExit', () => {
|
|
assert(!didCall);
|
|
didCall = true;
|
|
global.gc();
|
|
});
|
|
}
|