mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
644fdd60d4
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
46 lines
1.5 KiB
JavaScript
46 lines
1.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
if (!common.hasIntl)
|
|
common.skip('missing Intl');
|
|
|
|
const icu = process.binding('icu');
|
|
const assert = require('assert');
|
|
|
|
const tests = require('../fixtures/url-idna.js');
|
|
const wptToASCIITests = require('../fixtures/url-toascii.js');
|
|
|
|
{
|
|
for (const [i, { ascii, unicode }] of tests.entries()) {
|
|
assert.strictEqual(ascii, icu.toASCII(unicode), `toASCII(${i + 1})`);
|
|
assert.strictEqual(unicode, icu.toUnicode(ascii), `toUnicode(${i + 1})`);
|
|
assert.strictEqual(ascii, icu.toASCII(icu.toUnicode(ascii)),
|
|
`toASCII(toUnicode(${i + 1}))`);
|
|
assert.strictEqual(unicode, icu.toUnicode(icu.toASCII(unicode)),
|
|
`toUnicode(toASCII(${i + 1}))`);
|
|
}
|
|
}
|
|
|
|
{
|
|
const errMessage = /^Error: Cannot convert name to ASCII$/;
|
|
|
|
for (const [i, test] of wptToASCIITests.entries()) {
|
|
if (typeof test === 'string')
|
|
continue; // skip comments
|
|
const { comment, input, output } = test;
|
|
let caseComment = `case ${i + 1}`;
|
|
if (comment)
|
|
caseComment += ` (${comment})`;
|
|
if (output === null) {
|
|
assert.throws(() => icu.toASCII(input),
|
|
errMessage, `ToASCII ${caseComment}`);
|
|
icu.toASCII(input, true); // Should not throw.
|
|
} else {
|
|
assert.strictEqual(icu.toASCII(input), output, `ToASCII ${caseComment}`);
|
|
assert.strictEqual(icu.toASCII(input, true), output,
|
|
`ToASCII ${caseComment} in lenient mode`);
|
|
}
|
|
icu.toUnicode(input); // Should not throw.
|
|
}
|
|
}
|