0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-29 23:16:30 +01:00
nodejs/test/parallel/test-http2-server-errors.js
Matteo Collina 8403f00dc3 http2: fixes error handling
There should be no default error handling when using Http2Stream.
All errors will end up in `'streamError'` on the server anyway,
but they are emitted on `'stream'` as well, otherwise some error
conditions are impossible to debug.

See: https://github.com/nodejs/node/pull/14991

PR-URL: https://github.com/nodejs/node/pull/19232
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-03-12 09:36:31 +01:00

91 lines
2.2 KiB
JavaScript

// Flags: --expose-internals
'use strict';
const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const assert = require('assert');
const h2 = require('http2');
// Errors should not be reported both in Http2ServerRequest
// and Http2ServerResponse
{
let expected = null;
const server = h2.createServer();
server.on('stream', common.mustCall(function(stream) {
stream.on('error', common.mustCall(function(err) {
assert.strictEqual(err, expected);
}));
stream.resume();
stream.write('hello');
expected = new Error('kaboom');
stream.destroy(expected);
server.close();
}));
server.listen(0, common.mustCall(function() {
const port = server.address().port;
const url = `http://localhost:${port}`;
const client = h2.connect(url, common.mustCall(function() {
const headers = {
':path': '/foobar',
':method': 'GET',
':scheme': 'http',
':authority': `localhost:${port}`,
};
const request = client.request(headers);
request.on('data', common.mustCall(function(chunk) {
// cause an error on the server side
client.destroy();
}));
request.end();
}));
}));
}
{
let expected = null;
const server = h2.createServer();
process.on('uncaughtException', common.mustCall(function(err) {
assert.strictEqual(err.message, 'kaboom no handler');
}));
server.on('stream', common.mustCall(function(stream) {
// there is no 'error' handler, and this will crash
stream.write('hello');
stream.resume();
expected = new Error('kaboom no handler');
stream.destroy(expected);
server.close();
}));
server.listen(0, common.mustCall(function() {
const port = server.address().port;
const url = `http://localhost:${port}`;
const client = h2.connect(url, common.mustCall(function() {
const headers = {
':path': '/foobar',
':method': 'GET',
':scheme': 'http',
':authority': `localhost:${port}`,
};
const request = client.request(headers);
request.on('data', common.mustCall(function(chunk) {
// cause an error on the server side
client.destroy();
}));
request.end();
}));
}));
}