mirror of
https://github.com/nodejs/node.git
synced 2024-11-29 23:16:30 +01:00
cef909797a
Streams were recently updated to emit their own close event. The Http2Stream was an exception because it included the close argument with the close event. Refactor that to use the built in close. PR-URL: https://github.com/nodejs/node/pull/19451 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
72 lines
2.0 KiB
JavaScript
72 lines
2.0 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
const Countdown = require('../common/countdown');
|
|
|
|
const server = h2.createServer();
|
|
let client;
|
|
|
|
const countdown = new Countdown(3, () => {
|
|
server.close();
|
|
client.close();
|
|
});
|
|
|
|
// we use the lower-level API here
|
|
server.on('stream', common.mustCall((stream) => {
|
|
// The first pushStream will complete as normal
|
|
stream.pushStream({
|
|
':path': '/foobar',
|
|
}, common.mustCall((err, pushedStream) => {
|
|
assert.ifError(err);
|
|
pushedStream.respond();
|
|
pushedStream.end();
|
|
pushedStream.on('aborted', common.mustNotCall());
|
|
}));
|
|
|
|
// The second pushStream will be aborted because the client
|
|
// will reject it due to the maxReservedRemoteStreams option
|
|
// being set to only 1
|
|
stream.pushStream({
|
|
':path': '/foobar',
|
|
}, common.mustCall((err, pushedStream) => {
|
|
assert.ifError(err);
|
|
pushedStream.respond();
|
|
pushedStream.on('aborted', common.mustCall());
|
|
pushedStream.on('error', common.mustNotCall());
|
|
pushedStream.on('close', common.mustCall(() => {
|
|
assert.strictEqual(pushedStream.rstCode, 8);
|
|
countdown.dec();
|
|
}));
|
|
}));
|
|
|
|
stream.respond();
|
|
stream.end('hello world');
|
|
}));
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
client = h2.connect(`http://localhost:${server.address().port}`,
|
|
{ maxReservedRemoteStreams: 1 });
|
|
|
|
const req = client.request();
|
|
|
|
// Because maxReservedRemoteStream is 1, the stream event
|
|
// must only be emitted once, even tho the server sends
|
|
// two push streams.
|
|
client.on('stream', common.mustCall((stream) => {
|
|
stream.resume();
|
|
stream.on('push', common.mustCall());
|
|
stream.on('end', common.mustCall());
|
|
stream.on('close', common.mustCall(() => countdown.dec()));
|
|
}));
|
|
|
|
req.on('response', common.mustCall());
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => countdown.dec()));
|
|
}));
|