mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
aa97ae7cf8
* Exclude `derb.cpp` as well as `derb.c` from Node builds (file was renamed in ICU 56) ICU 56 renamed derb.c to derb.cpp because of C++ yay. This broke the exclusion of "derb.c" when building tools. Solution is to add derb.c AND derb.cpp to exclusion. We don't build the 'derb' tool, so it's fine to list the excluded source twice. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/3066 Fixes: https://github.com/nodejs/node/issues/3065 |
||
---|---|---|
.. | ||
patches | ||
icu_small.json | ||
icu-generic.gyp | ||
icu-system.gyp | ||
iculslocs.cc | ||
icutrim.py | ||
no-op.cc | ||
README.md |
Notes about the icu directory.
The files in this directory were written for the node.js effort. It's the intent of their author (Steven R. Loomis / srl295) to merge them upstream into ICU, pending much discussion within the ICU-PMC.
icu_small.json
is somewhat node-specific as it specifies a "small ICU"
configuration file for the icutrim.py
script. icutrim.py
and
iculslocs.cpp
may themselves be superseded by components built into
ICU in the future.
The following tickets were opened during this work, and their resolution may inform the reader as to the current state of icu-trim upstream:
- #10919 (experimental branch - may copy any source patches here)
- #10922 (data packaging improvements)
- #10923 (rewrite data building in python)
When/if components (not including the .json
file) are merged into
ICU, this code and configure
will be updated to detect and use those
variants rather than the ones in this directory.