0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-29 23:16:30 +01:00
nodejs/lib
Jose M. Palacios Diaz 845633a7c6
crypto: better docs for cases where peer's public key is invalid
changes in c++ are in the computeSecret function, but the thrown
exception that was moved to JS land was in BufferToPoint
function, here i let the allocation error be thrown so the only value
returned is the nullptr that i use later to catch the error in
computeSecret, to then construct the exception in JS land.

an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js
and with that, subsequent changes to docs and tests were made.

PR-URL: https://github.com/nodejs/node/pull/16849
Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf
Fixes: https://github.com/nodejs/node/issues/16625
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
2017-12-01 21:18:11 +01:00
..
internal crypto: better docs for cases where peer's public key is invalid 2017-12-01 21:18:11 +01:00
_http_agent.js lib: replace string concatenation with template 2017-11-11 10:52:23 +01:00
_http_client.js lib: replace string concatenation with template 2017-11-17 11:06:01 +01:00
_http_common.js http: do not assign intermediate variable 2017-11-28 02:39:33 +01:00
_http_incoming.js tools: enable additional eslint rules 2017-10-19 13:54:14 -04:00
_http_outgoing.js lib: improve the usage of TypeError[INVALID_ARG_TYPE] 2017-11-12 11:04:06 -08:00
_http_server.js http, stream: writeHWM -> writableHighWaterMark 2017-11-15 19:12:08 +01:00
_stream_duplex.js stream: remove usage of *State.highWaterMark 2017-11-15 14:30:39 +01:00
_stream_passthrough.js
_stream_readable.js stream: improve the error message of ERR_INVALID_ARG_TYPE 2017-11-22 08:30:10 -08:00
_stream_transform.js stream: migrate to internal/errors 2017-10-01 20:37:00 -03:00
_stream_wrap.js lib: move _stream_wrap into internals 2017-10-19 18:06:27 +02:00
_stream_writable.js stream: improve the error message of ERR_INVALID_ARG_TYPE 2017-11-22 08:30:10 -08:00
_tls_common.js tls: implement clientCertEngine option 2017-11-11 13:35:23 -08:00
_tls_legacy.js tools: enable additional eslint rules 2017-10-19 13:54:14 -04:00
_tls_wrap.js async_wrap: add provider types for net server 2017-11-28 02:50:54 +01:00
.eslintrc.yaml
assert.js tools: prohibit notDeepEqual usage 2017-11-28 03:10:10 +01:00
async_hooks.js async_hooks: remove deprecated API 2017-11-22 11:25:03 +01:00
buffer.js buffer: don't predefine error 2017-11-18 20:44:56 +01:00
child_process.js errors, child_process: use internal/errors codes 2017-11-29 18:14:27 -05:00
cluster.js
console.js console: add support for console.debug 2017-11-18 12:38:59 +01:00
constants.js
crypto.js crypto: migrate setFipsCrypto to internal/errors 2017-10-27 08:13:01 -07:00
dgram.js async_hooks: deprecate undocumented API 2017-11-20 12:03:06 +01:00
dns.js lib: improve the usage of TypeError[INVALID_ARG_TYPE] 2017-11-12 11:04:06 -08:00
domain.js process: add flag for uncaught exception abort 2017-11-29 15:58:42 +01:00
events.js events: remove emit micro-optimizations 2017-11-14 10:46:57 -08:00
fs.js fs: throw fs.access errors in JS 2017-11-25 22:33:42 +09:00
http2.js
http.js lib: use destructuring for some constants 2017-10-16 23:34:32 +02:00
https.js tls: implement clientCertEngine option 2017-11-11 13:35:23 -08:00
inspector.js lib: improve the usage of TypeError[INVALID_ARG_TYPE] 2017-11-12 11:04:06 -08:00
module.js module: Set dynamic import callback 2017-11-29 14:16:43 -08:00
net.js async_wrap: add provider types for net server 2017-11-28 02:50:54 +01:00
os.js os: migrate node_os.cc to internal/errors 2017-11-02 11:58:38 -07:00
path.js benchmark,path: remove unused variables 2017-11-22 14:36:38 -08:00
perf_hooks.js
process.js
punycode.js
querystring.js querystring: convert to using internal/errors 2017-10-28 14:04:53 -04:00
readline.js lib: use destructuring for some constants 2017-10-16 23:34:32 +02:00
repl.js repl: support top-level await 2017-11-16 15:42:46 -08:00
stream.js lib: use destructuring for some constants 2017-10-16 23:34:32 +02:00
string_decoder.js lib: use destructuring for some constants 2017-10-16 23:34:32 +02:00
sys.js
timers.js timers: clean up for readability 2017-11-28 16:32:15 -05:00
tls.js doc: document tls.checkServerIdentity 2017-12-01 20:44:52 +01:00
tty.js tty: refactor exports 2017-11-14 17:31:26 -05:00
url.js lib: improve the usage of TypeError[INVALID_ARG_TYPE] 2017-11-12 11:04:06 -08:00
util.js util: use @@toStringTag 2017-12-01 21:00:33 +01:00
v8.js v8: migrate setFlagsFromString to internal/errors 2017-10-29 17:04:27 -07:00
vm.js lib,src: remove vm.runInDebugContext() 2017-11-24 00:13:44 +01:00
zlib.js zlib: remove unnecessary else branch 2017-11-22 09:05:12 -08:00