mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
500720f578
This improves Node.js errors by always showing the attached properties when inspecting such an error. This applies especially to SystemError. It did often not show any properties but now all properties will be visible. This is done in a mainly backwards compatible way. Instead of using prototype getters and setters, the property is now set directly on the error. PR-URL: https://github.com/nodejs/node/pull/29677 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
134 lines
4.4 KiB
JavaScript
134 lines
4.4 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const {
|
|
hijackStdout,
|
|
restoreStdout,
|
|
} = require('../common/hijackstdio');
|
|
|
|
const assert = require('assert');
|
|
const errors = require('internal/errors');
|
|
|
|
// Turn off ANSI color formatting for this test file.
|
|
const { inspect } = require('util');
|
|
inspect.defaultOptions.colors = false;
|
|
|
|
errors.E('TEST_ERROR_1', 'Error for testing purposes: %s',
|
|
Error, TypeError, RangeError);
|
|
errors.E('TEST_ERROR_2', (a, b) => `${a} ${b}`, Error);
|
|
|
|
{
|
|
const err = new errors.codes.TEST_ERROR_1('test');
|
|
assert(err instanceof Error);
|
|
assert.strictEqual(err.name, 'Error');
|
|
assert.strictEqual(err.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err.code, 'TEST_ERROR_1');
|
|
}
|
|
|
|
{
|
|
const err = new errors.codes.TEST_ERROR_1.TypeError('test');
|
|
assert(err instanceof TypeError);
|
|
assert.strictEqual(err.name, 'TypeError');
|
|
assert.strictEqual(err.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err.code, 'TEST_ERROR_1');
|
|
}
|
|
|
|
{
|
|
const err = new errors.codes.TEST_ERROR_1.RangeError('test');
|
|
assert(err instanceof RangeError);
|
|
assert.strictEqual(err.name, 'RangeError');
|
|
assert.strictEqual(err.message, 'Error for testing purposes: test');
|
|
assert.strictEqual(err.code, 'TEST_ERROR_1');
|
|
}
|
|
|
|
{
|
|
const err = new errors.codes.TEST_ERROR_2('abc', 'xyz');
|
|
assert(err instanceof Error);
|
|
assert.strictEqual(err.name, 'Error');
|
|
assert.strictEqual(err.message, 'abc xyz');
|
|
assert.strictEqual(err.code, 'TEST_ERROR_2');
|
|
}
|
|
|
|
{
|
|
common.expectsInternalAssertion(
|
|
() => new errors.codes.TEST_ERROR_1(),
|
|
'Code: TEST_ERROR_1; The provided arguments ' +
|
|
'length (0) does not match the required ones (1).'
|
|
);
|
|
}
|
|
|
|
// Tests for common.expectsError
|
|
common.expectsError(() => {
|
|
throw new errors.codes.TEST_ERROR_1.TypeError('a');
|
|
}, { code: 'TEST_ERROR_1' });
|
|
common.expectsError(() => {
|
|
throw new errors.codes.TEST_ERROR_1.TypeError('a');
|
|
}, { code: 'TEST_ERROR_1',
|
|
type: TypeError,
|
|
message: /^Error for testing/ });
|
|
common.expectsError(() => {
|
|
throw new errors.codes.TEST_ERROR_1.TypeError('a');
|
|
}, { code: 'TEST_ERROR_1', type: TypeError });
|
|
common.expectsError(() => {
|
|
throw new errors.codes.TEST_ERROR_1.TypeError('a');
|
|
}, {
|
|
code: 'TEST_ERROR_1',
|
|
type: TypeError,
|
|
message: 'Error for testing purposes: a'
|
|
});
|
|
|
|
// Test that `code` property is mutable and that changing it does not change the
|
|
// name.
|
|
{
|
|
const myError = new errors.codes.TEST_ERROR_1('foo');
|
|
assert.strictEqual(myError.code, 'TEST_ERROR_1');
|
|
assert.strictEqual(myError.hasOwnProperty('code'), true);
|
|
assert.strictEqual(myError.hasOwnProperty('name'), false);
|
|
assert.deepStrictEqual(Object.keys(myError), ['code']);
|
|
const initialName = myError.name;
|
|
myError.code = 'FHQWHGADS';
|
|
assert.strictEqual(myError.code, 'FHQWHGADS');
|
|
assert.strictEqual(myError.name, initialName);
|
|
assert.deepStrictEqual(Object.keys(myError), ['code']);
|
|
assert.ok(!myError.name.includes('TEST_ERROR_1'));
|
|
assert.ok(!myError.name.includes('FHQWHGADS'));
|
|
}
|
|
|
|
// Test that `name` is mutable and that changing it alters `toString()` but not
|
|
// `console.log()` results, which is the behavior of `Error` objects in the
|
|
// browser. Note that `name` becomes enumerable after being assigned.
|
|
{
|
|
const myError = new errors.codes.TEST_ERROR_1('foo');
|
|
assert.deepStrictEqual(Object.keys(myError), ['code']);
|
|
const initialToString = myError.toString();
|
|
|
|
myError.name = 'Fhqwhgads';
|
|
assert.deepStrictEqual(Object.keys(myError), ['code', 'name']);
|
|
assert.notStrictEqual(myError.toString(), initialToString);
|
|
}
|
|
|
|
// Test that `message` is mutable and that changing it alters `toString()` but
|
|
// not `console.log()` results, which is the behavior of `Error` objects in the
|
|
// browser. Note that `message` remains non-enumerable after being assigned.
|
|
{
|
|
let initialConsoleLog = '';
|
|
hijackStdout((data) => { initialConsoleLog += data; });
|
|
const myError = new errors.codes.TEST_ERROR_1('foo');
|
|
assert.deepStrictEqual(Object.keys(myError), ['code']);
|
|
const initialToString = myError.toString();
|
|
console.log(myError);
|
|
assert.notStrictEqual(initialConsoleLog, '');
|
|
|
|
restoreStdout();
|
|
|
|
let subsequentConsoleLog = '';
|
|
hijackStdout((data) => { subsequentConsoleLog += data; });
|
|
myError.message = 'Fhqwhgads';
|
|
assert.deepStrictEqual(Object.keys(myError), ['code']);
|
|
assert.notStrictEqual(myError.toString(), initialToString);
|
|
console.log(myError);
|
|
assert.strictEqual(subsequentConsoleLog, initialConsoleLog);
|
|
|
|
restoreStdout();
|
|
}
|