mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
ac2fc0dd5f
ERR_INVALID_ARG_TYPE is the most common error used throughout the code base. This improves the error message by providing more details to the user and by indicating more precisely which values are allowed ones and which ones are not. It adds the actual input to the error message in case it's a primitive. If it's a class instance, it'll print the class name instead of "object" and "falsy" or similar entries are not named "type" anymore. PR-URL: https://github.com/nodejs/node/pull/29675 Reviewed-By: Rich Trott <rtrott@gmail.com>
84 lines
2.6 KiB
JavaScript
84 lines
2.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
const fs = require('fs');
|
|
|
|
// This test ensures that input for fchmod is valid, testing for valid
|
|
// inputs for fd and mode
|
|
|
|
// Check input type
|
|
[false, null, undefined, {}, [], ''].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "fd" argument must be of type number.' +
|
|
common.invalidArgTypeHelper(input)
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
});
|
|
|
|
|
|
[false, null, undefined, {}, [], '', '123x'].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
name: 'TypeError',
|
|
message: 'The argument \'mode\' must be a 32-bit unsigned integer or an ' +
|
|
`octal string. Received ${util.inspect(input)}`
|
|
};
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be >= 0 && <= ' +
|
|
`2147483647. Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
});
|
|
|
|
[-1, 2 ** 32].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "mode" is out of range. It must be >= 0 && <= ' +
|
|
`4294967295. Received ${input}`
|
|
};
|
|
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[NaN, Infinity].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
errObj.message = errObj.message.replace('fd', 'mode');
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|
|
|
|
[1.5].forEach((input) => {
|
|
const errObj = {
|
|
code: 'ERR_OUT_OF_RANGE',
|
|
name: 'RangeError',
|
|
message: 'The value of "fd" is out of range. It must be an integer. ' +
|
|
`Received ${input}`
|
|
};
|
|
assert.throws(() => fs.fchmod(input), errObj);
|
|
assert.throws(() => fs.fchmodSync(input), errObj);
|
|
errObj.message = errObj.message.replace('fd', 'mode');
|
|
assert.throws(() => fs.fchmod(1, input), errObj);
|
|
assert.throws(() => fs.fchmodSync(1, input), errObj);
|
|
});
|