mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
1432065e9d
Historically `error.errno` of system errors thrown by Node.js
can sometimes be the same as `err.code`, which are string
representations of the error numbers. This is useless and incorrect,
and results in an information loss for users since then they
will have to resort to something like
`process.binding('uv'[`UV_${errno}`])` to get to the numeric
error codes.
This patch corrects this behavior by always setting `error.errno`
to be negative numbers. For fabricated errors like `ENOTFOUND`,
`error.errno` is now undefined since there is no numeric equivalent
for them anyway. For c-ares errors, `error.errno` is now undefined
because the numeric representations (negated) can be in conflict
with libuv error codes - this is fine since numeric codes was
not available for c-ares errors anyway.
Users can use the public API `util.getSystemErrorName(errno)`
to retrieve string codes for these numbers.
PR-URL: https://github.com/nodejs/node/pull/28140
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
65 lines
2.5 KiB
JavaScript
65 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { spawnSync } = require('child_process');
|
|
const { getSystemErrorName } = require('util');
|
|
|
|
// `sleep` does different things on Windows and Unix, but in both cases, it does
|
|
// more-or-less nothing if there are no parameters
|
|
const ret = spawnSync('sleep', ['0']);
|
|
assert.strictEqual(ret.status, 0);
|
|
|
|
// Error test when command does not exist
|
|
const ret_err = spawnSync('command_does_not_exist', ['bar']).error;
|
|
|
|
assert.strictEqual(ret_err.code, 'ENOENT');
|
|
assert.strictEqual(getSystemErrorName(ret_err.errno), 'ENOENT');
|
|
assert.strictEqual(ret_err.syscall, 'spawnSync command_does_not_exist');
|
|
assert.strictEqual(ret_err.path, 'command_does_not_exist');
|
|
assert.deepStrictEqual(ret_err.spawnargs, ['bar']);
|
|
|
|
{
|
|
// Test the cwd option
|
|
const cwd = common.rootDir;
|
|
const response = spawnSync(...common.pwdCommand, { cwd });
|
|
|
|
assert.strictEqual(response.stdout.toString().trim(), cwd);
|
|
}
|
|
|
|
|
|
{
|
|
// Assert Buffer is the default encoding
|
|
const retDefault = spawnSync(...common.pwdCommand);
|
|
const retBuffer = spawnSync(...common.pwdCommand, { encoding: 'buffer' });
|
|
assert.deepStrictEqual(retDefault.output, retBuffer.output);
|
|
|
|
const retUTF8 = spawnSync(...common.pwdCommand, { encoding: 'utf8' });
|
|
const stringifiedDefault = [
|
|
null,
|
|
retDefault.stdout.toString(),
|
|
retDefault.stderr.toString()
|
|
];
|
|
assert.deepStrictEqual(retUTF8.output, stringifiedDefault);
|
|
}
|