0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 15:30:56 +01:00
nodejs/lib
Anna Henningsen c45313b3ad worker: perform initial port.unref() before preload modules
The refcount of the internal communication port is relevant for
stdio, but the `port.unref()` call effectively resets any `.ref()`
calls happening during stdio operations happening before it.

Therefore, do the `.unref()` call before loading preload modules,
which may cause stdio operations.

Fixes: https://github.com/nodejs/node/issues/31777

PR-URL: https://github.com/nodejs/node/pull/33455
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2020-05-21 17:50:04 -07:00
..
fs fs: add fs/promises alias module 2020-02-18 22:15:50 -08:00
internal worker: perform initial port.unref() before preload modules 2020-05-21 17:50:04 -07:00
_http_agent.js http: added scheduling option to http agent 2020-05-20 11:00:14 +02:00
_http_client.js http: don't destroy completed request 2020-05-11 18:02:32 +02:00
_http_common.js http: fixes memory retention issue with FreeList and HTTPParser 2020-05-05 16:14:46 +02:00
_http_incoming.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
_http_outgoing.js http: don't throw on Uint8Arrays for http.ServerResponse#write 2020-05-16 10:46:10 +02:00
_http_server.js http: emit 'error' on aborted server request 2020-05-10 22:11:21 +02:00
_stream_duplex.js stream: forward writableObjectMode 2020-05-19 00:02:32 +02:00
_stream_passthrough.js
_stream_readable.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
_stream_transform.js stream: fix _final and 'prefinish' timing 2020-04-22 09:40:03 +02:00
_stream_wrap.js
_stream_writable.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
_tls_common.js
_tls_wrap.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
.eslintrc.yaml
assert.js assert: port common.mustCall() to assert 2020-04-23 10:11:47 -07:00
async_hooks.js async_hooks: move PromiseHook handler to JS 2020-05-09 07:52:22 +02:00
buffer.js buffer: improve copy() performance 2020-05-09 08:04:10 +02:00
child_process.js
cluster.js
console.js
constants.js
crypto.js tls: provide default cipher list from command line 2020-04-13 18:48:23 +02:00
dgram.js lib: move isLegalPort to validators, refactor 2020-03-05 11:52:53 -08:00
dns.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
domain.js
events.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
fs.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
http2.js
http.js http: expose http.validate-header-name/value 2020-05-09 07:55:55 +02:00
https.js
inspector.js
module.js
net.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
os.js src: create a getter for kernel version 2020-03-09 12:44:16 +01:00
path.js path: fix comment grammar 2020-04-28 19:10:26 +02:00
perf_hooks.js perf_hooks: fix error message for invalid entryTypes 2020-05-10 13:53:15 +02:00
process.js
punycode.js
querystring.js
readline.js lib: update TODO comments 2020-05-20 17:05:06 +02:00
repl.js repl: simplify repl autocompletion 2020-05-20 17:31:47 +02:00
stream.js
string_decoder.js
sys.js
timers.js lib: created isValidCallback helper 2020-04-14 13:54:21 +08:00
tls.js tls: provide default cipher list from command line 2020-04-13 18:48:23 +02:00
trace_events.js
tty.js
url.js
util.js
v8.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
vm.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00
wasi.js wasi: update start() behavior to match spec 2020-04-28 13:04:43 -04:00
worker_threads.js
zlib.js tools: enable no-else-return lint rule 2020-05-16 06:42:16 +02:00