0
0
mirror of https://github.com/nodejs/node.git synced 2024-12-01 16:10:02 +01:00
nodejs/benchmark/fs
Сковорода Никита Андреевич c594d15170 fs: drop duplicate API in promises mode
This drops exporting duplicate methods that accept FileHandle as the
first argument (to mirror callback-based methods accepting 'fd').

Those methods were not adding actual value to the API because all of
those are already present as FileHandle methods, and they would
probably be confusing to the new users and making docs harder to read.

Also, the API was a bit inconsistent and lacked .close(handle).

Fixes: https://github.com/nodejs/node/issues/20548
PR-URL: https://github.com/nodejs/node/pull/20559
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-05-19 11:04:28 +03:00
..
bench-readdir.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
bench-readdirSync.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
bench-realpath.js benchmark: refactor 2018-02-01 10:49:04 +01:00
bench-realpathSync.js benchmark: refactor 2018-02-01 10:49:04 +01:00
bench-stat-promise.js fs: drop duplicate API in promises mode 2018-05-19 11:04:28 +03:00
bench-stat.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
bench-statSync.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
read-stream-throughput.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
readfile-partitioned.js fs: partition readFile against pool exhaustion 2018-02-01 11:11:48 +01:00
readfile.js fs: partition readFile against pool exhaustion 2018-02-01 11:11:48 +01:00
readFileSync.js benchmark: (fs) use destructuring 2018-01-23 01:29:29 +01:00
write-stream-throughput.js benchmark: refactor 2018-02-01 10:49:04 +01:00