mirror of
https://github.com/nodejs/node.git
synced 2024-11-30 07:27:22 +01:00
d4374ad651
CRLF variable was defined but only used on line 22 so the variable was deleted and placed inside line 22 as a string literal. This was in file test-httpparser.request.js On line 46 there's a function declared that takes 3 arguments but none of them are ever used so removed. This is in file test-httpparser.response.js PR-URL: https://github.com/nodejs/node/pull/14818 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const tick = require('./tick');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
|
|
const binding = process.binding('http_parser');
|
|
const HTTPParser = binding.HTTPParser;
|
|
|
|
const REQUEST = HTTPParser.REQUEST;
|
|
|
|
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
|
|
|
|
const hooks = initHooks();
|
|
|
|
hooks.enable();
|
|
|
|
const request = Buffer.from(
|
|
'GET /hello HTTP/1.1\r\n\r\n'
|
|
);
|
|
|
|
const parser = new HTTPParser(REQUEST);
|
|
const as = hooks.activitiesOfTypes('HTTPPARSER');
|
|
const httpparser = as[0];
|
|
|
|
assert.strictEqual(as.length, 1);
|
|
assert.strictEqual(typeof httpparser.uid, 'number');
|
|
assert.strictEqual(typeof httpparser.triggerAsyncId, 'number');
|
|
checkInvocations(httpparser, { init: 1 }, 'when created new Httphttpparser');
|
|
|
|
parser[kOnHeadersComplete] = common.mustCall(onheadersComplete);
|
|
parser.execute(request, 0, request.length);
|
|
|
|
function onheadersComplete() {
|
|
checkInvocations(httpparser, { init: 1, before: 1 },
|
|
'when onheadersComplete called');
|
|
tick(1, common.mustCall(tick1));
|
|
}
|
|
|
|
function tick1() {
|
|
parser.close();
|
|
tick(1);
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('HTTPPARSER');
|
|
checkInvocations(httpparser, { init: 1, before: 1, after: 1, destroy: 1 },
|
|
'when process exits');
|
|
}
|