0
0
mirror of https://github.com/nodejs/node.git synced 2024-11-30 07:27:22 +01:00
nodejs/tools/eslint-rules/no-let-in-for-declaration.js
cjihrig 746534b973
tools: simplify no-let-in-for-declaration rule
PR-URL: https://github.com/nodejs/node/pull/17572
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
2017-12-11 21:04:49 -05:00

39 lines
1.1 KiB
JavaScript

/**
* @fileoverview Prohibit the use of `let` as the loop variable
* in the initialization of for, and the left-hand
* iterator in forIn and forOf loops.
*
* @author Jessica Quynh Tran
*/
'use strict';
//------------------------------------------------------------------------------
// Rule Definition
//------------------------------------------------------------------------------
const message = 'Use of `let` as the loop variable in a for-loop is ' +
'not recommended. Please use `var` instead.';
const forSelector = 'ForStatement[init.kind="let"]';
const forInOfSelector = 'ForOfStatement[left.kind="let"],' +
'ForInStatement[left.kind="let"]';
module.exports = {
create(context) {
const sourceCode = context.getSourceCode();
function report(node) {
context.report({
node,
message,
fix: (fixer) =>
fixer.replaceText(sourceCode.getFirstToken(node), 'var')
});
}
return {
[forSelector]: (node) => report(node.init),
[forInOfSelector]: (node) => report(node.left),
};
}
};