mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
99b27ce99a
The ES addition operator calls the ToPrimitive() abstract operation without hint String, leading a subsequent OrdinaryToPrimitive() to call valueOf() first on an object rather than the desired toString(). Instead, use template literals which directly call ToString() abstract operation, per Web IDL spec. PR-URL: https://github.com/nodejs/node/pull/11737 Fixes:b610a4db1c"url: enforce valid UTF-8 in WHATWG parser" Refs:b610a4db1c (commitcomment-21200056)Refs: https://tc39.github.io/ecma262/#sec-addition-operator-plus-runtime-semantics-evaluation Refs: https://tc39.github.io/ecma262/#sec-template-literals-runtime-semantics-evaluation Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
76 lines
2.6 KiB
JavaScript
76 lines
2.6 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { URL, URLSearchParams } = require('url');
|
|
const { test, assert_equals, assert_true, assert_false } = common.WPT;
|
|
|
|
/* eslint-disable */
|
|
/* WPT Refs:
|
|
https://github.com/w3c/web-platform-tests/blob/8791bed/url/urlsearchparams-delete.html
|
|
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
|
|
*/
|
|
test(function() {
|
|
var params = new URLSearchParams('a=b&c=d');
|
|
params.delete('a');
|
|
assert_equals(params + '', 'c=d');
|
|
params = new URLSearchParams('a=a&b=b&a=a&c=c');
|
|
params.delete('a');
|
|
assert_equals(params + '', 'b=b&c=c');
|
|
params = new URLSearchParams('a=a&=&b=b&c=c');
|
|
params.delete('');
|
|
assert_equals(params + '', 'a=a&b=b&c=c');
|
|
params = new URLSearchParams('a=a&null=null&b=b');
|
|
params.delete(null);
|
|
assert_equals(params + '', 'a=a&b=b');
|
|
params = new URLSearchParams('a=a&undefined=undefined&b=b');
|
|
params.delete(undefined);
|
|
assert_equals(params + '', 'a=a&b=b');
|
|
}, 'Delete basics');
|
|
|
|
test(function() {
|
|
var params = new URLSearchParams();
|
|
params.append('first', 1);
|
|
assert_true(params.has('first'), 'Search params object has name "first"');
|
|
assert_equals(params.get('first'), '1', 'Search params object has name "first" with value "1"');
|
|
params.delete('first');
|
|
assert_false(params.has('first'), 'Search params object has no "first" name');
|
|
params.append('first', 1);
|
|
params.append('first', 10);
|
|
params.delete('first');
|
|
assert_false(params.has('first'), 'Search params object has no "first" name');
|
|
}, 'Deleting appended multiple');
|
|
/* eslint-enable */
|
|
|
|
// Tests below are not from WPT.
|
|
{
|
|
const params = new URLSearchParams();
|
|
assert.throws(() => {
|
|
params.delete.call(undefined);
|
|
}, /^TypeError: Value of `this` is not a URLSearchParams$/);
|
|
assert.throws(() => {
|
|
params.delete();
|
|
}, /^TypeError: "name" argument must be specified$/);
|
|
|
|
const obj = {
|
|
toString() { throw new Error('toString'); },
|
|
valueOf() { throw new Error('valueOf'); }
|
|
};
|
|
const sym = Symbol();
|
|
assert.throws(() => params.delete(obj), /^Error: toString$/);
|
|
assert.throws(() => params.delete(sym),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
}
|
|
|
|
// https://github.com/nodejs/node/issues/10480
|
|
// Emptying searchParams should correctly update url's query
|
|
{
|
|
const url = new URL('http://domain?var=1&var=2&var=3');
|
|
for (const param of url.searchParams.keys()) {
|
|
url.searchParams.delete(param);
|
|
}
|
|
assert.strictEqual(url.searchParams.toString(), '');
|
|
assert.strictEqual(url.search, '');
|
|
assert.strictEqual(url.href, 'http://domain/');
|
|
}
|