mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
86d74a248b
Ensure that AdjustAmountOfExternalAllocatedMemory() is called when the SecurePair is destroyed. Not doing so is not an actual memory leak but it makes `process.memoryUsage().external` wildly inaccurate and can cause performance problems due to excessive garbage collection. PR-URL: https://github.com/nodejs/node/pull/11896 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
30 lines
907 B
JavaScript
30 lines
907 B
JavaScript
// Flags: --expose-gc --no-deprecation
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
if (!common.hasCrypto) {
|
|
common.skip('missing crypto');
|
|
return;
|
|
}
|
|
|
|
const { createSecureContext } = require('tls');
|
|
const { createSecurePair } = require('_tls_legacy');
|
|
|
|
const before = process.memoryUsage().external;
|
|
{
|
|
const context = createSecureContext();
|
|
const options = {};
|
|
for (let i = 0; i < 1e4; i += 1)
|
|
createSecurePair(context, false, false, false, options).destroy();
|
|
}
|
|
global.gc();
|
|
const after = process.memoryUsage().external;
|
|
|
|
// It's not an exact science but a SecurePair grows .external by about 45 kB.
|
|
// Unless AdjustAmountOfExternalAllocatedMemory() is called on destruction,
|
|
// 10,000 instances make it grow by well over 400 MB. Allow for some slop
|
|
// because objects like buffers also affect the external limit.
|
|
assert(after - before < 25 << 20);
|