mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
7922830087
2a4b068aca introduced a regression in where checking
`instanceof` would fail for `Writable` subclasses inside the
subclass constructor, i.e. before `Writable()` was called.
Also, calling `null instanceof Writable` or
`undefined instanceof Writable` would fail due to accessing the
`_writableState` property of the target object.
This fixes these problems.
PR-URL: https://github.com/nodejs/node/pull/9088
Ref: https://github.com/nodejs/node/pull/8834#issuecomment-253640692
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
46 lines
1.5 KiB
JavaScript
46 lines
1.5 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const { Readable, Writable, Duplex, Transform } = require('stream');
|
|
|
|
const readable = new Readable({ read() {} });
|
|
const writable = new Writable({ write() {} });
|
|
const duplex = new Duplex({ read() {}, write() {} });
|
|
const transform = new Transform({ transform() {} });
|
|
|
|
assert.ok(readable instanceof Readable);
|
|
assert.ok(!(writable instanceof Readable));
|
|
assert.ok(duplex instanceof Readable);
|
|
assert.ok(transform instanceof Readable);
|
|
|
|
assert.ok(!(readable instanceof Writable));
|
|
assert.ok(writable instanceof Writable);
|
|
assert.ok(duplex instanceof Writable);
|
|
assert.ok(transform instanceof Writable);
|
|
|
|
assert.ok(!(readable instanceof Duplex));
|
|
assert.ok(!(writable instanceof Duplex));
|
|
assert.ok(duplex instanceof Duplex);
|
|
assert.ok(transform instanceof Duplex);
|
|
|
|
assert.ok(!(readable instanceof Transform));
|
|
assert.ok(!(writable instanceof Transform));
|
|
assert.ok(!(duplex instanceof Transform));
|
|
assert.ok(transform instanceof Transform);
|
|
|
|
assert.ok(!(null instanceof Writable));
|
|
assert.ok(!(undefined instanceof Writable));
|
|
|
|
// Simple inheritance check for `Writable` works fine in a subclass constructor.
|
|
function CustomWritable() {
|
|
assert.ok(this instanceof Writable, 'inherits from Writable');
|
|
assert.ok(this instanceof CustomWritable, 'inherits from CustomWritable');
|
|
}
|
|
|
|
Object.setPrototypeOf(CustomWritable, Writable);
|
|
Object.setPrototypeOf(CustomWritable.prototype, Writable.prototype);
|
|
|
|
new CustomWritable();
|
|
|
|
assert.throws(CustomWritable, /AssertionError: inherits from Writable/);
|