mirror of
https://github.com/nodejs/node.git
synced 2024-12-01 16:10:02 +01:00
05be62307d
* Remove unneeded temp dir cleanup * Add check for error in `.close()` callback * Improve error reporting On that last bullet point, the previous version of the test reported errors like this: ``` AssertionError: [ '.empty-repl-history-file', '.node_repl_history', 'GH-1899-output.js', 'GH-892-request.js', 'a.js', 'a1.js', 'agen deepStrictEqual [ '.empty-repl-history-file', '.node_repl_history', 'GH-1899-output.js', 'GH-892-request.js', 'a.js', 'a1.js', 'agen ``` Now, they look like this: ``` AssertionError: expected *, got ! by hex decoding 2a ``` PR-URL: https://github.com/nodejs/node/pull/11232 Reviewed-By: James M Snell <jasnell@gmail.com>
46 lines
1.1 KiB
JavaScript
46 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
assert.doesNotThrow(() => {
|
|
fs.access(Buffer.from(common.tmpDir), common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
}));
|
|
});
|
|
|
|
assert.doesNotThrow(() => {
|
|
const buf = Buffer.from(path.join(common.tmpDir, 'a.txt'));
|
|
fs.open(buf, 'w+', common.mustCall((err, fd) => {
|
|
assert.ifError(err);
|
|
assert(fd);
|
|
fs.close(fd, common.mustCall((err) => {
|
|
assert.ifError(err);
|
|
}));
|
|
}));
|
|
});
|
|
|
|
assert.throws(() => {
|
|
fs.accessSync(true);
|
|
}, /path must be a string or Buffer/);
|
|
|
|
const dir = Buffer.from(common.fixturesDir);
|
|
fs.readdir(dir, 'hex', common.mustCall((err, hexList) => {
|
|
assert.ifError(err);
|
|
fs.readdir(dir, common.mustCall((err, stringList) => {
|
|
assert.ifError(err);
|
|
stringList.forEach((val, idx) => {
|
|
const fromHexList = Buffer.from(hexList[idx], 'hex').toString();
|
|
assert.strictEqual(
|
|
fromHexList,
|
|
val,
|
|
`expected ${val}, got ${fromHexList} by hex decoding ${hexList[idx]}`
|
|
);
|
|
});
|
|
}));
|
|
}));
|